[test] Fix missing followup work [v8/v8 : main]
0 views
Skip to first unread message
Leszek Swirski (Gerrit)
Sep 4, 2025, 5:58:07 AM (3 days ago) Sep 4
to Patrick Thier, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Patrick Thier
Leszek Swirski voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Patrick Thier
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Thier (Gerrit)
Sep 4, 2025, 6:36:57 AM (3 days ago) Sep 4
to Leszek Swirski, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Leszek Swirski
Patrick Thier voted and added 2 comments![]( "Open in Gerrit")
Votes added by Patrick Thier
| Code-Review | +1 |
2 comments
Patchset-level comments
File test/unittests/interpreter/bytecode-expectations-parser.cc
Line 125, Patchset 1 (Latest):
} // namespace v8::internal::interpreter
>>>>>>> Conflict 1 of 1 endsPatrick Thier . unresolved
```suggestion
} // namespace v8::internal::interpreter
```
Related details
Attention is currently required from:
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
Sep 4, 2025, 6:41:38 AM (3 days ago) Sep 4
to Patrick Thier, V8 LUCI CQ, v8-re...@googlegroups.com
Leszek Swirski voted and added 1 comment![]( "Open in Gerrit")
Votes added by Leszek Swirski
| Auto-Submit | +1 |
| Commit-Queue | +2 |
} // namespace v8::internal::interpreter
>>>>>>> Conflict 1 of 1 endsPatrick Thier . resolved
```suggestion
} // namespace v8::internal::interpreter
```
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Sep 4, 2025, 7:08:38 AM (3 days ago) Sep 4
to Leszek Swirski, Patrick Thier, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: test/unittests/interpreter/bytecode-expectations-parser.cc
Insertions: 0, Deletions: 1.
@@ -124,4 +124,3 @@
}
} // namespace v8::internal::interpreter
->>>>>>> Conflict 1 of 1 ends
```
Change information
Commit message:
[test] Fix missing followup work
... from pressing +2 too eagerly on crrev.com/c/6912523
Change-Id: Idf888cbede7e049d7bba9253a548aa2720727a72
Auto-Submit: Leszek Swirski <les...@chromium.org>
Commit-Queue: Leszek Swirski <les...@chromium.org>
Reviewed-by: Patrick Thier <pth...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#102240}
Files:
- M test/unittests/interpreter/bytecode-expectations-parser.cc
Change size: S
Delta: 1 file changed, 8 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Patrick Thier
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages