[maglev] Implement StringSlice [v8/v8 : main]

0 views
Skip to first unread message

Marja Hölttä (Gerrit)

unread,
Feb 3, 2026, 10:15:19 AM (18 hours ago) Feb 3
to Leszek Swirski, AyeAye, V8 LUCI CQ, v8-mip...@googlegroups.com, v8-risc...@chromium.org, v8-ppc...@googlegroups.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Leszek Swirski

Marja Hölttä added 1 comment

File test/mjsunit/maglev/string-slice.js
Line 17, Patchset 4 (Latest):%NeverOptimizeFunction(slice_wrapper);
Marja Hölttä . unresolved

Sus! Should this be %NeverOptimizeFunction(test)?

Open in Gerrit

Related details

Attention is currently required from:
  • Leszek Swirski
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ieb35236f0a6092d0d29a3c6b7f57da885d435f35
Gerrit-Change-Number: 7539379
Gerrit-PatchSet: 4
Gerrit-Owner: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-CC: Marja Hölttä <ma...@chromium.org>
Gerrit-Attention: Leszek Swirski <les...@chromium.org>
Gerrit-Comment-Date: Tue, 03 Feb 2026 15:15:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Leszek Swirski (Gerrit)

unread,
Feb 3, 2026, 10:20:15 AM (18 hours ago) Feb 3
to Marja Hölttä, AyeAye, V8 LUCI CQ, v8-mip...@googlegroups.com, v8-risc...@chromium.org, v8-ppc...@googlegroups.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Marja Hölttä

Leszek Swirski added 1 comment

File test/mjsunit/maglev/string-slice.js
Line 17, Patchset 4 (Latest):%NeverOptimizeFunction(slice_wrapper);
Marja Hölttä . unresolved

Sus! Should this be %NeverOptimizeFunction(test)?

Leszek Swirski

oops yes -- the one line of human written code in this CL was wrong 😄

Open in Gerrit

Related details

Attention is currently required from:
  • Marja Hölttä
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ieb35236f0a6092d0d29a3c6b7f57da885d435f35
Gerrit-Change-Number: 7539379
Gerrit-PatchSet: 4
Gerrit-Owner: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-CC: Marja Hölttä <ma...@chromium.org>
Gerrit-Attention: Marja Hölttä <ma...@chromium.org>
Gerrit-Comment-Date: Tue, 03 Feb 2026 15:20:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marja Hölttä <ma...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Feb 3, 2026, 11:39:12 AM (17 hours ago) Feb 3
to Leszek Swirski, Marja Hölttä, AyeAye, V8 LUCI CQ, v8-mip...@googlegroups.com, v8-risc...@chromium.org, v8-ppc...@googlegroups.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Leszek Swirski and Marja Hölttä

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/jetstream-main.crossbench complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/1331a960f10000

Open in Gerrit

Related details

Attention is currently required from:
  • Leszek Swirski
  • Marja Hölttä
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ieb35236f0a6092d0d29a3c6b7f57da885d435f35
Gerrit-Change-Number: 7539379
Gerrit-PatchSet: 5
Gerrit-Owner: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-CC: Marja Hölttä <ma...@chromium.org>
Gerrit-Attention: Marja Hölttä <ma...@chromium.org>
Gerrit-Attention: Leszek Swirski <les...@chromium.org>
Gerrit-Comment-Date: Tue, 03 Feb 2026 16:39:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Feb 3, 2026, 11:39:48 AM (17 hours ago) Feb 3
to Leszek Swirski, Marja Hölttä, AyeAye, V8 LUCI CQ, v8-mip...@googlegroups.com, v8-risc...@chromium.org, v8-ppc...@googlegroups.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Leszek Swirski and Marja Hölttä

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/speedometer3.1.crossbench complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/11b964af710000

Gerrit-Comment-Date: Tue, 03 Feb 2026 16:39:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages