[maglev] Implement StringSlice [v8/v8 : main]
0 views
Skip to first unread message
Marja Hölttä (Gerrit)
Feb 3, 2026, 10:15:19 AM (18 hours ago) Feb 3
to Leszek Swirski, AyeAye, V8 LUCI CQ, v8-mip...@googlegroups.com, v8-risc...@chromium.org, v8-ppc...@googlegroups.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Leszek Swirski
Marja Hölttä added 1 comment![]( "Open in Gerrit")
File test/mjsunit/maglev/string-slice.js
Line 17, Patchset 4 (Latest):
%NeverOptimizeFunction(slice_wrapper);Marja Hölttä . unresolved
Sus! Should this be %NeverOptimizeFunction(test)?
Related details
Attention is currently required from:
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
Feb 3, 2026, 10:20:15 AM (18 hours ago) Feb 3
to Marja Hölttä, AyeAye, V8 LUCI CQ, v8-mip...@googlegroups.com, v8-risc...@chromium.org, v8-ppc...@googlegroups.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Marja Hölttä
Leszek Swirski added 1 comment![]( "Open in Gerrit")
File test/mjsunit/maglev/string-slice.js
Line 17, Patchset 4 (Latest):
%NeverOptimizeFunction(slice_wrapper);Marja Hölttä . unresolved
Sus! Should this be %NeverOptimizeFunction(test)?
Leszek Swirski
oops yes -- the one line of human written code in this CL was wrong 😄
Related details
Attention is currently required from:
- Marja Hölttä
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Feb 3, 2026, 11:39:12 AM (17 hours ago) Feb 3
to Leszek Swirski, Marja Hölttä, AyeAye, V8 LUCI CQ, v8-mip...@googlegroups.com, v8-risc...@chromium.org, v8-ppc...@googlegroups.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Leszek Swirski and Marja Hölttä
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/jetstream-main.crossbench complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/1331a960f10000
Related details
Attention is currently required from:
- Leszek Swirski
- Marja Hölttä
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Feb 3, 2026, 11:39:48 AM (17 hours ago) Feb 3
to Leszek Swirski, Marja Hölttä, AyeAye, V8 LUCI CQ, v8-mip...@googlegroups.com, v8-risc...@chromium.org, v8-ppc...@googlegroups.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Leszek Swirski and Marja Hölttä
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/speedometer3.1.crossbench complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/11b964af710000
Reply all
Reply to author
Forward
0 new messages