[base] Include operand values in CHECK failures for logging builds [v8/v8 : main]
0 views
Skip to first unread message
Clemens Backes (Gerrit)
11:28 AM (10 hours ago) 11:28 AM
to v8-s...@luci-project-accounts.iam.gserviceaccount.com, Jakob Kummerow, v8-re...@googlegroups.com
Attention needed from Jakob Kummerow
Clemens Backes added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Clemens Backes . resolved
PTAL. This will include more information on sandbox testing builders which are release builds but set v8_logging_level=2.
Related details
Attention is currently required from:
- Jakob Kummerow
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Kummerow (Gerrit)
11:32 AM (10 hours ago) 11:32 AM
to Clemens Backes, Jakob Kummerow, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com
Attention needed from Clemens Backes
Jakob Kummerow voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Clemens Backes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Clemens Backes (Gerrit)
11:41 AM (10 hours ago) 11:41 AM
to Jakob Kummerow, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com
Clemens Backes voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
11:43 AM (10 hours ago) 11:43 AM
to Clemens Backes, Jakob Kummerow, v8-re...@googlegroups.com
v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[base] Include operand values in CHECK failures for logging builds
Enable detailed error messages in CHECK_OP (CHECK_EQ, etc.) even for
non-DEBUG builds, as long as V8_LOGGING_LEVEL is greater than 1.
Previously, detailed information about failed operands (e.g.,
"(1 vs 2)") was only available in DEBUG builds. This change ensures
that release builds with v8_logging_level=2 provide the same level of
detail for check failures, aiding in diagnosing issues in such builds.
This is a follow-up to https://crrev.com/c/7705483.
TAG=agy
R=jkum...@chromium.org
Bug: 529423516
Change-Id: I3c3c45e9e231e888a29784d495003a5e9a220769
Commit-Queue: Clemens Backes <clem...@chromium.org>
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#108375}
Files:
- M src/base/logging.h
Change size: S
Delta: 1 file changed, 20 insertions(+), 18 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jakob Kummerow
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages