[numfuzz] Fix passing multiple extra flags [v8/v8 : main]
0 views
Skip to first unread message
Michael Achenbach (Gerrit)
3:27 AM (20 hours ago) 3:27 AM
to Matthias Liedtke, Raphael Herouart, v8-re...@googlegroups.com
Attention needed from Matthias Liedtke and Raphael Herouart
Michael Achenbach voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Achenbach
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Matthias Liedtke
- Raphael Herouart
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Achenbach (Gerrit)
3:40 AM (20 hours ago) 3:40 AM
to V8 LUCI CQ, Matthias Liedtke, Raphael Herouart, v8-re...@googlegroups.com
Attention needed from Matthias Liedtke and Raphael Herouart
Michael Achenbach added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Michael Achenbach . resolved
Actually lemme make the old version work, since Clusterfuzz and diff fuzz both support space separated flags. Let's keep them aligned... Just a moment.
Related details
Attention is currently required from:
- Matthias Liedtke
- Raphael Herouart
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Achenbach (Gerrit)
3:44 AM (20 hours ago) 3:44 AM
to V8 LUCI CQ, Matthias Liedtke, Raphael Herouart, v8-re...@googlegroups.com
Attention needed from Matthias Liedtke and Raphael Herouart
Michael Achenbach added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Michael Achenbach . resolved
Actually lemme make the old version work, since Clusterfuzz and diff fuzz both support space separated flags. Let's keep them aligned... Just a moment.
Michael Achenbach
OK, PTAL now. Though, tuple separation might be slightly nicer than space separation, I think it's more important to keep the 3 flag configs aligned. And the Clusterfuzz version would be hard to change.
Related details
Attention is currently required from:
- Matthias Liedtke
- Raphael Herouart
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matthias Liedtke (Gerrit)
4:08 AM (20 hours ago) 4:08 AM
to Michael Achenbach, V8 LUCI CQ, Raphael Herouart, v8-re...@googlegroups.com
Attention needed from Michael Achenbach and Raphael Herouart
Matthias Liedtke voted and added 1 comment![]( "Open in Gerrit")
Votes added by Matthias Liedtke
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Matthias Liedtke . resolved
LGTM, thanks a lot and sorry for breaking stuff. 😎
Related details
Attention is currently required from:
- Michael Achenbach
- Raphael Herouart
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matthias Liedtke (Gerrit)
4:09 AM (19 hours ago) 4:09 AM
to Michael Achenbach, V8 LUCI CQ, Raphael Herouart, v8-re...@googlegroups.com
Attention needed from Michael Achenbach and Raphael Herouart
Matthias Liedtke added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Michael Achenbach . resolved
Michael AchenbachActually lemme make the old version work, since Clusterfuzz and diff fuzz both support space separated flags. Let's keep them aligned... Just a moment.
OK, PTAL now. Though, tuple separation might be slightly nicer than space separation, I think it's more important to keep the 3 flag configs aligned. And the Clusterfuzz version would be hard to change.
Matthias Liedtke
Yeah, this is much more intuitive imo. 😊
Related details
Attention is currently required from:
- Michael Achenbach
- Raphael Herouart
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Achenbach (Gerrit)
4:24 AM (19 hours ago) 4:24 AM
to Matthias Liedtke, V8 LUCI CQ, Raphael Herouart, v8-re...@googlegroups.com
Attention needed from Raphael Herouart
Michael Achenbach voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Raphael Herouart
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Raphael Herouart (Gerrit)
4:28 AM (19 hours ago) 4:28 AM
to Michael Achenbach, Matthias Liedtke, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Michael Achenbach
Raphael Herouart voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Michael Achenbach
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
4:53 AM (19 hours ago) 4:53 AM
to Michael Achenbach, Raphael Herouart, Matthias Liedtke, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[numfuzz] Fix passing multiple extra flags
Bug: 474480381
Change-Id: If260bbba51b9bb808393ef7237faa6c9936c1aa6
Cq-Include-Trybots: luci.v8.try:v8_numfuzz_dbg,v8_numfuzz_tsan_rel
Reviewed-by: Raphael Herouart <rher...@chromium.org>
Commit-Queue: Michael Achenbach <mache...@chromium.org>
Reviewed-by: Matthias Liedtke <mlie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104587}
Files:
- M tools/testrunner/testproc/fuzzer.py
- M tools/testrunner/testproc/fuzzer_test.py
Change size: S
Delta: 2 files changed, 23 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Raphael Herouart, +1 by Matthias Liedtke
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages