[maglev] Reduce Builtin::kReturnReceiver [v8/v8 : main]
0 views
Skip to first unread message
Marco Vitale (Gerrit)
Aug 14, 2026, 9:24:24 AM (yesterday) Aug 14
to Victor Gomes, chrom...@appspot.gserviceaccount.com, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes
Marco Vitale voted and added 1 comment![]( "Open in Gerrit")
Votes added by Marco Vitale
| Auto-Submit | +1 |
1 comment
File src/maglev/maglev-graph-builder.h
Line 879, Patchset 2:
V(ReturnReceiver) \Victor Gomes . resolved
Marco VitalePut in on maglev-reducer instead.
Done ty!
Related details
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Gomes (Gerrit)
Aug 14, 2026, 9:26:45 AM (yesterday) Aug 14
to Marco Vitale, chrom...@appspot.gserviceaccount.com, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Marco Vitale
Victor Gomes voted and added 1 comment![]( "Open in Gerrit")
Votes added by Victor Gomes
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Marco Vitale
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Aug 14, 2026, 10:11:26 AM (yesterday) Aug 14
to Marco Vitale, Victor Gomes, chrom...@appspot.gserviceaccount.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[maglev] Reduce Builtin::kReturnReceiver
Iterator.prototype[Symbol.iterator] and related methods are implemented
via Builtin::kReturnReceiver, which returns 'this'.
Reducing this builtin in MaglevReducer allows InlinedAllocations
of iterators to remain virtual when passed to GetIterator or used in
for..of loops.
Bug: 42204525
Change-Id: Ie0afea6dfd7d56a1a0c440264743b32f58091125
Auto-Submit: Marco Vitale <mrc...@chromium.org>
Reviewed-by: Victor Gomes <victo...@chromium.org>
Commit-Queue: Victor Gomes <victo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#109259}
Files:
- M src/maglev/maglev-reducer-inl.h
- M src/maglev/maglev-reducer.h
Change size: XS
Delta: 2 files changed, 7 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Victor Gomes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages