[tracing] Fix source rundown chunking for non-ASCII scripts [v8/v8 : main]
0 views
Skip to first unread message
Camillo Bruni (Gerrit)
Jun 18, 2026, 4:45:15 AM (14 days ago) Jun 18
to Roman Dvornov, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Leszek Swirski, v8-re...@googlegroups.com
Attention needed from Leszek Swirski and Roman Dvornov
Camillo Bruni voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Leszek Swirski
- Roman Dvornov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
Jun 30, 2026, 12:03:15 PM (2 days ago) Jun 30
to Roman Dvornov, Camillo Bruni, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com
Attention needed from Roman Dvornov
Leszek Swirski voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Roman Dvornov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Roman Dvornov (Gerrit)
Jul 1, 2026, 11:43:55 AM (14 hours ago) Jul 1
to Camillo Bruni, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com
Roman Dvornov voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jul 1, 2026, 12:30:53 PM (14 hours ago) Jul 1
to Roman Dvornov, Leszek Swirski, Camillo Bruni, v8-re...@googlegroups.com
v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[tracing] Fix source rundown chunking for non-ASCII scripts
Large source rundown events split script sources using offsets based on
String::length(), but applied those offsets after converting the whole
source to a UTF-8 C string. For sources containing multi-byte UTF-8
characters, this could truncate or corrupt emitted LargeScriptCatchup
chunks.
Emit each chunk directly from the original V8 string range so chunk
boundaries remain consistent with the source length calculation.
Bug: 524406295
Change-Id: Ia1e61bc9b350657956f1622a3d9dc2dcd796c69a
Reviewed-by: Camillo Bruni <cbr...@chromium.org>
Reviewed-by: Leszek Swirski <les...@chromium.org>
Commit-Queue: Roman Dvornov <romand...@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#108376}
Files:
- M src/objects/script.cc
Change size: XS
Delta: 1 file changed, 3 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Leszek Swirski, +1 by Camillo Bruni
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages