Issue 14187 in v8: Implement the Promise.withResolvers proposal

[s… via monorail]

Status: Assigned
Owner: s...@chromium.org
Labels: Harmony
Components: Language
Type: FeatureRequest

New issue 14187 by s...@chromium.org: Implement the Promise.withResolvers proposal
https://bugs.chromium.org/p/v8/issues/detail?id=14187

The Promise.withResolvers proposal [1] reached Stage 3 at the July 2023 TC39.

[1] https://github.com/tc39/proposal-promise-with-resolvers

--
You received this message because:
1. The project was configured to send all issue notifications to this address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

[seo… via monorail]

Comment #1 on issue 14187 by seo...@chromium.org: Implement the Promise.withResolvers proposal
https://bugs.chromium.org/p/v8/issues/detail?id=14187#c1

Hi syg.
I'm looking forward to participate V8.
As my perspective, this seems like good first bug.. (If not, please notify me)

If you are okay, Can I try this issue?

[s… via monorail]

Comment #2 on issue 14187 by s...@chromium.org: Implement the Promise.withResolvers proposal
https://bugs.chromium.org/p/v8/issues/detail?id=14187#c2

Hi there, thank you for your interest. There is already a WIP CL awaiting review: https://chromium-review.googlesource.com/c/v8/v8/+/4684464

Is there another feature you'd be interested in? You can filter by the Harmony label.

[seo… via monorail]

Comment #3 on issue 14187 by seo...@chromium.org: Implement the Promise.withResolvers proposal
https://bugs.chromium.org/p/v8/issues/detail?id=14187#c3

Oh, I see. The wip is already existed!

Humm, Can I ask for your recommendation that maybe GoodFirstBug?

I saw some issues labeled in harmony like 14012, 12956, 13879 but seems a bit challenging.

[Git Watcher via monorail]

Comment #5 on issue 14187 by Git Watcher: Implement the Promise.withResolvers proposal
https://bugs.chromium.org/p/v8/issues/detail?id=14187#c5

The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/be69adb4c40310f975c3e598024ff4b34fac0f49

commit be69adb4c40310f975c3e598024ff4b34fac0f49
Author: Shu-yu Guo <s...@chromium.org>
Date: Mon Jul 24 23:24:01 2023

[promise-withresolvers] Implement Promise.withResolvers

This CL also switches to using a new --js prefix for feature flags,
effectively starting the sunsetting of --harmony.

Bug: v8:14187, v8:14214
Change-Id: Ie50c4e641272be3e9843bf90a01493c4911e6a4a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4684464
Reviewed-by: Adam Klein <ad...@chromium.org>
Reviewed-by: Rezvan Mahdavi Hezaveh <rez...@chromium.org>
Commit-Queue: Shu-yu Guo <s...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#89217}

[modify] https://crrev.com/be69adb4c40310f975c3e598024ff4b34fac0f49/src/codegen/code-stub-assembler.cc
[modify] https://crrev.com/be69adb4c40310f975c3e598024ff4b34fac0f49/src/flags/flag-definitions.h
[modify] https://crrev.com/be69adb4c40310f975c3e598024ff4b34fac0f49/src/objects/js-objects.h
[modify] https://crrev.com/be69adb4c40310f975c3e598024ff4b34fac0f49/src/init/heap-symbols.h
[modify] https://crrev.com/be69adb4c40310f975c3e598024ff4b34fac0f49/src/objects/contexts.h
[modify] https://crrev.com/be69adb4c40310f975c3e598024ff4b34fac0f49/src/init/bootstrapper.cc
[modify] https://crrev.com/be69adb4c40310f975c3e598024ff4b34fac0f49/BUILD.bazel
[add] https://crrev.com/be69adb4c40310f975c3e598024ff4b34fac0f49/src/builtins/promise-withresolvers.tq
[modify] https://crrev.com/be69adb4c40310f975c3e598024ff4b34fac0f49/src/codegen/code-stub-assembler.h
[modify] https://crrev.com/be69adb4c40310f975c3e598024ff4b34fac0f49/BUILD.gn
[modify] https://crrev.com/be69adb4c40310f975c3e598024ff4b34fac0f49/src/objects/promise.tq
[modify] https://crrev.com/be69adb4c40310f975c3e598024ff4b34fac0f49/src/roots/static-roots.h
[add] https://crrev.com/be69adb4c40310f975c3e598024ff4b34fac0f49/test/mjsunit/harmony/promise-withresolvers.js

[s… via monorail]

Comment #6 on issue 14187 by s...@chromium.org: Implement the Promise.withResolvers proposal
https://bugs.chromium.org/p/v8/issues/detail?id=14187#c6

> Maybe..... 13321?

rez...@chromium.org is currently working on Array.fromAsync.

The next smallest proposal (in terms of implementation effort) that's unstaffed is probably https://bugs.chromium.org/p/v8/issues/detail?id=14012, for Float16Array. Are you interested in that? That requires understanding object representation, specifically elements.

[seo… via monorail]

Comment #7 on issue 14187 by seo...@chromium.org: Implement the Promise.withResolvers proposal
https://bugs.chromium.org/p/v8/issues/detail?id=14187#c7

Sure!
Maybe I should need some time to understand what you've mentioned.

[Git Watcher via monorail]

Comment #8 on issue 14187 by Git Watcher: Implement the Promise.withResolvers proposal
https://bugs.chromium.org/p/v8/issues/detail?id=14187#c8

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8/+/4a34f6ba3243d4db494beec656719c55beb61023

commit 4a34f6ba3243d4db494beec656719c55beb61023
Author: Shu-yu Guo <s...@chromium.org>
Date: Fri Jul 28 20:40:10 2023

[promise-withresolvers] Stage the feature

This CL also has a drive-by fix for a typo in the JAVASCRIPT_STAGED
macro in bootstrapper.

Bug: v8:14187
Change-Id: I9089d82396fc2541ed2170e3210eecfba7609593
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4727845

Reviewed-by: Rezvan Mahdavi Hezaveh <rez...@chromium.org>
Commit-Queue: Shu-yu Guo <s...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#89354}

[modify] https://crrev.com/4a34f6ba3243d4db494beec656719c55beb61023/src/flags/flag-definitions.h
[modify] https://crrev.com/4a34f6ba3243d4db494beec656719c55beb61023/src/init/bootstrapper.cc

[Git Watcher via monorail]

Comment #9 on issue 14187 by Git Watcher: Implement the Promise.withResolvers proposal
https://bugs.chromium.org/p/v8/issues/detail?id=14187#c9

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/75a1e35aaf15a68c8f65b3f509c55d18d07816d1

commit 75a1e35aaf15a68c8f65b3f509c55d18d07816d1
Author: Shu-yu Guo <s...@chromium.org>
Date: Fri Sep 15 01:04:51 2023

[gin] Add flag for Promise.withResolvers

Bug: v8:14187
Change-Id: Ib9463745605b9bdae393c0da6279d4e3e9e84330
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4867595
Commit-Queue: Adam Klein <ad...@chromium.org>
Reviewed-by: Adam Klein <ad...@chromium.org>
Auto-Submit: Shu-yu Guo <s...@chromium.org>
Commit-Queue: Shu-yu Guo <s...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1196926}

[modify] https://crrev.com/75a1e35aaf15a68c8f65b3f509c55d18d07816d1/gin/gin_features.h
[modify] https://crrev.com/75a1e35aaf15a68c8f65b3f509c55d18d07816d1/gin/v8_initializer.cc
[modify] https://crrev.com/75a1e35aaf15a68c8f65b3f509c55d18d07816d1/gin/gin_features.cc

[Git Watcher via monorail]

Comment #10 on issue 14187 by Git Watcher: Implement the Promise.withResolvers proposal
https://bugs.chromium.org/p/v8/issues/detail?id=14187#c10

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8/+/71494b43e7359807e914612238b879fde6dbdf9d

commit 71494b43e7359807e914612238b879fde6dbdf9d
Author: Shu-yu Guo <s...@chromium.org>
Date: Mon Sep 18 17:25:46 2023

[promise-withresolvers] Ship the proposal

I2S with 3 LGTMs:
https://groups.google.com/a/chromium.org/g/blink-dev/c/JL4uXtfrCdU/m/EpszDkvKAAAJ

Bug: v8:14187
Change-Id: Id96edadde1c258f35647c1a91a1baeab8bd36442
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4873333
Commit-Queue: Adam Klein <ad...@chromium.org>
Auto-Submit: Shu-yu Guo <s...@chromium.org>
Reviewed-by: Adam Klein <ad...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#90035}

[modify] https://crrev.com/71494b43e7359807e914612238b879fde6dbdf9d/src/flags/flag-definitions.h

[s… via monorail]

Updates:
Status: Fixed

Comment #11 on issue 14187 by s...@chromium.org: Implement the Promise.withResolvers proposal
https://bugs.chromium.org/p/v8/issues/detail?id=14187#c11

(No comment was entered for this change.)