[turboshaft] Embed AssemblerOpInterface into reducer stack [v8/v8 : main]
0 views
Skip to first unread message
Nico Hartmann (Gerrit)
Nov 18, 2025, 9:22:08 AM (23 hours ago) Nov 18
to Darius Mercadier, Matthias Liedtke, Hannes Payer, V8 LUCI CQ, AyeAye, mlippau...@chromium.org, was...@google.com, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Darius Mercadier and Matthias Liedtke
Nico Hartmann added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File src/codegen/turboshaft-builtins-assembler-inl.h
Line 618, Patchset 2:
V<String> ToStringImpl(V<Context> context, V<JSAny> o) {Nico Hartmann . unresolved
TODO: Remove before landing.
Related details
Attention is currently required from:
- Darius Mercadier
- Matthias Liedtke
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darius Mercadier (Gerrit)
Nov 18, 2025, 9:47:32 AM (23 hours ago) Nov 18
to Nico Hartmann, Matthias Liedtke, Hannes Payer, V8 LUCI CQ, AyeAye, mlippau...@chromium.org, was...@google.com, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Matthias Liedtke and Nico Hartmann
Darius Mercadier voted and added 2 comments![]( "Open in Gerrit")
Votes added by Darius Mercadier
| Code-Review | +1 |
2 comments
Patchset-level comments
Darius Mercadier . resolved
LGTM, thanks for the cleanup :)
File src/compiler/turboshaft/assembler.h
Line 1147, Patchset 5 (Latest):
return this->Asm().template Emit<Name##Op>(detail::MakeShadowy(args)...); \Darius Mercadier . unresolved
Just `Emit` I guess now that it's in the same class.
Related details
Attention is currently required from:
- Matthias Liedtke
- Nico Hartmann
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Hartmann (Gerrit)
Nov 18, 2025, 10:14:13 AM (22 hours ago) Nov 18
to Darius Mercadier, Matthias Liedtke, Hannes Payer, V8 LUCI CQ, AyeAye, mlippau...@chromium.org, was...@google.com, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Matthias Liedtke
Nico Hartmann added 2 comments![]( "Open in Gerrit")
File src/codegen/turboshaft-builtins-assembler-inl.h
Line 618, Patchset 2:
V<String> ToStringImpl(V<Context> context, V<JSAny> o) {Nico Hartmann . resolved
Nico HartmannTODO: Remove before landing.
Done
File src/compiler/turboshaft/assembler.h
Line 1147, Patchset 5:
return this->Asm().template Emit<Name##Op>(detail::MakeShadowy(args)...); \Darius Mercadier . resolved
Just `Emit` I guess now that it's in the same class.
Nico Hartmann
Done
Related details
Attention is currently required from:
- Matthias Liedtke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Hartmann (Gerrit)
Nov 18, 2025, 10:14:47 AM (22 hours ago) Nov 18
to Leszek Swirski, Darius Mercadier, Matthias Liedtke, Hannes Payer, V8 LUCI CQ, AyeAye, mlippau...@chromium.org, was...@google.com, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Leszek Swirski and Matthias Liedtke
Nico Hartmann voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nico Hartmann
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 6 (Latest):
Nico Hartmann . resolved
@Leszek for src/heap and src/interpreter, thanks
Related details
Attention is currently required from:
- Leszek Swirski
- Matthias Liedtke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
5:45 AM (3 hours ago) 5:45 AM
to Nico Hartmann, Darius Mercadier, Matthias Liedtke, Hannes Payer, V8 LUCI CQ, AyeAye, mlippau...@chromium.org, was...@google.com, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Matthias Liedtke and Nico Hartmann
Leszek Swirski voted and added 1 comment![]( "Open in Gerrit")
Votes added by Leszek Swirski
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Matthias Liedtke
- Nico Hartmann
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Hartmann (Gerrit)
5:56 AM (3 hours ago) 5:56 AM
to Leszek Swirski, Darius Mercadier, Matthias Liedtke, Hannes Payer, V8 LUCI CQ, AyeAye, mlippau...@chromium.org, was...@google.com, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Matthias Liedtke
Nico Hartmann voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Matthias Liedtke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
5:59 AM (3 hours ago) 5:59 AM
to Nico Hartmann, Leszek Swirski, Darius Mercadier, Matthias Liedtke, Hannes Payer, AyeAye, mlippau...@chromium.org, was...@google.com, dmercadi...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[turboshaft] Embed AssemblerOpInterface into reducer stack
The Assembler no longer inherits directly from both, the ReducerStack
and the AssemblerOpInterface, but the latter is part of the former's
class hierarchy. This allows reducers to overwrite assembler functions
(e.g. builtin reducers can provide a CallBuiltin that doesn't require
a FrameState argument).
Furthermore: Remove the additional layer of TS-abstraction in the
Assembler setup that we introduced when we tried to make the
Turboshaft architecture IR independent.
NO_IFTTT=Only changed class name inside a comment.
Bug: 348031042
Change-Id: If8b9b27a9655102b7c85353a8511482297c7c451
Reviewed-by: Leszek Swirski <les...@chromium.org>
Reviewed-by: Darius Mercadier <dmerc...@chromium.org>
Commit-Queue: Nico Hartmann <nicoha...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103808}
Files:
- M src/base/template-meta-programming/list.h
- M src/codegen/turboshaft-builtins-assembler-inl.h
- M src/compiler/turboshaft/assembler.h
- M src/compiler/turboshaft/copying-phase.h
- M src/compiler/turboshaft/graph-builder.cc
- M src/compiler/turboshaft/graph.h
- M src/compiler/turboshaft/reducer-traits.h
- M src/compiler/turboshaft/runtime-call-descriptors.h
- M src/compiler/turboshaft/turbolev-graph-builder.cc
- M src/compiler/turboshaft/wasm-in-js-inlining-reducer-inl.h
- M src/heap/memory-chunk.h
- M src/interpreter/interpreter-generator-tsa.cc
- M src/wasm/turboshaft-graph-interface.cc
- M src/wasm/wrappers.cc
- M test/cctest/compiler/turboshaft-codegen-tester.h
- M test/unittests/compiler/backend/turboshaft-instruction-selector-unittest.h
- M test/unittests/compiler/turboshaft/loop-unrolling-analyzer-unittest.cc
- M test/unittests/compiler/turboshaft/reducer-test.h
Change size: L
Delta: 18 files changed, 436 insertions(+), 392 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Leszek Swirski, +1 by Darius Mercadier
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages