Sparkplug+: add typed code stubs for Equal and Relational Compare [v8/v8 : main]

[Wei, Yuheng (Gerrit)]

Attention needed from Leszek Swirski and Toon Verwaest

Wei, Yuheng added 1 comment

Patchset-level comments

File-level comment, Patchset 9 (Latest):

Wei, Yuheng . resolved

Hi Leszek/Toon, this patch is ready for review, PTAL!

Open in Gerrit

Related details

Attention is currently required from:

• Leszek Swirski
• Toon Verwaest

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: If1a22da769cfafef8910c7fd0771dbe1654bbf80

Gerrit-Change-Number: 7608978

Gerrit-PatchSet: 9

Gerrit-Owner: Wei, Yuheng <yuhen...@intel.com>

Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>

Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>

Gerrit-Reviewer: Wei, Yuheng <yuhen...@intel.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Xu, Hao A <hao....@intel.com>

Gerrit-CC: chrom...@appspot.gserviceaccount.com <chrom...@appspot.gserviceaccount.com>

Gerrit-Attention: Toon Verwaest <verw...@chromium.org>

Gerrit-Attention: Leszek Swirski <les...@chromium.org>

Gerrit-Comment-Date: Tue, 03 Mar 2026 08:50:41 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Wei, Yuheng (Gerrit)]

Attention needed from Leszek Swirski and Toon Verwaest

Wei, Yuheng added 1 comment

Patchset-level comments

File-level comment, Patchset 9 (Latest):

Wei, Yuheng . resolved

friendly ping :)

Gerrit-Comment-Date: Wed, 11 Mar 2026 02:07:55 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Toon Verwaest (Gerrit)]

Attention needed from Leszek Swirski and Wei, Yuheng

Toon Verwaest added 3 comments

File src/baseline/baseline-compiler.cc

Line 1732, Patchset 9 (Latest):#ifdef V8_ENABLE_SPARKPLUG_PLUS

Toon Verwaest . unresolved

This code seems like a duplicate from the blobs below. Can't we share this better to avoid duplication?

File src/common/globals.h

Line 2694, Patchset 9 (Latest):#define REATIONAL_COMPARISON_STUB_LIST(V)

Toon Verwaest . unresolved

should this have been TYPED_RELATIONAL_COMPARE_STUB_LIST?

File src/runtime/runtime-compiler.cc

Line 812, Patchset 9 (Parent): if (!isolate->is_short_builtin_calls_enabled()) return *compare_result;

Toon Verwaest . unresolved

Isn't this still needed?

Open in Gerrit

Related details

Attention is currently required from:

• Leszek Swirski
• Wei, Yuheng

Submit Requirements:

• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: If1a22da769cfafef8910c7fd0771dbe1654bbf80

Gerrit-Change-Number: 7608978

Gerrit-PatchSet: 9

Gerrit-Owner: Wei, Yuheng <yuhen...@intel.com>

Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>

Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>

Gerrit-Reviewer: Wei, Yuheng <yuhen...@intel.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Xu, Hao A <hao....@intel.com>

Gerrit-CC: chrom...@appspot.gserviceaccount.com <chrom...@appspot.gserviceaccount.com>

Gerrit-Attention: Wei, Yuheng <yuhen...@intel.com>

Gerrit-Attention: Leszek Swirski <les...@chromium.org>

Gerrit-Comment-Date: Mon, 16 Mar 2026 15:59:49 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No