[maglev] Don't emit conversion nodes from Uint32Constant to Float64Constant [v8/v8 : main]

0 views

Skip to first unread message

Victor Gomes (Gerrit)

unread,

7:08 AM (2 hours ago) 7:08 AM

to Marja Hölttä, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org

Attention needed from Marja Hölttä

Victor Gomes voted and added 1 comment

Votes added by Victor Gomes

Auto-Submit	+1
Commit-Queue	+1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Victor Gomes . resolved

PTAL!

Open in Gerrit

Related details

Attention is currently required from:

Marja Hölttä

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Marja Hölttä (Gerrit)

unread,

7:09 AM (2 hours ago) 7:09 AM

to Victor Gomes, V8 LUCI CQ, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org

Attention needed from Victor Gomes

Marja Hölttä voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Victor Gomes

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

V8 LUCI CQ (Gerrit)

unread,

7:47 AM (1 hour ago) 7:47 AM

to Victor Gomes, Marja Hölttä, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org

V8 LUCI CQ submitted the change

Change information

Commit message:

[maglev] Don't emit conversion nodes from Uint32Constant to Float64Constant

... instead just create a new constant node.

Change-Id: I80e637c479039a97ce5768b6320a090e58f5f5eb

Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7601256

Reviewed-by: Marja Hölttä <ma...@chromium.org>

Commit-Queue: Marja Hölttä <ma...@chromium.org>

Commit-Queue: Victor Gomes <victo...@chromium.org>

Auto-Submit: Victor Gomes <victo...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#105412}

Files:

M src/maglev/maglev-reducer-inl.h

Change size: XS

Delta: 1 file changed, 3 insertions(+), 0 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Marja Hölttä

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages