[heap] Make TaskOnContextDispose a user visible task [v8/v8 : main]

0 views
Skip to first unread message

Etienne Pierre-Doray (Gerrit)

unread,
Oct 22, 2025, 4:07:47 PM (19 hours ago) Oct 22
to Michael Lippautz, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz

Etienne Pierre-Doray voted and added 1 comment

Votes added by Etienne Pierre-Doray

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Etienne Pierre-Doray . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Lippautz
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I887de78993fb6da524fcaa5d57372f22402fb638
Gerrit-Change-Number: 7076131
Gerrit-PatchSet: 7
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>
Gerrit-Comment-Date: Wed, 22 Oct 2025 20:07:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Michael Lippautz (Gerrit)

unread,
3:06 AM (8 hours ago) 3:06 AM
to Etienne Pierre-Doray, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Etienne Pierre-Doray

Michael Lippautz added 2 comments

File src/heap/heap.cc
Line 1834, Patchset 7 (Latest): const base::TimeDelta idle_time = base::TimeDelta::FromMillisecondsD(16);
Michael Lippautz . unresolved

Who guarantees that we actually have 16ms idle time?

I understand that idle tasks are not reliable but we also shouldn't create jank by just assuming that there's idle time in general.

Maybe the change around time (see below) is enough to make it trigger more reliably?

Line 1841, Patchset 7 (Parent): const bool time_to_run_exceeded = time_to_run > kMaxTimeToRun;
Michael Lippautz . unresolved

The mechanism is conservative and doesn't want this task to be run too far away from where the context disposal. We want the GC because the assumption is that lots of memory is dead, this only holds for the first GC after the disposal and not for any random time.

Given that the task is low priority, it's probably enough to just snapshot the GC count and make sure that no GC happened in between. This would allow the task to happen much later.

Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: I887de78993fb6da524fcaa5d57372f22402fb638
    Gerrit-Change-Number: 7076131
    Gerrit-PatchSet: 7
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
    Gerrit-CC: Hannes Payer <hpa...@chromium.org>
    Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Comment-Date: Thu, 23 Oct 2025 07:06:52 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    open
    diffy

    Michael Lippautz (Gerrit)

    unread,
    4:16 AM (7 hours ago) 4:16 AM
    to Etienne Pierre-Doray, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
    Attention needed from Etienne Pierre-Doray

    Michael Lippautz added 1 comment

    File src/heap/heap.cc
    Line 1834, Patchset 7 (Latest): const base::TimeDelta idle_time = base::TimeDelta::FromMillisecondsD(16);
    Michael Lippautz . unresolved

    Thinking a bit more about this: The scheduler should know how much time we have left in the frame? Can we make this queryable or pass it along somehow?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Etienne Pierre-Doray
    Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: I887de78993fb6da524fcaa5d57372f22402fb638
    Gerrit-Change-Number: 7076131
    Gerrit-PatchSet: 7
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
    Gerrit-CC: Hannes Payer <hpa...@chromium.org>
    Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Comment-Date: Thu, 23 Oct 2025 08:16:06 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    open
    diffy

    chromeperf@appspot.gserviceaccount.com (Gerrit)

    unread,
    5:10 AM (6 hours ago) 5:10 AM
    to Etienne Pierre-Doray, Michael Lippautz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
    Attention needed from Etienne Pierre-Doray

    Message from chrom...@appspot.gserviceaccount.com

    📍 Job android-pixel9-pro-perf/speedometer3 complete.

    See results at: https://pinpoint-dot-chromeperf.appspot.com/job/12e19354d10000

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Etienne Pierre-Doray
    Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: I887de78993fb6da524fcaa5d57372f22402fb638
    Gerrit-Change-Number: 7076131
    Gerrit-PatchSet: 7
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
    Gerrit-CC: Hannes Payer <hpa...@chromium.org>
    Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Comment-Date: Thu, 23 Oct 2025 09:10:42 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages