[api] suppress incompatible function type cast warning [v8/v8 : main]

0 views
Skip to first unread message

Chengzhong Wu (Gerrit)

unread,
Oct 22, 2025, 10:10:55 AM (yesterday) Oct 22
to Leszek Swirski, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Leszek Swirski

Chengzhong Wu voted and added 1 comment

Votes added by Chengzhong Wu

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Chengzhong Wu . resolved

Hi Leszek, would you mind taking a look at this change? This could suppress a warning when building V8 in Node.js. Thank you!

Open in Gerrit

Related details

Attention is currently required from:
  • Leszek Swirski
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: If88d18811cb4c1a8a196a0aef4b86c6124816188
Gerrit-Change-Number: 7069254
Gerrit-PatchSet: 3
Gerrit-Owner: Chengzhong Wu <cwu...@bloomberg.net>
Gerrit-Reviewer: Chengzhong Wu <cwu...@bloomberg.net>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Attention: Leszek Swirski <les...@chromium.org>
Gerrit-Comment-Date: Wed, 22 Oct 2025 14:10:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Leszek Swirski (Gerrit)

unread,
Oct 22, 2025, 10:34:38 AM (yesterday) Oct 22
to Chengzhong Wu, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Chengzhong Wu

Leszek Swirski added 1 comment

File src/api/api.cc
Line 1329, Patchset 3 (Latest):#pragma clang diagnostic push
Leszek Swirski . unresolved

why not `gcc diagnostic push` for clang as well? I believe it supports it.

Open in Gerrit

Related details

Attention is currently required from:
  • Chengzhong Wu
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: If88d18811cb4c1a8a196a0aef4b86c6124816188
    Gerrit-Change-Number: 7069254
    Gerrit-PatchSet: 3
    Gerrit-Owner: Chengzhong Wu <cwu...@bloomberg.net>
    Gerrit-Reviewer: Chengzhong Wu <cwu...@bloomberg.net>
    Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
    Gerrit-Attention: Chengzhong Wu <cwu...@bloomberg.net>
    Gerrit-Comment-Date: Wed, 22 Oct 2025 14:34:33 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    open
    diffy

    Chengzhong Wu (Gerrit)

    unread,
    Oct 22, 2025, 11:26:53 AM (yesterday) Oct 22
    to AyeAye, Leszek Swirski, V8 LUCI CQ, cbruni...@chromium.org, v8-re...@googlegroups.com
    Attention needed from Leszek Swirski

    Chengzhong Wu voted and added 1 comment

    Votes added by Chengzhong Wu

    Commit-Queue+1

    1 comment

    File src/api/api.cc
    Line 1329, Patchset 3:#pragma clang diagnostic push
    Leszek Swirski . unresolved

    why not `gcc diagnostic push` for clang as well? I believe it supports it.

    Chengzhong Wu

    Thanks for the suggestion. Had a try and it does work. I also updated the occurrence in `include/v8-persistent-handle.h`.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Leszek Swirski
    Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: If88d18811cb4c1a8a196a0aef4b86c6124816188
    Gerrit-Change-Number: 7069254
    Gerrit-PatchSet: 4
    Gerrit-Owner: Chengzhong Wu <cwu...@bloomberg.net>
    Gerrit-Reviewer: Chengzhong Wu <cwu...@bloomberg.net>
    Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
    Gerrit-Attention: Leszek Swirski <les...@chromium.org>
    Gerrit-Comment-Date: Wed, 22 Oct 2025 15:26:50 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Leszek Swirski <les...@chromium.org>
    unsatisfied_requirement
    open
    diffy

    Chengzhong Wu (Gerrit)

    unread,
    Oct 22, 2025, 11:27:04 AM (yesterday) Oct 22
    to AyeAye, Leszek Swirski, V8 LUCI CQ, cbruni...@chromium.org, v8-re...@googlegroups.com
    Attention needed from Leszek Swirski

    Chengzhong Wu added 1 comment

    File src/api/api.cc
    Line 1329, Patchset 3:#pragma clang diagnostic push
    Leszek Swirski . resolved

    why not `gcc diagnostic push` for clang as well? I believe it supports it.

    Chengzhong Wu

    Thanks for the suggestion. Had a try and it does work. I also updated the occurrence in `include/v8-persistent-handle.h`.

    Chengzhong Wu

    Marked as resolved.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Leszek Swirski
    Submit Requirements:
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: v8/v8
      Gerrit-Branch: main
      Gerrit-Change-Id: If88d18811cb4c1a8a196a0aef4b86c6124816188
      Gerrit-Change-Number: 7069254
      Gerrit-PatchSet: 4
      Gerrit-Owner: Chengzhong Wu <cwu...@bloomberg.net>
      Gerrit-Reviewer: Chengzhong Wu <cwu...@bloomberg.net>
      Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
      Gerrit-Attention: Leszek Swirski <les...@chromium.org>
      Gerrit-Comment-Date: Wed, 22 Oct 2025 15:27:02 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Chengzhong Wu <cwu...@bloomberg.net>
      Comment-In-Reply-To: Leszek Swirski <les...@chromium.org>
      unsatisfied_requirement
      open
      diffy

      Leszek Swirski (Gerrit)

      unread,
      6:58 AM (5 hours ago) 6:58 AM
      to Chengzhong Wu, AyeAye, V8 LUCI CQ, cbruni...@chromium.org, v8-re...@googlegroups.com
      Attention needed from Chengzhong Wu

      Leszek Swirski voted and added 1 comment

      Votes added by Leszek Swirski

      Code-Review+1

      1 comment

      File src/api/api.cc
      Line 1324, Patchset 4 (Latest):#if (__GNUC__ >= 8) || __clang__
      Leszek Swirski . unresolved

      please still check for `defined(__clang__)`

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Chengzhong Wu
      Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: v8/v8
      Gerrit-Branch: main
      Gerrit-Change-Id: If88d18811cb4c1a8a196a0aef4b86c6124816188
      Gerrit-Change-Number: 7069254
      Gerrit-PatchSet: 4
      Gerrit-Owner: Chengzhong Wu <cwu...@bloomberg.net>
      Gerrit-Reviewer: Chengzhong Wu <cwu...@bloomberg.net>
      Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
      Gerrit-Attention: Chengzhong Wu <cwu...@bloomberg.net>
      Gerrit-Comment-Date: Thu, 23 Oct 2025 10:58:10 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Chengzhong Wu (Gerrit)

      unread,
      9:20 AM (2 hours ago) 9:20 AM
      to Leszek Swirski, AyeAye, V8 LUCI CQ, cbruni...@chromium.org, v8-re...@googlegroups.com

      Chengzhong Wu voted and added 1 comment

      Votes added by Chengzhong Wu

      Commit-Queue+1

      1 comment

      File src/api/api.cc
      Line 1324, Patchset 4:#if (__GNUC__ >= 8) || __clang__
      Leszek Swirski . resolved

      please still check for `defined(__clang__)`

      Chengzhong Wu

      Updated! thanks for suggestion

      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: v8/v8
        Gerrit-Branch: main
        Gerrit-Change-Id: If88d18811cb4c1a8a196a0aef4b86c6124816188
        Gerrit-Change-Number: 7069254
        Gerrit-PatchSet: 5
        Gerrit-Owner: Chengzhong Wu <cwu...@bloomberg.net>
        Gerrit-Reviewer: Chengzhong Wu <cwu...@bloomberg.net>
        Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
        Gerrit-Comment-Date: Thu, 23 Oct 2025 13:20:40 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        Comment-In-Reply-To: Leszek Swirski <les...@chromium.org>
        satisfied_requirement
        open
        diffy

        Chengzhong Wu (Gerrit)

        unread,
        10:40 AM (1 hour ago) 10:40 AM
        to Leszek Swirski, AyeAye, V8 LUCI CQ, cbruni...@chromium.org, v8-re...@googlegroups.com

        Chengzhong Wu voted Commit-Queue+2

        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: v8/v8
        Gerrit-Branch: main
        Gerrit-Change-Id: If88d18811cb4c1a8a196a0aef4b86c6124816188
        Gerrit-Change-Number: 7069254
        Gerrit-PatchSet: 5
        Gerrit-Owner: Chengzhong Wu <cwu...@bloomberg.net>
        Gerrit-Reviewer: Chengzhong Wu <cwu...@bloomberg.net>
        Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
        Gerrit-Comment-Date: Thu, 23 Oct 2025 14:40:32 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        V8 LUCI CQ (Gerrit)

        unread,
        10:42 AM (1 hour ago) 10:42 AM
        to Chengzhong Wu, Leszek Swirski, AyeAye, cbruni...@chromium.org, v8-re...@googlegroups.com

        V8 LUCI CQ submitted the change with unreviewed changes

        Unreviewed changes

        4 is the latest approved patch-set.
        The change was submitted with unreviewed changes in the following files:

        ```
        The name of the file: src/api/api.cc
        Insertions: 2, Deletions: 2.

        @@ -1321,7 +1321,7 @@
        obj->set_getter(i_isolate, reinterpret_cast<i::Address>(getter));
        DCHECK_IMPLIES(replace_on_access, setter == nullptr);
        if (setter == nullptr) {
        -#if (__GNUC__ >= 8) || __clang__
        +#if (__GNUC__ >= 8) || defined(__clang__)
        #pragma GCC diagnostic push
        #pragma GCC diagnostic ignored "-Wcast-function-type"
        #endif
        @@ -1330,7 +1330,7 @@
        // (*)(v8::Local<v8::Name>, v8::Local<v8::Value>, const
        // v8::PropertyCallbackInfo<void> &)'.
        setter = reinterpret_cast<Setter>(&i::Accessors::ReconfigureToDataProperty);
        -#if (__GNUC__ >= 8) || __clang__
        +#if (__GNUC__ >= 8) || defined(__clang__)
        #pragma GCC diagnostic pop
        #endif
        }
        ```
        ```
        The name of the file: include/v8-persistent-handle.h
        Insertions: 2, Deletions: 2.

        @@ -485,13 +485,13 @@
        P* parameter, typename WeakCallbackInfo<P>::Callback callback,
        WeakCallbackType type) {
        using Callback = WeakCallbackInfo<void>::Callback;
        -#if (__GNUC__ >= 8) || __clang__
        +#if (__GNUC__ >= 8) || defined(__clang__)
        #pragma GCC diagnostic push
        #pragma GCC diagnostic ignored "-Wcast-function-type"
        #endif
        api_internal::MakeWeak(this->slot(), parameter,
        reinterpret_cast<Callback>(callback), type);
        -#if (__GNUC__ >= 8) || __clang__
        +#if (__GNUC__ >= 8) || defined(__clang__)
        #pragma GCC diagnostic pop
        #endif
        }
        ```

        Change information

        Commit message:
        [api] suppress incompatible function type cast warning
        Change-Id: If88d18811cb4c1a8a196a0aef4b86c6124816188
        Commit-Queue: Chengzhong Wu <cwu...@bloomberg.net>
        Reviewed-by: Leszek Swirski <les...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#103317}
        Files:
        • M include/v8-persistent-handle.h
        • M src/api/api.cc
        Change size: S
        Delta: 2 files changed, 13 insertions(+), 9 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Leszek Swirski
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: v8/v8
        Gerrit-Branch: main
        Gerrit-Change-Id: If88d18811cb4c1a8a196a0aef4b86c6124816188
        Gerrit-Change-Number: 7069254
        Gerrit-PatchSet: 6
        Gerrit-Owner: Chengzhong Wu <cwu...@bloomberg.net>
        Gerrit-Reviewer: Chengzhong Wu <cwu...@bloomberg.net>
        Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages