Unreviewed changes
4 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: src/api/api.cc
Insertions: 2, Deletions: 2.
@@ -1321,7 +1321,7 @@
obj->set_getter(i_isolate, reinterpret_cast<i::Address>(getter));
DCHECK_IMPLIES(replace_on_access, setter == nullptr);
if (setter == nullptr) {
-#if (__GNUC__ >= 8) || __clang__
+#if (__GNUC__ >= 8) || defined(__clang__)
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wcast-function-type"
#endif
@@ -1330,7 +1330,7 @@
// (*)(v8::Local<v8::Name>, v8::Local<v8::Value>, const
// v8::PropertyCallbackInfo<void> &)'.
setter = reinterpret_cast<Setter>(&i::Accessors::ReconfigureToDataProperty);
-#if (__GNUC__ >= 8) || __clang__
+#if (__GNUC__ >= 8) || defined(__clang__)
#pragma GCC diagnostic pop
#endif
}
```
```
The name of the file: include/v8-persistent-handle.h
Insertions: 2, Deletions: 2.
@@ -485,13 +485,13 @@
P* parameter, typename WeakCallbackInfo<P>::Callback callback,
WeakCallbackType type) {
using Callback = WeakCallbackInfo<void>::Callback;
-#if (__GNUC__ >= 8) || __clang__
+#if (__GNUC__ >= 8) || defined(__clang__)
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wcast-function-type"
#endif
api_internal::MakeWeak(this->slot(), parameter,
reinterpret_cast<Callback>(callback), type);
-#if (__GNUC__ >= 8) || __clang__
+#if (__GNUC__ >= 8) || defined(__clang__)
#pragma GCC diagnostic pop
#endif
}
```
Change information
Commit message:
[api] suppress incompatible function type cast warning
Change-Id: If88d18811cb4c1a8a196a0aef4b86c6124816188
Cr-Commit-Position: refs/heads/main@{#103317}
Files:
- M include/v8-persistent-handle.h
- M src/api/api.cc
Change size: S
Delta: 2 files changed, 13 insertions(+), 9 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Leszek Swirski