[parser] Fix DCHECK in CheckFlagsForFunctionFromScript [v8/v8 : main]
0 views
Skip to first unread message
Leszek Swirski (Gerrit)
Jun 9, 2026, 10:27:54 AM (3 days ago) Jun 9
to Igor Sheludko, marja...@chromium.org, v8-re...@googlegroups.com
Attention needed from Igor Sheludko
Leszek Swirski voted and added 1 comment![]( "Open in Gerrit")
Votes added by Leszek Swirski
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Igor Sheludko
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Igor Sheludko (Gerrit)
Jun 9, 2026, 10:59:02 AM (3 days ago) Jun 9
to Leszek Swirski, v8-s...@luci-project-accounts.iam.gserviceaccount.com, marja...@chromium.org, v8-re...@googlegroups.com
Attention needed from Leszek Swirski
Igor Sheludko voted and added 1 comment![]( "Open in Gerrit")
Votes added by Igor Sheludko
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Attention is currently required from:
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jun 9, 2026, 12:02:21 PM (3 days ago) Jun 9
to Leszek Swirski, Igor Sheludko, marja...@chromium.org, v8-re...@googlegroups.com
v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[parser] Fix DCHECK in CheckFlagsForFunctionFromScript
is_eval is now only set for top-level eval compiles, but the DCHECK
in CheckFlagsForFunctionFromScript still expected it to be set for all
compiles from an eval script. Update the DCHECK to account for this.
cf. https://crrev.com/c/7679400/14/src/parsing/parse-info.cc
TAG=agy
CONV=fef5842b-4ba4-404e-b22c-01fb737213bc
Fixed: 521483370
Change-Id: I8c3d0e74972134a2c46dfc53a772bac4b1d21ddf
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Commit-Queue: Leszek Swirski <les...@chromium.org>
Auto-Submit: Leszek Swirski <les...@chromium.org>
Reviewed-by: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#107863}
Files:
- M src/parsing/parse-info.cc
- A test/mjsunit/regress/regress-crbug-521483370.js
Change size: S
Delta: 2 files changed, 15 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Igor Sheludko
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Achenbach (Gerrit)
Jun 10, 2026, 2:20:39 AM (2 days ago) Jun 10
to v8-s...@luci-project-accounts.iam.gserviceaccount.com, Igor Sheludko, marja...@chromium.org, v8-re...@googlegroups.com
Michael Achenbach has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages