[wasm][jspi] Avoid gaps in the central stack [v8/v8 : main]

0 views
Skip to first unread message

Thibaud Michaud (Gerrit)

unread,
Sep 4, 2025, 9:04:10 AM (3 days ago) Sep 4
to V8 LUCI CQ, v8-re...@googlegroups.com, was...@google.com

Thibaud Michaud added 1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Thibaud Michaud . resolved

PTAL. I'll add someone for src/execution owners approval, but I think you have more context to review it.
As discussed this morning, writing a test for this turned out to be difficult. You can see my latest attempt in PS 4, but it still fails for the wrong reasons on some bots (because of the nondeterminism of the max recursion depth) so I decided to remove it.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ie6b5750a90a67757772d7e4f21f411dafeff31b2
Gerrit-Change-Number: 6912743
Gerrit-PatchSet: 5
Gerrit-Owner: Thibaud Michaud <thib...@chromium.org>
Gerrit-Reviewer: Thibaud Michaud <thib...@chromium.org>
Gerrit-Comment-Date: Thu, 04 Sep 2025 13:04:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages