[regexp] Fix CheckPosition in peephole optimized bytecodes [v8/v8 : main]
0 views
Skip to first unread message
Patrick Thier (Gerrit)
Sep 4, 2025, 10:40:13 AM (3 days ago) Sep 4
to Jakob Linke, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Jakob Linke
Patrick Thier voted and added 1 comment![]( "Open in Gerrit")
Votes added by Patrick Thier
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Jakob Linke
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Linke (Gerrit)
Sep 5, 2025, 2:02:41 AM (2 days ago) Sep 5
to Patrick Thier, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Patrick Thier
Jakob Linke voted![]( "Open in Gerrit")
Attention is currently required from:
- Patrick Thier
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Sep 5, 2025, 2:04:04 AM (2 days ago) Sep 5
to Patrick Thier, Jakob Linke, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[regexp] Fix CheckPosition in peephole optimized bytecodes
In [1] CheckPosition was changed to mimic the behaviour of the macro
assembler.
This fix didn't include peephole optimized bytecodes that included
CheckPosition in the interpreter.
This is only a very minor performance fix (we can detect a no match 1
iteration earlier), but has no user observable effect (we didn't read
OOB or produced wrong results).
[1] https://crrev.com/c/6890831
Bug: 437003349
Change-Id: Idb84f811534648161be6379696567d4fffa8cda9
Auto-Submit: Patrick Thier <pth...@chromium.org>
Reviewed-by: Jakob Linke <jgr...@chromium.org>
Commit-Queue: Jakob Linke <jgr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#102259}
Files:
- M src/regexp/regexp-interpreter.cc
Change size: XS
Delta: 1 file changed, 2 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jakob Linke
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages