[wasm-custom-desc] Handle Wasm objects on more prototype chains [v8/v8 : main]

1 view
Skip to first unread message

Jakob Kummerow (Gerrit)

unread,
Oct 20, 2025, 8:37:42 AM (3 days ago) Oct 20
to Jakob Kummerow, Igor Sheludko, v8-re...@googlegroups.com
Attention needed from Igor Sheludko

Jakob Kummerow voted and added 1 comment

Votes added by Jakob Kummerow

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Jakob Kummerow . resolved

This is the result of the audit I promised in my last CL. I don't think any of these changes are critical, but probably nice to have.

Open in Gerrit

Related details

Attention is currently required from:
  • Igor Sheludko
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I49ae5ae945b4d38de3446a612c3c220aba031a53
Gerrit-Change-Number: 7062935
Gerrit-PatchSet: 1
Gerrit-Owner: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Attention: Igor Sheludko <ish...@chromium.org>
Gerrit-Comment-Date: Mon, 20 Oct 2025 12:37:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Igor Sheludko (Gerrit)

unread,
Oct 22, 2025, 1:32:43 PM (22 hours ago) Oct 22
to Jakob Kummerow, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Jakob Kummerow

Igor Sheludko voted and added 1 comment

Votes added by Igor Sheludko

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
Igor Sheludko . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Jakob Kummerow
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I49ae5ae945b4d38de3446a612c3c220aba031a53
Gerrit-Change-Number: 7062935
Gerrit-PatchSet: 1
Gerrit-Owner: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Attention: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Comment-Date: Wed, 22 Oct 2025 17:32:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Oct 22, 2025, 2:22:39 PM (21 hours ago) Oct 22
to Jakob Kummerow, Igor Sheludko, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[wasm-custom-desc] Handle Wasm objects on more prototype chains

This patch adds support for Wasm objects in a few more places
where we walk prototype chains.
Bug: 403372470
Change-Id: I49ae5ae945b4d38de3446a612c3c220aba031a53
Auto-Submit: Jakob Kummerow <jkum...@chromium.org>
Reviewed-by: Igor Sheludko <ish...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103300}
Files:
  • M src/api/api.cc
  • M src/builtins/builtins-api.cc
  • M src/objects/call-site-info.cc
  • M src/objects/keys.cc
Change size: S
Delta: 4 files changed, 25 insertions(+), 14 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Igor Sheludko
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I49ae5ae945b4d38de3446a612c3c220aba031a53
Gerrit-Change-Number: 7062935
Gerrit-PatchSet: 2
Gerrit-Owner: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages