[heap] Do not recompute limits in NotifyLoadingEnded [v8/v8 : main]
0 views
Skip to first unread message
Dominik Inführ (Gerrit)
Jan 7, 2026, 10:16:39 AM (2 days ago) Jan 7
to Omer Katz, Michael Lippautz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz and Omer Katz
Dominik Inführ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Michael Lippautz
- Omer Katz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Omer Katz (Gerrit)
Jan 7, 2026, 10:32:03 AM (2 days ago) Jan 7
to Dominik Inführ, Michael Lippautz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ and Michael Lippautz
Omer Katz voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Dominik Inführ
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Jan 7, 2026, 10:34:40 AM (2 days ago) Jan 7
to Dominik Inführ, Omer Katz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ
Michael Lippautz voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
Jan 7, 2026, 11:49:10 AM (2 days ago) Jan 7
to Michael Lippautz, Omer Katz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Dominik Inführ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Jan 7, 2026, 11:51:21 AM (2 days ago) Jan 7
to Dominik Inführ, Michael Lippautz, Omer Katz, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[heap] Do not recompute limits in NotifyLoadingEnded
We recently started resetting limits on incremental marking start
to avoid finalizing incremental marking prematurely in some scenarios.
For loading we had a similar issue, in order to fix this we
recompute limits in NotifyLoadingEnded(). But resetting allocation
limits on incremental marking start also incidentally addresses the
issue Omer discovered with loading. So in this CL we simply stop
updating allocation limits at all in NotifyLoadingEnded().
Initially I wasn't sure whether a change like this should go through
finch. But according to Omer recomputing the limit on
NotifyLoadingEnded did not have impact, so going back to baseline
should not regress anything either.
In addition this CL also starts resetting allocation limits
unconditionally on incremental marking start. Previously we only
did this when the loading phase was entered but not exited yet.
Bug: 444705203
Change-Id: I7dfbf6fcfc6c5db0b7e0416811c4bca85de6f420
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Reviewed-by: Omer Katz <omer...@chromium.org>
Commit-Queue: Dominik Inführ <dinf...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104524}
Files:
- M src/heap/heap.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz, +1 by Omer Katz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Manos Koukoutos (Gerrit)
Jan 8, 2026, 7:01:33 AM (23 hours ago) Jan 8
to V8 LUCI CQ, Dominik Inführ, Michael Lippautz, Omer Katz, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Manos Koukoutos has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages