[deoptimizer] Preserve OSR-related deopt reasons [v8/v8 : main]

0 views
Skip to first unread message

Marja Hölttä (Gerrit)

unread,
Sep 26, 2025, 6:14:06 AM (2 days ago) Sep 26
to Darius Mercadier, Olivier Flückiger, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Darius Mercadier and Olivier Flückiger

Marja Hölttä voted and added 1 comment

Votes added by Marja Hölttä

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Marja Hölttä . resolved

ptal

Open in Gerrit

Related details

Attention is currently required from:
  • Darius Mercadier
  • Olivier Flückiger
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I88f6d778d17a7dc7fa4143651ecf72994e73326b
Gerrit-Change-Number: 6988171
Gerrit-PatchSet: 3
Gerrit-Owner: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
Gerrit-Attention: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Attention: Olivier Flückiger <ol...@chromium.org>
Gerrit-Comment-Date: Fri, 26 Sep 2025 10:14:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Darius Mercadier (Gerrit)

unread,
Sep 26, 2025, 6:17:51 AM (2 days ago) Sep 26
to Marja Hölttä, Olivier Flückiger, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Marja Hölttä and Olivier Flückiger

Darius Mercadier voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Marja Hölttä
  • Olivier Flückiger
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I88f6d778d17a7dc7fa4143651ecf72994e73326b
Gerrit-Change-Number: 6988171
Gerrit-PatchSet: 3
Gerrit-Owner: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
Gerrit-Attention: Olivier Flückiger <ol...@chromium.org>
Gerrit-Attention: Marja Hölttä <ma...@chromium.org>
Gerrit-Comment-Date: Fri, 26 Sep 2025 10:17:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Marja Hölttä (Gerrit)

unread,
Sep 26, 2025, 6:18:08 AM (2 days ago) Sep 26
to Darius Mercadier, Olivier Flückiger, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Olivier Flückiger

Marja Hölttä voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Olivier Flückiger
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I88f6d778d17a7dc7fa4143651ecf72994e73326b
Gerrit-Change-Number: 6988171
Gerrit-PatchSet: 3
Gerrit-Owner: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
Gerrit-Attention: Olivier Flückiger <ol...@chromium.org>
Gerrit-Comment-Date: Fri, 26 Sep 2025 10:18:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Sep 26, 2025, 6:49:23 AM (2 days ago) Sep 26
to Marja Hölttä, Darius Mercadier, Olivier Flückiger, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[deoptimizer] Preserve OSR-related deopt reasons

Deoptimizer::DoComputeOutputFrames is checking against DeoptimizeReason::kOSREarlyExit so it must be preserved.
Change-Id: I88f6d778d17a7dc7fa4143651ecf72994e73326b
Commit-Queue: Marja Hölttä <ma...@chromium.org>
Reviewed-by: Darius Mercadier <dmerc...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#102787}
Files:
  • M src/deoptimizer/deoptimize-reason.h
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Darius Mercadier
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I88f6d778d17a7dc7fa4143651ecf72994e73326b
Gerrit-Change-Number: 6988171
Gerrit-PatchSet: 4
Gerrit-Owner: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
open
diffy
satisfied_requirement

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Sep 26, 2025, 7:29:57 AM (2 days ago) Sep 26
to Marja Hölttä, V8 LUCI CQ, Darius Mercadier, Olivier Flückiger, v8-re...@googlegroups.com

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/jetstream2 complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/11a7d79a510000

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I88f6d778d17a7dc7fa4143651ecf72994e73326b
Gerrit-Change-Number: 6988171
Gerrit-PatchSet: 4
Gerrit-Owner: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
Gerrit-Comment-Date: Fri, 26 Sep 2025 11:29:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Sep 26, 2025, 7:32:35 AM (2 days ago) Sep 26
to Marja Hölttä, V8 LUCI CQ, Darius Mercadier, Olivier Flückiger, v8-re...@googlegroups.com

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/jetstream2 complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/1649e979510000

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I88f6d778d17a7dc7fa4143651ecf72994e73326b
Gerrit-Change-Number: 6988171
Gerrit-PatchSet: 4
Gerrit-Owner: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
Gerrit-Comment-Date: Fri, 26 Sep 2025 11:32:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Darius Mercadier (Gerrit)

unread,
Sep 26, 2025, 7:35:10 AM (2 days ago) Sep 26
to Marja Hölttä, V8 LUCI CQ, chrom...@appspot.gserviceaccount.com, Olivier Flückiger, v8-re...@googlegroups.com

Darius Mercadier added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Darius Mercadier . resolved

Whups, pinpoint does not like this at all.... :/

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I88f6d778d17a7dc7fa4143651ecf72994e73326b
Gerrit-Change-Number: 6988171
Gerrit-PatchSet: 4
Gerrit-Owner: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
Gerrit-Comment-Date: Fri, 26 Sep 2025 11:35:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages