Issue 11238 in v8: Introduce gn flag to enable/disable wasm
497 views
Skip to first unread message
cleme… via monorail
Jan 25, 2021, 9:00:23 AM1/25/21
to v8-re...@googlegroups.com
Updates:
Labels: -Restrict-View-Google
Comment #3 on issue 11238 by clem...@chromium.org: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c3
Removing RVG. I think it was added unintentionally.
--
You received this message because:
1. The project was configured to send all issue notifications to this address
You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings
Labels: -Restrict-View-Google
Comment #3 on issue 11238 by clem...@chromium.org: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c3
Removing RVG. I think it was added unintentionally.
--
You received this message because:
1. The project was configured to send all issue notifications to this address
You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings
bugdroid via monorail
Jan 25, 2021, 12:00:38 PM1/25/21
to v8-re...@googlegroups.com
Comment #5 on issue 11238 by bugdroid: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c5
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/277714827150d508faaebacaa28a7c89cdedc39f
commit 277714827150d508faaebacaa28a7c89cdedc39f
Author: Clemens Backes <clem...@chromium.org>
Date: Mon Jan 25 16:59:53 2021
[build] Introduce gn arg to disable WebAssembly
For now, that flag only avoid the installation of the 'WebAssembly'
global. Follow-up CLs will remove unneeded code from the binary if the gn
arg is not set to true.
R=ecmzi...@chromium.org, mache...@chromium.org
Bug: v8:11238, v8:11344
Change-Id: Ie95b608ed12b0476470cb552138e369f863d249b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2646833
Commit-Queue: Clemens Backes <clem...@chromium.org>
Reviewed-by: Michael Achenbach <mache...@chromium.org>
Reviewed-by: Emanuel Ziegler <ecmzi...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72296}
[modify] https://crrev.com/277714827150d508faaebacaa28a7c89cdedc39f/src/flags/flag-definitions.h
[modify] https://crrev.com/277714827150d508faaebacaa28a7c89cdedc39f/BUILD.gn
bugdroid via monorail
Feb 22, 2021, 6:07:37 AM2/22/21
to v8-re...@googlegroups.com
Comment #7 on issue 11238 by bugdroid: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c7
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/18136654138db94cc8ffd9bade187a404004081e
commit 18136654138db94cc8ffd9bade187a404004081e
Author: Clemens Backes <clem...@chromium.org>
Date: Mon Feb 22 11:06:40 2021
[no-wasm] Skip wasm tests if wasm is disabled
This CL introduces a test runner flag to detect if webassembly has been
disabled. Since all tests that require wasm are alrady skipped in
lite mode, we introduce a has_webassembly flag for the test runner which
checks for v8_enable_webassembly=true and v8_enable_lite_mode=false.
As a drive-by, we also do not set the V8_ENABLE_WEBASSEMBLY
preprocessor flag if lite mode is enabled.
The status files are updated by splitting wasm tests from the
"lite_mode" section and checking for "not has_webassembly" instead.
Note that the v8_enable_webassembly=false configuration is not tested
on any bot currently, but I will make sure that all tests keep passing
on further changes in this configuration.
R=mache...@chromium.org
Bug: v8:11238
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Change-Id: I1841eb1f1633cb47e0c079f4a4a4d769ca3a9cbb
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2710425
Reviewed-by: Michael Achenbach <mache...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72898}
[modify] https://crrev.com/18136654138db94cc8ffd9bade187a404004081e/test/mjsunit/mjsunit.status
[modify] https://crrev.com/18136654138db94cc8ffd9bade187a404004081e/test/debugger/debugger.status
[modify] https://crrev.com/18136654138db94cc8ffd9bade187a404004081e/tools/unittests/testdata/testroot1/v8_build_config.json
[modify] https://crrev.com/18136654138db94cc8ffd9bade187a404004081e/tools/unittests/run_tests_test.py
[modify] https://crrev.com/18136654138db94cc8ffd9bade187a404004081e/tools/unittests/testdata/testroot2/v8_build_config.json
[modify] https://crrev.com/18136654138db94cc8ffd9bade187a404004081e/test/message/message.status
[modify] https://crrev.com/18136654138db94cc8ffd9bade187a404004081e/test/wasm-spec-tests/wasm-spec-tests.status
[modify] https://crrev.com/18136654138db94cc8ffd9bade187a404004081e/BUILD.gn
[modify] https://crrev.com/18136654138db94cc8ffd9bade187a404004081e/tools/testrunner/base_runner.py
[modify] https://crrev.com/18136654138db94cc8ffd9bade187a404004081e/test/wasm-js/wasm-js.status
[modify] https://crrev.com/18136654138db94cc8ffd9bade187a404004081e/test/cctest/cctest.status
[modify] https://crrev.com/18136654138db94cc8ffd9bade187a404004081e/test/inspector/inspector.status
[modify] https://crrev.com/18136654138db94cc8ffd9bade187a404004081e/test/unittests/unittests.status
commit 18136654138db94cc8ffd9bade187a404004081e
Author: Clemens Backes <clem...@chromium.org>
Date: Mon Feb 22 11:06:40 2021
[no-wasm] Skip wasm tests if wasm is disabled
This CL introduces a test runner flag to detect if webassembly has been
disabled. Since all tests that require wasm are alrady skipped in
lite mode, we introduce a has_webassembly flag for the test runner which
checks for v8_enable_webassembly=true and v8_enable_lite_mode=false.
As a drive-by, we also do not set the V8_ENABLE_WEBASSEMBLY
preprocessor flag if lite mode is enabled.
The status files are updated by splitting wasm tests from the
"lite_mode" section and checking for "not has_webassembly" instead.
Note that the v8_enable_webassembly=false configuration is not tested
on any bot currently, but I will make sure that all tests keep passing
on further changes in this configuration.
R=mache...@chromium.org
Bug: v8:11238
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Change-Id: I1841eb1f1633cb47e0c079f4a4a4d769ca3a9cbb
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2710425
Reviewed-by: Michael Achenbach <mache...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72898}
[modify] https://crrev.com/18136654138db94cc8ffd9bade187a404004081e/test/mjsunit/mjsunit.status
[modify] https://crrev.com/18136654138db94cc8ffd9bade187a404004081e/test/debugger/debugger.status
[modify] https://crrev.com/18136654138db94cc8ffd9bade187a404004081e/tools/unittests/testdata/testroot1/v8_build_config.json
[modify] https://crrev.com/18136654138db94cc8ffd9bade187a404004081e/tools/unittests/run_tests_test.py
[modify] https://crrev.com/18136654138db94cc8ffd9bade187a404004081e/tools/unittests/testdata/testroot2/v8_build_config.json
[modify] https://crrev.com/18136654138db94cc8ffd9bade187a404004081e/test/message/message.status
[modify] https://crrev.com/18136654138db94cc8ffd9bade187a404004081e/test/wasm-spec-tests/wasm-spec-tests.status
[modify] https://crrev.com/18136654138db94cc8ffd9bade187a404004081e/BUILD.gn
[modify] https://crrev.com/18136654138db94cc8ffd9bade187a404004081e/tools/testrunner/base_runner.py
[modify] https://crrev.com/18136654138db94cc8ffd9bade187a404004081e/test/wasm-js/wasm-js.status
[modify] https://crrev.com/18136654138db94cc8ffd9bade187a404004081e/test/cctest/cctest.status
[modify] https://crrev.com/18136654138db94cc8ffd9bade187a404004081e/test/inspector/inspector.status
[modify] https://crrev.com/18136654138db94cc8ffd9bade187a404004081e/test/unittests/unittests.status
bugdroid via monorail
Feb 22, 2021, 6:35:48 AM2/22/21
to v8-re...@googlegroups.com
Comment #8 on issue 11238 by bugdroid: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c8
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/4cd9625998b3a0064c764681575301f0b64289da
commit 4cd9625998b3a0064c764681575301f0b64289da
Author: Clemens Backes <clem...@chromium.org>
Date: Mon Feb 22 11:35:30 2021
[asm] Move regression tests to own directory
This moves all asm.js tests (tests that use "%IsAsmWasmCode") into a
separate directory. This will make it easier to skip them all in the
v8_enable_webassembly=false configuration.
R=ah...@chromium.org
Bug: v8:11238
Change-Id: I805f222b7977f5508f7dbee1f1bd61a88ccd34aa
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2710427
Commit-Queue: Clemens Backes <clem...@chromium.org>
Reviewed-by: Andreas Haas <ah...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72900}
[modify] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/mjsunit.status
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-crbug-719384.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-crbug-759327.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-crbug-771428.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-crbug-722348.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-wasm-crbug-618602.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-6700.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-599719.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-9022.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-crbug-898974.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-613928.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-crbug-714971.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-617529.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-617525.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-6838-3.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-617526.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-wasm-crbug-599413.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-8377.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-608630.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-6431.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-6838-1.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-crbug-976934.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-575364.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-crbug-934138.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-crbug-969368.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-6838-2.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-8505.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-6298.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-crbug-1006592.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-6838-4.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-775710.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-crbug-721835.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-6196.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-618608.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-592352.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-7893.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-599825.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-crbug-715455.js
commit 4cd9625998b3a0064c764681575301f0b64289da
Author: Clemens Backes <clem...@chromium.org>
Date: Mon Feb 22 11:35:30 2021
[asm] Move regression tests to own directory
This moves all asm.js tests (tests that use "%IsAsmWasmCode") into a
separate directory. This will make it easier to skip them all in the
v8_enable_webassembly=false configuration.
R=ah...@chromium.org
Bug: v8:11238
Change-Id: I805f222b7977f5508f7dbee1f1bd61a88ccd34aa
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2710427
Commit-Queue: Clemens Backes <clem...@chromium.org>
Reviewed-by: Andreas Haas <ah...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72900}
[modify] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/mjsunit.status
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-crbug-719384.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-crbug-759327.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-crbug-771428.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-crbug-722348.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-wasm-crbug-618602.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-6700.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-599719.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-9022.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-crbug-898974.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-613928.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-crbug-714971.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-617529.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-617525.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-6838-3.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-617526.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-wasm-crbug-599413.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-8377.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-608630.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-6431.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-6838-1.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-crbug-976934.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-575364.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-crbug-934138.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-crbug-969368.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-6838-2.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-8505.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-6298.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-crbug-1006592.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-6838-4.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-775710.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-crbug-721835.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-6196.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-618608.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-592352.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-7893.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-599825.js
[rename] https://crrev.com/4cd9625998b3a0064c764681575301f0b64289da/test/mjsunit/regress/asm/regress-crbug-715455.js
bugdroid via monorail
Feb 22, 2021, 7:22:45 AM2/22/21
to v8-re...@googlegroups.com
Comment #9 on issue 11238 by bugdroid: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c9
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/96bfcfb845fbb6889122708360148e82adedf98e
commit 96bfcfb845fbb6889122708360148e82adedf98e
Author: Clemens Backes <clem...@chromium.org>
Date: Mon Feb 22 12:19:20 2021
[no-wasm] Make --expose-wasm flag readonly
If webassembly is disabled via a gn arg, we will not be able to enable
it via command-line switch. Hence make this flag read-only in that
configuration.
R=ecmzi...@chromium.org
Bug: v8:11238
Change-Id: Ib93a55f74d4f018477f110b8b52aa9b645e86553
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2710426
Reviewed-by: Andreas Haas <ah...@chromium.org>
Reviewed-by: Emanuel Ziegler <ecmzi...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72905}
[modify] https://crrev.com/96bfcfb845fbb6889122708360148e82adedf98e/src/flags/flag-definitions.h
[modify] https://crrev.com/96bfcfb845fbb6889122708360148e82adedf98e/test/unittests/objects/value-serializer-unittest.cc
[modify] https://crrev.com/96bfcfb845fbb6889122708360148e82adedf98e/src/init/v8.cc
commit 96bfcfb845fbb6889122708360148e82adedf98e
Author: Clemens Backes <clem...@chromium.org>
Date: Mon Feb 22 12:19:20 2021
[no-wasm] Make --expose-wasm flag readonly
If webassembly is disabled via a gn arg, we will not be able to enable
it via command-line switch. Hence make this flag read-only in that
configuration.
R=ecmzi...@chromium.org
Bug: v8:11238
Change-Id: Ib93a55f74d4f018477f110b8b52aa9b645e86553
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2710426
Reviewed-by: Andreas Haas <ah...@chromium.org>
Reviewed-by: Emanuel Ziegler <ecmzi...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72905}
[modify] https://crrev.com/96bfcfb845fbb6889122708360148e82adedf98e/src/flags/flag-definitions.h
[modify] https://crrev.com/96bfcfb845fbb6889122708360148e82adedf98e/test/unittests/objects/value-serializer-unittest.cc
[modify] https://crrev.com/96bfcfb845fbb6889122708360148e82adedf98e/src/init/v8.cc
bugdroid via monorail
Feb 23, 2021, 4:33:00 AM2/23/21
to v8-re...@googlegroups.com
Comment #10 on issue 11238 by bugdroid: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c10
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/2dd28df97acc703a512556b5238195c3b9d7638d
commit 2dd28df97acc703a512556b5238195c3b9d7638d
Author: Clemens Backes <clem...@chromium.org>
Date: Tue Feb 23 09:32:34 2021
[wasm] Move regression tests to wasm directory
This moves all tests that construct a wasm module (and load
wasm-module-builder.js) from test/regress to the test/regress/wasm
commit 2dd28df97acc703a512556b5238195c3b9d7638d
Author: Clemens Backes <clem...@chromium.org>
Date: Tue Feb 23 09:32:34 2021
[wasm] Move regression tests to wasm directory
This moves all tests that construct a wasm module (and load
wasm-module-builder.js) from test/regress to the test/regress/wasm
directory. This will make it easier to skip them all in the
v8_enable_webassembly=false configuration.
R=ah...@chromium.org
Bug: v8:11238
Change-Id: Ib22b0fb40a58f213182e68b78b34041651c436d1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2712243
Reviewed-by: Andreas Haas <ah...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72942}
[rename] https://crrev.com/2dd28df97acc703a512556b5238195c3b9d7638d/test/mjsunit/regress/wasm/regress-crbug-816961.js
[rename] https://crrev.com/2dd28df97acc703a512556b5238195c3b9d7638d/test/mjsunit/regress/wasm/regress-863810.js
[rename] https://crrev.com/2dd28df97acc703a512556b5238195c3b9d7638d/test/mjsunit/regress/wasm/regress-1034394.js
[modify] https://crrev.com/2dd28df97acc703a512556b5238195c3b9d7638d/test/mjsunit/mjsunit.status
[rename] https://crrev.com/2dd28df97acc703a512556b5238195c3b9d7638d/test/mjsunit/regress/wasm/regress-crbug-969498.js
[rename] https://crrev.com/2dd28df97acc703a512556b5238195c3b9d7638d/test/mjsunit/regress/wasm/regress-v8-9106.js
[rename] https://crrev.com/2dd28df97acc703a512556b5238195c3b9d7638d/test/mjsunit/regress/wasm/regress-813440.js
[rename] https://crrev.com/2dd28df97acc703a512556b5238195c3b9d7638d/test/mjsunit/regress/wasm/regress-crbug-1047368.js
[rename] https://crrev.com/2dd28df97acc703a512556b5238195c3b9d7638d/test/mjsunit/regress/wasm/regress-5911.js
[rename] https://crrev.com/2dd28df97acc703a512556b5238195c3b9d7638d/test/mjsunit/regress/wasm/regress-9209.js
[rename] https://crrev.com/2dd28df97acc703a512556b5238195c3b9d7638d/test/mjsunit/regress/wasm/regress-crbug-772056.js
[rename] https://crrev.com/2dd28df97acc703a512556b5238195c3b9d7638d/test/mjsunit/regress/wasm/regress-8947.js
[rename] https://crrev.com/2dd28df97acc703a512556b5238195c3b9d7638d/test/mjsunit/regress/wasm/regress-5888.js
[rename] https://crrev.com/2dd28df97acc703a512556b5238195c3b9d7638d/test/mjsunit/regress/wasm/regress-9832.js
[rename] https://crrev.com/2dd28df97acc703a512556b5238195c3b9d7638d/test/mjsunit/regress/wasm/regress-crbug-746835.js
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2712243
Reviewed-by: Andreas Haas <ah...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72942}
[rename] https://crrev.com/2dd28df97acc703a512556b5238195c3b9d7638d/test/mjsunit/regress/wasm/regress-crbug-816961.js
[rename] https://crrev.com/2dd28df97acc703a512556b5238195c3b9d7638d/test/mjsunit/regress/wasm/regress-863810.js
[rename] https://crrev.com/2dd28df97acc703a512556b5238195c3b9d7638d/test/mjsunit/regress/wasm/regress-1034394.js
[modify] https://crrev.com/2dd28df97acc703a512556b5238195c3b9d7638d/test/mjsunit/mjsunit.status
[rename] https://crrev.com/2dd28df97acc703a512556b5238195c3b9d7638d/test/mjsunit/regress/wasm/regress-crbug-969498.js
[rename] https://crrev.com/2dd28df97acc703a512556b5238195c3b9d7638d/test/mjsunit/regress/wasm/regress-v8-9106.js
[rename] https://crrev.com/2dd28df97acc703a512556b5238195c3b9d7638d/test/mjsunit/regress/wasm/regress-813440.js
[rename] https://crrev.com/2dd28df97acc703a512556b5238195c3b9d7638d/test/mjsunit/regress/wasm/regress-crbug-1047368.js
[rename] https://crrev.com/2dd28df97acc703a512556b5238195c3b9d7638d/test/mjsunit/regress/wasm/regress-5911.js
[rename] https://crrev.com/2dd28df97acc703a512556b5238195c3b9d7638d/test/mjsunit/regress/wasm/regress-9209.js
[rename] https://crrev.com/2dd28df97acc703a512556b5238195c3b9d7638d/test/mjsunit/regress/wasm/regress-crbug-772056.js
[rename] https://crrev.com/2dd28df97acc703a512556b5238195c3b9d7638d/test/mjsunit/regress/wasm/regress-8947.js
[rename] https://crrev.com/2dd28df97acc703a512556b5238195c3b9d7638d/test/mjsunit/regress/wasm/regress-5888.js
[rename] https://crrev.com/2dd28df97acc703a512556b5238195c3b9d7638d/test/mjsunit/regress/wasm/regress-9832.js
[rename] https://crrev.com/2dd28df97acc703a512556b5238195c3b9d7638d/test/mjsunit/regress/wasm/regress-crbug-746835.js
bugdroid via monorail
Feb 23, 2021, 4:52:31 AM2/23/21
to v8-re...@googlegroups.com
Comment #11 on issue 11238 by bugdroid: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c11
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/ca89bf259f3ec118af788ec2410c0efe84806197
commit ca89bf259f3ec118af788ec2410c0efe84806197
Author: Clemens Backes <clem...@chromium.org>
Date: Tue Feb 23 09:51:40 2021
[no-wasm] Exclude asm->wasm translation code
The v8_enable_webassembly=false configuration will not be a able to run
any wasm code, hence remove the whole asm to wasm translation from the
binary.
In order to skip specific unit tests in that configuration, we move the
definition of the v8_enable_webassembly gn argument from BUILD.gn to
v8.gni, such that it is available in all gn files.
R=ecmzi...@chromium.org, mache...@chromium.org
Bug: v8:11238
Change-Id: Id4e290df3e42ffd2f05c377bdd3a368871815daf
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2712562
Commit-Queue: Clemens Backes <clem...@chromium.org>
commit ca89bf259f3ec118af788ec2410c0efe84806197
Author: Clemens Backes <clem...@chromium.org>
Date: Tue Feb 23 09:51:40 2021
[no-wasm] Exclude asm->wasm translation code
The v8_enable_webassembly=false configuration will not be a able to run
any wasm code, hence remove the whole asm to wasm translation from the
binary.
In order to skip specific unit tests in that configuration, we move the
definition of the v8_enable_webassembly gn argument from BUILD.gn to
v8.gni, such that it is available in all gn files.
R=ecmzi...@chromium.org, mache...@chromium.org
Bug: v8:11238
Change-Id: Id4e290df3e42ffd2f05c377bdd3a368871815daf
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2712562
Commit-Queue: Clemens Backes <clem...@chromium.org>
Reviewed-by: Michael Achenbach <mache...@chromium.org>
Reviewed-by: Emanuel Ziegler <ecmzi...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72945}
[modify] https://crrev.com/ca89bf259f3ec118af788ec2410c0efe84806197/test/cctest/test-api.cc
[modify] https://crrev.com/ca89bf259f3ec118af788ec2410c0efe84806197/test/cctest/cctest.status
[modify] https://crrev.com/ca89bf259f3ec118af788ec2410c0efe84806197/BUILD.gn
[modify] https://crrev.com/ca89bf259f3ec118af788ec2410c0efe84806197/test/mjsunit/mjsunit.status
[modify] https://crrev.com/ca89bf259f3ec118af788ec2410c0efe84806197/test/unittests/BUILD.gn
[modify] https://crrev.com/ca89bf259f3ec118af788ec2410c0efe84806197/gni/v8.gni
[modify] https://crrev.com/ca89bf259f3ec118af788ec2410c0efe84806197/src/codegen/compiler.cc
[modify] https://crrev.com/ca89bf259f3ec118af788ec2410c0efe84806197/src/runtime/runtime-compiler.cc
[modify] https://crrev.com/ca89bf259f3ec118af788ec2410c0efe84806197/src/wasm/module-instantiate.cc
[modify] https://crrev.com/ca89bf259f3ec118af788ec2410c0efe84806197/test/cctest/test-api.cc
[modify] https://crrev.com/ca89bf259f3ec118af788ec2410c0efe84806197/test/cctest/cctest.status
[modify] https://crrev.com/ca89bf259f3ec118af788ec2410c0efe84806197/BUILD.gn
[modify] https://crrev.com/ca89bf259f3ec118af788ec2410c0efe84806197/test/mjsunit/mjsunit.status
[modify] https://crrev.com/ca89bf259f3ec118af788ec2410c0efe84806197/test/unittests/BUILD.gn
[modify] https://crrev.com/ca89bf259f3ec118af788ec2410c0efe84806197/gni/v8.gni
[modify] https://crrev.com/ca89bf259f3ec118af788ec2410c0efe84806197/src/codegen/compiler.cc
[modify] https://crrev.com/ca89bf259f3ec118af788ec2410c0efe84806197/src/runtime/runtime-compiler.cc
[modify] https://crrev.com/ca89bf259f3ec118af788ec2410c0efe84806197/src/wasm/module-instantiate.cc
bugdroid via monorail
Feb 23, 2021, 10:01:33 AM2/23/21
to v8-re...@googlegroups.com
Comment #12 on issue 11238 by bugdroid: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c12
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/b411a66486c255d69f3888d1054b1ff61b1ed97d
commit b411a66486c255d69f3888d1054b1ff61b1ed97d
Author: Clemens Backes <clem...@chromium.org>
Date: Tue Feb 23 15:00:33 2021
[build] Assert that webassembly is disabled on lite mode
This avoids having to check both flags in two places, and prevents
people from trying to enable WebAssembly in lite mode (which would
currently build, but you still would not get Wasm support).
The downside is that the default value shown by `gn args --list` now
sais `""` instead of `true`.
R=mache...@chromium.org, rmci...@chromium.org
CC=ecmzi...@chromium.org
commit b411a66486c255d69f3888d1054b1ff61b1ed97d
Author: Clemens Backes <clem...@chromium.org>
Date: Tue Feb 23 15:00:33 2021
[build] Assert that webassembly is disabled on lite mode
This avoids having to check both flags in two places, and prevents
people from trying to enable WebAssembly in lite mode (which would
currently build, but you still would not get Wasm support).
The downside is that the default value shown by `gn args --list` now
sais `""` instead of `true`.
R=mache...@chromium.org, rmci...@chromium.org
CC=ecmzi...@chromium.org
Bug: v8:11238
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Change-Id: Ib2fe6c32cbdeb89895265bb898abf7284c560cc3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2712783
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2712783
Commit-Queue: Clemens Backes <clem...@chromium.org>
Reviewed-by: Michael Achenbach <mache...@chromium.org>
Reviewed-by: Ross McIlroy <rmci...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72957}
[modify] https://crrev.com/b411a66486c255d69f3888d1054b1ff61b1ed97d/BUILD.gn
[modify] https://crrev.com/b411a66486c255d69f3888d1054b1ff61b1ed97d/tools/testrunner/base_runner.py
[modify] https://crrev.com/b411a66486c255d69f3888d1054b1ff61b1ed97d/gni/v8.gni
Cr-Commit-Position: refs/heads/master@{#72957}
[modify] https://crrev.com/b411a66486c255d69f3888d1054b1ff61b1ed97d/BUILD.gn
[modify] https://crrev.com/b411a66486c255d69f3888d1054b1ff61b1ed97d/tools/testrunner/base_runner.py
[modify] https://crrev.com/b411a66486c255d69f3888d1054b1ff61b1ed97d/gni/v8.gni
bugdroid via monorail
Feb 26, 2021, 7:53:29 AM2/26/21
to v8-re...@googlegroups.com
Comment #13 on issue 11238 by bugdroid: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c13
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/6fe59c0cb63b38de5c89f8b34a69cbd76916293a
commit 6fe59c0cb63b38de5c89f8b34a69cbd76916293a
Author: Clemens Backes <clem...@chromium.org>
Date: Fri Feb 26 12:53:12 2021
[no-wasm] Remove wasm tests and fuzzers
Wasm tests and wasm fuzzers should not be compiled (and run) if
v8_enable_webassembly=false.
R=mache...@chromium.org
Bug: v8:11238
Change-Id: I78bbb1d1d98179cac315411b8c2c2ecaee8ede91
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2721761
Reviewed-by: Michael Achenbach <mache...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73071}
[modify] https://crrev.com/6fe59c0cb63b38de5c89f8b34a69cbd76916293a/BUILD.gn
[modify] https://crrev.com/6fe59c0cb63b38de5c89f8b34a69cbd76916293a/test/cctest/test-api.cc
[modify] https://crrev.com/6fe59c0cb63b38de5c89f8b34a69cbd76916293a/test/fuzzer/fuzzer.status
[modify] https://crrev.com/6fe59c0cb63b38de5c89f8b34a69cbd76916293a/test/unittests/BUILD.gn
[modify] https://crrev.com/6fe59c0cb63b38de5c89f8b34a69cbd76916293a/test/cctest/BUILD.gn
commit 6fe59c0cb63b38de5c89f8b34a69cbd76916293a
Author: Clemens Backes <clem...@chromium.org>
Date: Fri Feb 26 12:53:12 2021
[no-wasm] Remove wasm tests and fuzzers
Wasm tests and wasm fuzzers should not be compiled (and run) if
v8_enable_webassembly=false.
R=mache...@chromium.org
Bug: v8:11238
Change-Id: I78bbb1d1d98179cac315411b8c2c2ecaee8ede91
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2721761
Reviewed-by: Michael Achenbach <mache...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73071}
[modify] https://crrev.com/6fe59c0cb63b38de5c89f8b34a69cbd76916293a/BUILD.gn
[modify] https://crrev.com/6fe59c0cb63b38de5c89f8b34a69cbd76916293a/test/cctest/test-api.cc
[modify] https://crrev.com/6fe59c0cb63b38de5c89f8b34a69cbd76916293a/test/fuzzer/fuzzer.status
[modify] https://crrev.com/6fe59c0cb63b38de5c89f8b34a69cbd76916293a/test/unittests/BUILD.gn
[modify] https://crrev.com/6fe59c0cb63b38de5c89f8b34a69cbd76916293a/test/cctest/BUILD.gn
bugdroid via monorail
Mar 1, 2021, 10:25:40 AM3/1/21
to v8-re...@googlegroups.com
Comment #14 on issue 11238 by bugdroid: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c14
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/0be822b47e92503e3eaf3bec563141aa1bf9f368
commit 0be822b47e92503e3eaf3bec563141aa1bf9f368
Author: Clemens Backes <clem...@chromium.org>
Date: Mon Mar 01 15:24:52 2021
[api][no-wasm] Disable Webassembly in the API
This CL removes the includes of src/wasm files from the API if Wasm is
disabled (v8_enable_webassembly=false). This will allow to later
remove the whole src/wasm directory from compilation.
Since we do not want to modify the exposed API in a no-wasm build, we
instead make all Wasm-related functions fail.
R=ul...@chromium.org
Bug: v8:11238
Change-Id: I61038e75ac62871758351eb01f299fe68d478c82
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2726504
Reviewed-by: Ulan Degenbaev <ul...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73100}
[modify] https://crrev.com/0be822b47e92503e3eaf3bec563141aa1bf9f368/src/base/macros.h
[modify] https://crrev.com/0be822b47e92503e3eaf3bec563141aa1bf9f368/src/api/api.cc
[modify] https://crrev.com/0be822b47e92503e3eaf3bec563141aa1bf9f368/src/api/api.h
commit 0be822b47e92503e3eaf3bec563141aa1bf9f368
Author: Clemens Backes <clem...@chromium.org>
Date: Mon Mar 01 15:24:52 2021
[api][no-wasm] Disable Webassembly in the API
This CL removes the includes of src/wasm files from the API if Wasm is
disabled (v8_enable_webassembly=false). This will allow to later
remove the whole src/wasm directory from compilation.
Since we do not want to modify the exposed API in a no-wasm build, we
instead make all Wasm-related functions fail.
R=ul...@chromium.org
Bug: v8:11238
Change-Id: I61038e75ac62871758351eb01f299fe68d478c82
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2726504
Reviewed-by: Ulan Degenbaev <ul...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73100}
[modify] https://crrev.com/0be822b47e92503e3eaf3bec563141aa1bf9f368/src/base/macros.h
[modify] https://crrev.com/0be822b47e92503e3eaf3bec563141aa1bf9f368/src/api/api.cc
[modify] https://crrev.com/0be822b47e92503e3eaf3bec563141aa1bf9f368/src/api/api.h
bugdroid via monorail
Mar 2, 2021, 1:29:51 PM3/2/21
to v8-re...@googlegroups.com
Comment #15 on issue 11238 by bugdroid: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c15
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/8890bb21f938cf041ac3a14df777de49c848b036
commit 8890bb21f938cf041ac3a14df777de49c848b036
Author: Clemens Backes <clem...@chromium.org>
Date: Tue Mar 02 18:27:53 2021
[no-wasm] Remove wasm debugging support
This removes all wasm includes from src/debug and src/inspector if
webassembly is disabled (v8_enable_webassembly=false). It also removes
the definition of {WasmValueObject} and {v8::debug::WasmScript}.
This will allow to later fully exclude the src/wasm directory from
compilation (once other components are fixed).
R=bme...@chromium.org, mache...@chromium.org
Bug: v8:11238
Change-Id: I41a1d83d01fbb6c015cdfd6cc063bad90052505d
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2726506
Reviewed-by: Michael Achenbach <mache...@chromium.org>
Reviewed-by: Benedikt Meurer <bme...@chromium.org>
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Reviewed-by: Maya Lekova <msle...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73138}
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/debug/debug.cc
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/inspector/v8-debugger.cc
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/debug/debug-wasm-objects.h
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/compiler/types.cc
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/diagnostics/objects-printer.cc
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/objects/objects-body-descriptors-inl.h
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/debug/debug.h
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/debug/debug-frames.cc
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/runtime/runtime-debug.cc
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/inspector/v8-debugger-script.h
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/objects/map.cc
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/inspector/value-mirror.cc
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/debug/debug-evaluate.cc
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/objects/object-list-macros.h
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/objects/js-function.cc
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/debug/debug-stack-trace-iterator.cc
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/inspector/v8-debugger-script.cc
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/BUILD.gn
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/debug/debug-interface.h
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/objects/js-objects.cc
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/diagnostics/objects-debug.cc
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/debug/debug-interface.cc
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/tools/gcmole/gcmole.py
commit 8890bb21f938cf041ac3a14df777de49c848b036
Author: Clemens Backes <clem...@chromium.org>
Date: Tue Mar 02 18:27:53 2021
[no-wasm] Remove wasm debugging support
This removes all wasm includes from src/debug and src/inspector if
webassembly is disabled (v8_enable_webassembly=false). It also removes
the definition of {WasmValueObject} and {v8::debug::WasmScript}.
This will allow to later fully exclude the src/wasm directory from
compilation (once other components are fixed).
R=bme...@chromium.org, mache...@chromium.org
Bug: v8:11238
Change-Id: I41a1d83d01fbb6c015cdfd6cc063bad90052505d
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2726506
Reviewed-by: Michael Achenbach <mache...@chromium.org>
Reviewed-by: Benedikt Meurer <bme...@chromium.org>
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Reviewed-by: Maya Lekova <msle...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73138}
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/debug/debug.cc
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/inspector/v8-debugger.cc
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/debug/debug-wasm-objects.h
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/compiler/types.cc
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/diagnostics/objects-printer.cc
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/objects/objects-body-descriptors-inl.h
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/debug/debug.h
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/debug/debug-frames.cc
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/runtime/runtime-debug.cc
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/inspector/v8-debugger-script.h
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/objects/map.cc
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/inspector/value-mirror.cc
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/debug/debug-evaluate.cc
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/objects/object-list-macros.h
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/objects/js-function.cc
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/debug/debug-stack-trace-iterator.cc
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/inspector/v8-debugger-script.cc
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/BUILD.gn
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/debug/debug-interface.h
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/objects/js-objects.cc
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/diagnostics/objects-debug.cc
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/src/debug/debug-interface.cc
[modify] https://crrev.com/8890bb21f938cf041ac3a14df777de49c848b036/tools/gcmole/gcmole.py
bugdroid via monorail
Mar 3, 2021, 8:08:32 AM3/3/21
to v8-re...@googlegroups.com
Comment #16 on issue 11238 by bugdroid: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c16
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/99af8d491829c0a8d334f9927b473c3a67d171da
commit 99af8d491829c0a8d334f9927b473c3a67d171da
Author: Clemens Backes <clem...@chromium.org>
Date: Wed Mar 03 13:07:01 2021
[wasm] Move test-backing-store.cc to wasm directory
This is a wasm-only test, hence move it to the wasm directory and skip
it in no-wasm builds.
R=ah...@chromium.org
Bug: v8:11238
Change-Id: I57c9abbb98c3415f4d759372d479e1f61464217f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2731536
Reviewed-by: Andreas Haas <ah...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73152}
[modify] https://crrev.com/99af8d491829c0a8d334f9927b473c3a67d171da/test/cctest/BUILD.gn
[rename] https://crrev.com/99af8d491829c0a8d334f9927b473c3a67d171da/test/cctest/wasm/test-backing-store.cc
commit 99af8d491829c0a8d334f9927b473c3a67d171da
Author: Clemens Backes <clem...@chromium.org>
Date: Wed Mar 03 13:07:01 2021
[wasm] Move test-backing-store.cc to wasm directory
This is a wasm-only test, hence move it to the wasm directory and skip
it in no-wasm builds.
R=ah...@chromium.org
Bug: v8:11238
Change-Id: I57c9abbb98c3415f4d759372d479e1f61464217f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2731536
Reviewed-by: Andreas Haas <ah...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73152}
[modify] https://crrev.com/99af8d491829c0a8d334f9927b473c3a67d171da/test/cctest/BUILD.gn
[rename] https://crrev.com/99af8d491829c0a8d334f9927b473c3a67d171da/test/cctest/wasm/test-backing-store.cc
Git Watcher via monorail
Mar 5, 2021, 9:51:09 PM3/5/21
to v8-re...@googlegroups.com
Comment #18 on issue 11238 by Git Watcher: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c18
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/c1908c1373cb264ab3a80e7d2036c9ff55b14af4
commit c1908c1373cb264ab3a80e7d2036c9ff55b14af4
Author: Clemens Backes <clem...@chromium.org>
Date: Fri Mar 05 11:30:13 2021
[no-wasm] Fix build
This fixes a compile error after https://crrev.com/c/2715193.
TBR=bme...@chromium.org
Bug: v8:11238
Change-Id: I0b063fab4c00263b05af057534a9093ad0ddbf7d
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739635
Reviewed-by: Clemens Backes <clem...@chromium.org>
Reviewed-by: Eric Leese <le...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73229}
[modify] https://crrev.com/c1908c1373cb264ab3a80e7d2036c9ff55b14af4/src/inspector/value-mirror.cc
commit c1908c1373cb264ab3a80e7d2036c9ff55b14af4
Author: Clemens Backes <clem...@chromium.org>
Date: Fri Mar 05 11:30:13 2021
[no-wasm] Fix build
This fixes a compile error after https://crrev.com/c/2715193.
TBR=bme...@chromium.org
Bug: v8:11238
Change-Id: I0b063fab4c00263b05af057534a9093ad0ddbf7d
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739635
Reviewed-by: Clemens Backes <clem...@chromium.org>
Reviewed-by: Eric Leese <le...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73229}
[modify] https://crrev.com/c1908c1373cb264ab3a80e7d2036c9ff55b14af4/src/inspector/value-mirror.cc
Git Watcher via monorail
Mar 5, 2021, 10:03:42 PM3/5/21
to v8-re...@googlegroups.com
Comment #21 on issue 11238 by Git Watcher: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c21
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/15f5679e041a27cf7206881f5f465e6cf3e4adde
commit 15f5679e041a27cf7206881f5f465e6cf3e4adde
Author: Clemens Backes <clem...@chromium.org>
Date: Fri Mar 05 15:26:00 2021
[no-wasm] Split off runtime-test-wasm.cc
This moves all wasm-related runtime functions from runtime-test.cc to
runtime-test-wasm.cc, which makes it easier to fully exclude them later.
R=ah...@chromium.org
Bug: v8:11238
Change-Id: I3bc1c175b8db8837097308ed09aab69725dcf5aa
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739648
Commit-Queue: Clemens Backes <clem...@chromium.org>
Reviewed-by: Andreas Haas <ah...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73236}
[modify] https://crrev.com/15f5679e041a27cf7206881f5f465e6cf3e4adde/BUILD.gn
[add] https://crrev.com/15f5679e041a27cf7206881f5f465e6cf3e4adde/src/runtime/runtime-test-wasm.cc
[modify] https://crrev.com/15f5679e041a27cf7206881f5f465e6cf3e4adde/src/runtime/runtime-test.cc
commit 15f5679e041a27cf7206881f5f465e6cf3e4adde
Author: Clemens Backes <clem...@chromium.org>
Date: Fri Mar 05 15:26:00 2021
[no-wasm] Split off runtime-test-wasm.cc
This moves all wasm-related runtime functions from runtime-test.cc to
runtime-test-wasm.cc, which makes it easier to fully exclude them later.
R=ah...@chromium.org
Bug: v8:11238
Change-Id: I3bc1c175b8db8837097308ed09aab69725dcf5aa
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739648
Commit-Queue: Clemens Backes <clem...@chromium.org>
Reviewed-by: Andreas Haas <ah...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73236}
[modify] https://crrev.com/15f5679e041a27cf7206881f5f465e6cf3e4adde/BUILD.gn
[add] https://crrev.com/15f5679e041a27cf7206881f5f465e6cf3e4adde/src/runtime/runtime-test-wasm.cc
[modify] https://crrev.com/15f5679e041a27cf7206881f5f465e6cf3e4adde/src/runtime/runtime-test.cc
Git Watcher via monorail
Mar 5, 2021, 10:03:45 PM3/5/21
to v8-re...@googlegroups.com
Git Watcher via monorail
Mar 5, 2021, 10:03:54 PM3/5/21
to v8-re...@googlegroups.com
Comment #20 on issue 11238 by Git Watcher: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c20
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/4e0ac2ed13d929651d459890d74be4aef669044b
commit 4e0ac2ed13d929651d459890d74be4aef669044b
Author: Clemens Backes <clem...@chromium.org>
Date: Fri Mar 05 11:40:31 2021
[no-wasm] Remove wasm-js
This CL removes wasm-js.cc from compilation if
v8_enable_webassembly=false. In order to do so, an alternative
implementation of {v8::WasmStreaming} has to be provided, because the
public API should stay unchanged. The only path to obtain a
{v8::WasmStreaming} object is via {v8::WasmStreaming::Unpack}, which
will always fail if WebAssembly is not supported. Hence all methods in
{WasmStreamingImpl} are unreachable.
As a drive-by, this CL removes all includes from src/wasm in src/init
(bootstrapper.cc would have been done anyway, and v8.cc is just a few
changes).
R=jkum...@chromium.org
Bug: v8:11238
Change-Id: Ic0638eb5cda91ec29c1c07ef400bc670c91630fb
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2737300
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73234}
[modify] https://crrev.com/4e0ac2ed13d929651d459890d74be4aef669044b/BUILD.gn
[modify] https://crrev.com/4e0ac2ed13d929651d459890d74be4aef669044b/src/api/api.cc
[modify] https://crrev.com/4e0ac2ed13d929651d459890d74be4aef669044b/src/init/bootstrapper.cc
[modify] https://crrev.com/4e0ac2ed13d929651d459890d74be4aef669044b/src/init/v8.cc
commit 4e0ac2ed13d929651d459890d74be4aef669044b
Author: Clemens Backes <clem...@chromium.org>
Date: Fri Mar 05 11:40:31 2021
[no-wasm] Remove wasm-js
This CL removes wasm-js.cc from compilation if
v8_enable_webassembly=false. In order to do so, an alternative
implementation of {v8::WasmStreaming} has to be provided, because the
public API should stay unchanged. The only path to obtain a
{v8::WasmStreaming} object is via {v8::WasmStreaming::Unpack}, which
will always fail if WebAssembly is not supported. Hence all methods in
{WasmStreamingImpl} are unreachable.
As a drive-by, this CL removes all includes from src/wasm in src/init
(bootstrapper.cc would have been done anyway, and v8.cc is just a few
changes).
R=jkum...@chromium.org
Bug: v8:11238
Change-Id: Ic0638eb5cda91ec29c1c07ef400bc670c91630fb
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2737300
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73234}
[modify] https://crrev.com/4e0ac2ed13d929651d459890d74be4aef669044b/BUILD.gn
[modify] https://crrev.com/4e0ac2ed13d929651d459890d74be4aef669044b/src/api/api.cc
[modify] https://crrev.com/4e0ac2ed13d929651d459890d74be4aef669044b/src/init/bootstrapper.cc
[modify] https://crrev.com/4e0ac2ed13d929651d459890d74be4aef669044b/src/init/v8.cc
Git Watcher via monorail
Mar 5, 2021, 10:04:19 PM3/5/21
to v8-re...@googlegroups.com
Comment #19 on issue 11238 by Git Watcher: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c19
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/c87b273c29f442520b0806e5a880e3cf964254c1
commit c87b273c29f442520b0806e5a880e3cf964254c1
Author: Clemens Backes <clem...@chromium.org>
Date: Fri Mar 05 11:35:37 2021
[no-wasm] Remove wasm engine from isolate
This removes the {wasm_engine_} field from the isolate if
v8_enable_webassembly=false. This avoids any includes from src/wasm in
isolate.{h,cc}.
Unconditional access to the wasm engine in other parts are also #if'ed
out to avoid nullptr accesses.
Long-term, the {Isolate::wasm_engine()} method will be fully removed,
but this can only be done once src/wasm is excluded from compilation.
R=jkum...@chromium.org, peterm...@chromium.org
Bug: v8:11238
Change-Id: Ie3738884ec17ccc0a3027b91a2415c2c633ca774
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2737298
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Reviewed-by: Peter Marshall <peterm...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73230}
[modify] https://crrev.com/c87b273c29f442520b0806e5a880e3cf964254c1/src/diagnostics/disassembler.cc
[modify] https://crrev.com/c87b273c29f442520b0806e5a880e3cf964254c1/src/execution/frames.cc
[modify] https://crrev.com/c87b273c29f442520b0806e5a880e3cf964254c1/src/execution/isolate.cc
[modify] https://crrev.com/c87b273c29f442520b0806e5a880e3cf964254c1/src/execution/isolate.h
[modify] https://crrev.com/c87b273c29f442520b0806e5a880e3cf964254c1/src/profiler/cpu-profiler.cc
commit c87b273c29f442520b0806e5a880e3cf964254c1
Author: Clemens Backes <clem...@chromium.org>
Date: Fri Mar 05 11:35:37 2021
[no-wasm] Remove wasm engine from isolate
This removes the {wasm_engine_} field from the isolate if
v8_enable_webassembly=false. This avoids any includes from src/wasm in
isolate.{h,cc}.
Unconditional access to the wasm engine in other parts are also #if'ed
out to avoid nullptr accesses.
Long-term, the {Isolate::wasm_engine()} method will be fully removed,
but this can only be done once src/wasm is excluded from compilation.
R=jkum...@chromium.org, peterm...@chromium.org
Bug: v8:11238
Change-Id: Ie3738884ec17ccc0a3027b91a2415c2c633ca774
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2737298
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Reviewed-by: Peter Marshall <peterm...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73230}
[modify] https://crrev.com/c87b273c29f442520b0806e5a880e3cf964254c1/src/diagnostics/disassembler.cc
[modify] https://crrev.com/c87b273c29f442520b0806e5a880e3cf964254c1/src/execution/frames.cc
[modify] https://crrev.com/c87b273c29f442520b0806e5a880e3cf964254c1/src/execution/isolate.cc
[modify] https://crrev.com/c87b273c29f442520b0806e5a880e3cf964254c1/src/execution/isolate.h
[modify] https://crrev.com/c87b273c29f442520b0806e5a880e3cf964254c1/src/profiler/cpu-profiler.cc
Git Watcher via monorail
Mar 8, 2021, 6:35:09 AM3/8/21
to v8-re...@googlegroups.com
Comment #22 on issue 11238 by Git Watcher: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c22
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/7585aaf3e311913c2e2d4d11d89275c0513c1d13
commit 7585aaf3e311913c2e2d4d11d89275c0513c1d13
Author: Clemens Backes <clem...@chromium.org>
Date: Fri Mar 05 17:35:25 2021
[IWYU] Fix includes of wasm-engine.h
Remove the include from js-array-buffer-inl.h, because the wasm engine
is not used in that file. Add missing includes in other files that
relied on the recursive include.
R=jkum...@chromium.org
commit 7585aaf3e311913c2e2d4d11d89275c0513c1d13
Author: Clemens Backes <clem...@chromium.org>
Date: Fri Mar 05 17:35:25 2021
[IWYU] Fix includes of wasm-engine.h
Remove the include from js-array-buffer-inl.h, because the wasm engine
is not used in that file. Add missing includes in other files that
relied on the recursive include.
R=jkum...@chromium.org
Bug: v8:11238
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Change-Id: I8b7f11ce92858cbc0ccf26925159486ed39573fa
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739650
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73254}
[modify] https://crrev.com/7585aaf3e311913c2e2d4d11d89275c0513c1d13/src/logging/log.cc
[modify] https://crrev.com/7585aaf3e311913c2e2d4d11d89275c0513c1d13/src/objects/js-array-buffer-inl.h
[modify] https://crrev.com/7585aaf3e311913c2e2d4d11d89275c0513c1d13/src/wasm/c-api.cc
[modify] https://crrev.com/7585aaf3e311913c2e2d4d11d89275c0513c1d13/src/wasm/function-compiler.cc
[modify] https://crrev.com/7585aaf3e311913c2e2d4d11d89275c0513c1d13/src/wasm/wasm-code-manager.cc
[modify] https://crrev.com/7585aaf3e311913c2e2d4d11d89275c0513c1d13/src/wasm/wasm-debug.cc
[modify] https://crrev.com/7585aaf3e311913c2e2d4d11d89275c0513c1d13/src/wasm/wasm-serialization.cc
[modify] https://crrev.com/7585aaf3e311913c2e2d4d11d89275c0513c1d13/test/cctest/compiler/test-code-generator.cc
[modify] https://crrev.com/7585aaf3e311913c2e2d4d11d89275c0513c1d13/test/cctest/wasm/test-wasm-metrics.cc
[modify] https://crrev.com/7585aaf3e311913c2e2d4d11d89275c0513c1d13/test/cctest/wasm/wasm-run-utils.cc
[modify] https://crrev.com/7585aaf3e311913c2e2d4d11d89275c0513c1d13/test/unittests/objects/value-serializer-unittest.cc
[modify] https://crrev.com/7585aaf3e311913c2e2d4d11d89275c0513c1d13/test/unittests/wasm/module-decoder-memory64-unittest.cc
[modify] https://crrev.com/7585aaf3e311913c2e2d4d11d89275c0513c1d13/test/unittests/wasm/module-decoder-unittest.cc
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739650
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73254}
[modify] https://crrev.com/7585aaf3e311913c2e2d4d11d89275c0513c1d13/src/logging/log.cc
[modify] https://crrev.com/7585aaf3e311913c2e2d4d11d89275c0513c1d13/src/objects/js-array-buffer-inl.h
[modify] https://crrev.com/7585aaf3e311913c2e2d4d11d89275c0513c1d13/src/wasm/c-api.cc
[modify] https://crrev.com/7585aaf3e311913c2e2d4d11d89275c0513c1d13/src/wasm/function-compiler.cc
[modify] https://crrev.com/7585aaf3e311913c2e2d4d11d89275c0513c1d13/src/wasm/wasm-code-manager.cc
[modify] https://crrev.com/7585aaf3e311913c2e2d4d11d89275c0513c1d13/src/wasm/wasm-debug.cc
[modify] https://crrev.com/7585aaf3e311913c2e2d4d11d89275c0513c1d13/src/wasm/wasm-serialization.cc
[modify] https://crrev.com/7585aaf3e311913c2e2d4d11d89275c0513c1d13/test/cctest/compiler/test-code-generator.cc
[modify] https://crrev.com/7585aaf3e311913c2e2d4d11d89275c0513c1d13/test/cctest/wasm/test-wasm-metrics.cc
[modify] https://crrev.com/7585aaf3e311913c2e2d4d11d89275c0513c1d13/test/cctest/wasm/wasm-run-utils.cc
[modify] https://crrev.com/7585aaf3e311913c2e2d4d11d89275c0513c1d13/test/unittests/objects/value-serializer-unittest.cc
[modify] https://crrev.com/7585aaf3e311913c2e2d4d11d89275c0513c1d13/test/unittests/wasm/module-decoder-memory64-unittest.cc
[modify] https://crrev.com/7585aaf3e311913c2e2d4d11d89275c0513c1d13/test/unittests/wasm/module-decoder-unittest.cc
Git Watcher via monorail
Mar 8, 2021, 7:58:08 AM3/8/21
to v8-re...@googlegroups.com
Comment #23 on issue 11238 by Git Watcher: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c23
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/2cd2c4885a7a80cabdeee194435566ac334d9a47
commit 2cd2c4885a7a80cabdeee194435566ac334d9a47
Author: Clemens Backes <clem...@chromium.org>
Date: Fri Mar 05 17:46:02 2021
[no-wasm] Remove deoptimizer support
This removes all includes of src/wasm from src/deoptimizer, by #if'ing
out wasm-related parts. This will allow to later exclude the whole
src/wasm directory from compilation.
Drive-by: Inline DecodeWasmReturnKind and EncodeWasmReturnKind to avoid
more #ifs.
R=jgr...@chromium.org
Bug: v8:11238
Change-Id: Ia49ed26fc217b3e80756a363dcd397d9060f6835
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739653
Reviewed-by: Jakob Gruber <jgr...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73261}
[modify] https://crrev.com/2cd2c4885a7a80cabdeee194435566ac334d9a47/src/deoptimizer/deoptimizer.cc
[modify] https://crrev.com/2cd2c4885a7a80cabdeee194435566ac334d9a47/src/deoptimizer/deoptimizer.h
[modify] https://crrev.com/2cd2c4885a7a80cabdeee194435566ac334d9a47/src/deoptimizer/translated-state.cc
[modify] https://crrev.com/2cd2c4885a7a80cabdeee194435566ac334d9a47/src/deoptimizer/translated-state.h
[modify] https://crrev.com/2cd2c4885a7a80cabdeee194435566ac334d9a47/src/deoptimizer/translation-array.cc
[modify] https://crrev.com/2cd2c4885a7a80cabdeee194435566ac334d9a47/src/deoptimizer/translation-array.h
[modify] https://crrev.com/2cd2c4885a7a80cabdeee194435566ac334d9a47/src/deoptimizer/translation-opcode.h
commit 2cd2c4885a7a80cabdeee194435566ac334d9a47
Author: Clemens Backes <clem...@chromium.org>
Date: Fri Mar 05 17:46:02 2021
[no-wasm] Remove deoptimizer support
This removes all includes of src/wasm from src/deoptimizer, by #if'ing
out wasm-related parts. This will allow to later exclude the whole
src/wasm directory from compilation.
Drive-by: Inline DecodeWasmReturnKind and EncodeWasmReturnKind to avoid
more #ifs.
R=jgr...@chromium.org
Bug: v8:11238
Change-Id: Ia49ed26fc217b3e80756a363dcd397d9060f6835
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739653
Reviewed-by: Jakob Gruber <jgr...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73261}
[modify] https://crrev.com/2cd2c4885a7a80cabdeee194435566ac334d9a47/src/deoptimizer/deoptimizer.cc
[modify] https://crrev.com/2cd2c4885a7a80cabdeee194435566ac334d9a47/src/deoptimizer/deoptimizer.h
[modify] https://crrev.com/2cd2c4885a7a80cabdeee194435566ac334d9a47/src/deoptimizer/translated-state.cc
[modify] https://crrev.com/2cd2c4885a7a80cabdeee194435566ac334d9a47/src/deoptimizer/translated-state.h
[modify] https://crrev.com/2cd2c4885a7a80cabdeee194435566ac334d9a47/src/deoptimizer/translation-array.cc
[modify] https://crrev.com/2cd2c4885a7a80cabdeee194435566ac334d9a47/src/deoptimizer/translation-array.h
[modify] https://crrev.com/2cd2c4885a7a80cabdeee194435566ac334d9a47/src/deoptimizer/translation-opcode.h
Git Watcher via monorail
Mar 9, 2021, 6:27:08 AM3/9/21
to v8-re...@googlegroups.com
Comment #24 on issue 11238 by Git Watcher: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c24
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/577f983b7a0a6edea9c5c58148c688abb823e23a
commit 577f983b7a0a6edea9c5c58148c688abb823e23a
Author: Clemens Backes <clem...@chromium.org>
Date: Mon Mar 08 13:47:44 2021
[no-wasm] Exclude more targets from build
This excludes more targets and tests that won't work without
webassembly:
- wee8
- multi_return_fuzzer
- wasm-js
- wasm-spec-tests
- wasm-api-tests
- several cctests
R=jkum...@chromium.org
Bug: v8:11238
Change-Id: I6d6ac43869a2b4a91e5b0e7e3183a476a98bf0af
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2742617
Commit-Queue: Clemens Backes <clem...@chromium.org>
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73288}
[modify] https://crrev.com/577f983b7a0a6edea9c5c58148c688abb823e23a/BUILD.gn
[modify] https://crrev.com/577f983b7a0a6edea9c5c58148c688abb823e23a/test/BUILD.gn
[modify] https://crrev.com/577f983b7a0a6edea9c5c58148c688abb823e23a/test/cctest/BUILD.gn
[modify] https://crrev.com/577f983b7a0a6edea9c5c58148c688abb823e23a/test/fuzzer/BUILD.gn
commit 577f983b7a0a6edea9c5c58148c688abb823e23a
Author: Clemens Backes <clem...@chromium.org>
Date: Mon Mar 08 13:47:44 2021
[no-wasm] Exclude more targets from build
This excludes more targets and tests that won't work without
webassembly:
- wee8
- multi_return_fuzzer
- wasm-js
- wasm-spec-tests
- wasm-api-tests
- several cctests
R=jkum...@chromium.org
Bug: v8:11238
Change-Id: I6d6ac43869a2b4a91e5b0e7e3183a476a98bf0af
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2742617
Commit-Queue: Clemens Backes <clem...@chromium.org>
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73288}
[modify] https://crrev.com/577f983b7a0a6edea9c5c58148c688abb823e23a/BUILD.gn
[modify] https://crrev.com/577f983b7a0a6edea9c5c58148c688abb823e23a/test/BUILD.gn
[modify] https://crrev.com/577f983b7a0a6edea9c5c58148c688abb823e23a/test/cctest/BUILD.gn
[modify] https://crrev.com/577f983b7a0a6edea9c5c58148c688abb823e23a/test/fuzzer/BUILD.gn
Git Watcher via monorail
Mar 9, 2021, 6:42:06 AM3/9/21
to v8-re...@googlegroups.com
Comment #25 on issue 11238 by Git Watcher: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c25
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/16175b1592cbcb85c284a5f378bbcb4d191237f3
commit 16175b1592cbcb85c284a5f378bbcb4d191237f3
Author: Liu Yu <li...@loongson.cn>
Date: Sat Mar 06 02:46:50 2021
[mips][no-wasm] Remove wasm-specific code from codegen
Port: 75d7d12720594d19140aeb86a9183ed342615547
Bug: v8:11238
Change-Id: I5369875fe66d2297cbd342db91b1ffd99a361616
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2738792
Reviewed-by: Zhao Jiazhong <zhaojia...@loongson.cn>
Commit-Queue: Zhao Jiazhong <zhaojia...@loongson.cn>
Auto-Submit: Liu yu <li...@loongson.cn>
Cr-Commit-Position: refs/heads/master@{#73289}
[modify] https://crrev.com/16175b1592cbcb85c284a5f378bbcb4d191237f3/src/codegen/mips/macro-assembler-mips.cc
[modify] https://crrev.com/16175b1592cbcb85c284a5f378bbcb4d191237f3/src/codegen/mips64/macro-assembler-mips64.cc
[modify] https://crrev.com/16175b1592cbcb85c284a5f378bbcb4d191237f3/src/compiler/backend/mips/code-generator-mips.cc
[modify] https://crrev.com/16175b1592cbcb85c284a5f378bbcb4d191237f3/src/compiler/backend/mips/instruction-scheduler-mips.cc
[modify] https://crrev.com/16175b1592cbcb85c284a5f378bbcb4d191237f3/src/compiler/backend/mips/instruction-selector-mips.cc
[modify] https://crrev.com/16175b1592cbcb85c284a5f378bbcb4d191237f3/src/compiler/backend/mips64/code-generator-mips64.cc
[modify] https://crrev.com/16175b1592cbcb85c284a5f378bbcb4d191237f3/src/compiler/backend/mips64/instruction-scheduler-mips64.cc
[modify] https://crrev.com/16175b1592cbcb85c284a5f378bbcb4d191237f3/src/compiler/backend/mips64/instruction-selector-mips64.cc
commit 16175b1592cbcb85c284a5f378bbcb4d191237f3
Author: Liu Yu <li...@loongson.cn>
Date: Sat Mar 06 02:46:50 2021
[mips][no-wasm] Remove wasm-specific code from codegen
Port: 75d7d12720594d19140aeb86a9183ed342615547
Bug: v8:11238
Change-Id: I5369875fe66d2297cbd342db91b1ffd99a361616
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2738792
Reviewed-by: Zhao Jiazhong <zhaojia...@loongson.cn>
Commit-Queue: Zhao Jiazhong <zhaojia...@loongson.cn>
Auto-Submit: Liu yu <li...@loongson.cn>
Cr-Commit-Position: refs/heads/master@{#73289}
[modify] https://crrev.com/16175b1592cbcb85c284a5f378bbcb4d191237f3/src/codegen/mips/macro-assembler-mips.cc
[modify] https://crrev.com/16175b1592cbcb85c284a5f378bbcb4d191237f3/src/codegen/mips64/macro-assembler-mips64.cc
[modify] https://crrev.com/16175b1592cbcb85c284a5f378bbcb4d191237f3/src/compiler/backend/mips/code-generator-mips.cc
[modify] https://crrev.com/16175b1592cbcb85c284a5f378bbcb4d191237f3/src/compiler/backend/mips/instruction-scheduler-mips.cc
[modify] https://crrev.com/16175b1592cbcb85c284a5f378bbcb4d191237f3/src/compiler/backend/mips/instruction-selector-mips.cc
[modify] https://crrev.com/16175b1592cbcb85c284a5f378bbcb4d191237f3/src/compiler/backend/mips64/code-generator-mips64.cc
[modify] https://crrev.com/16175b1592cbcb85c284a5f378bbcb4d191237f3/src/compiler/backend/mips64/instruction-scheduler-mips64.cc
[modify] https://crrev.com/16175b1592cbcb85c284a5f378bbcb4d191237f3/src/compiler/backend/mips64/instruction-selector-mips64.cc
Git Watcher via monorail
Mar 11, 2021, 5:51:05 AM3/11/21
to v8-re...@googlegroups.com
Comment #26 on issue 11238 by Git Watcher: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c26
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/2dbdfcddea7ada4fa5b4f8cd16c2d64cb32d2b2d
commit 2dbdfcddea7ada4fa5b4f8cd16c2d64cb32d2b2d
Author: Clemens Backes <clem...@chromium.org>
Date: Tue Mar 09 12:12:59 2021
[no-wasm][logging] Remove wasm support for logging
The definition of {wasm::WasmCode} will not be available in no-wasm
builds, hence avoid any accesses to WasmCode for logging.
Drive-by: Inline enumeration of wasm modules for logging of existing
code, to avoid another #if.
R=peterm...@chromium.org, jgr...@chromium.org
Bug: v8:11238
Change-Id: I3b78cf90f9ad155b5bea64e0941531aed2d4291a
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739978
Reviewed-by: Peter Marshall <peterm...@chromium.org>
commit 2dbdfcddea7ada4fa5b4f8cd16c2d64cb32d2b2d
Author: Clemens Backes <clem...@chromium.org>
Date: Tue Mar 09 12:12:59 2021
[no-wasm][logging] Remove wasm support for logging
The definition of {wasm::WasmCode} will not be available in no-wasm
builds, hence avoid any accesses to WasmCode for logging.
Drive-by: Inline enumeration of wasm modules for logging of existing
code, to avoid another #if.
R=peterm...@chromium.org, jgr...@chromium.org
Bug: v8:11238
Change-Id: I3b78cf90f9ad155b5bea64e0941531aed2d4291a
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739978
Reviewed-by: Peter Marshall <peterm...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73338}
[modify] https://crrev.com/2dbdfcddea7ada4fa5b4f8cd16c2d64cb32d2b2d/src/diagnostics/perf-jit.cc
[modify] https://crrev.com/2dbdfcddea7ada4fa5b4f8cd16c2d64cb32d2b2d/src/diagnostics/perf-jit.h
[modify] https://crrev.com/2dbdfcddea7ada4fa5b4f8cd16c2d64cb32d2b2d/src/logging/code-events.h
[modify] https://crrev.com/2dbdfcddea7ada4fa5b4f8cd16c2d64cb32d2b2d/src/logging/log.cc
[modify] https://crrev.com/2dbdfcddea7ada4fa5b4f8cd16c2d64cb32d2b2d/src/logging/log.h
[modify] https://crrev.com/2dbdfcddea7ada4fa5b4f8cd16c2d64cb32d2b2d/src/profiler/cpu-profiler-inl.h
[modify] https://crrev.com/2dbdfcddea7ada4fa5b4f8cd16c2d64cb32d2b2d/src/profiler/profiler-listener.cc
[modify] https://crrev.com/2dbdfcddea7ada4fa5b4f8cd16c2d64cb32d2b2d/src/profiler/profiler-listener.h
[modify] https://crrev.com/2dbdfcddea7ada4fa5b4f8cd16c2d64cb32d2b2d/src/runtime/runtime-test.cc
[modify] https://crrev.com/2dbdfcddea7ada4fa5b4f8cd16c2d64cb32d2b2d/src/snapshot/serializer.h
[modify] https://crrev.com/2dbdfcddea7ada4fa5b4f8cd16c2d64cb32d2b2d/src/wasm/wasm-code-manager.cc
[modify] https://crrev.com/2dbdfcddea7ada4fa5b4f8cd16c2d64cb32d2b2d/test/cctest/test-log.cc
[modify] https://crrev.com/2dbdfcddea7ada4fa5b4f8cd16c2d64cb32d2b2d/src/diagnostics/perf-jit.cc
[modify] https://crrev.com/2dbdfcddea7ada4fa5b4f8cd16c2d64cb32d2b2d/src/diagnostics/perf-jit.h
[modify] https://crrev.com/2dbdfcddea7ada4fa5b4f8cd16c2d64cb32d2b2d/src/logging/code-events.h
[modify] https://crrev.com/2dbdfcddea7ada4fa5b4f8cd16c2d64cb32d2b2d/src/logging/log.cc
[modify] https://crrev.com/2dbdfcddea7ada4fa5b4f8cd16c2d64cb32d2b2d/src/logging/log.h
[modify] https://crrev.com/2dbdfcddea7ada4fa5b4f8cd16c2d64cb32d2b2d/src/profiler/cpu-profiler-inl.h
[modify] https://crrev.com/2dbdfcddea7ada4fa5b4f8cd16c2d64cb32d2b2d/src/profiler/profiler-listener.cc
[modify] https://crrev.com/2dbdfcddea7ada4fa5b4f8cd16c2d64cb32d2b2d/src/profiler/profiler-listener.h
[modify] https://crrev.com/2dbdfcddea7ada4fa5b4f8cd16c2d64cb32d2b2d/src/runtime/runtime-test.cc
[modify] https://crrev.com/2dbdfcddea7ada4fa5b4f8cd16c2d64cb32d2b2d/src/snapshot/serializer.h
[modify] https://crrev.com/2dbdfcddea7ada4fa5b4f8cd16c2d64cb32d2b2d/src/wasm/wasm-code-manager.cc
[modify] https://crrev.com/2dbdfcddea7ada4fa5b4f8cd16c2d64cb32d2b2d/test/cctest/test-log.cc
Git Watcher via monorail
Mar 11, 2021, 7:44:06 AM3/11/21
to v8-re...@googlegroups.com
Comment #27 on issue 11238 by Git Watcher: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c27
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d
commit 80f5dfda0147d6b078ae6c9d0eb947bd012bf72d
Author: Clemens Backes <clem...@chromium.org>
Date: Thu Mar 11 11:53:24 2021
[no-wasm] Exclude src/wasm from compilation
This is the biggest chunk, including
- all of src/wasm,
- torque file for wasm objects,
- torque file for wasm builtins,
- wasm builtins,
- wasm runtime functions,
- int64 lowering,
- simd scala lowering,
- WasmGraphBuilder (TF graph construction for wasm),
- wasm frame types,
- wasm interrupts,
- the JSWasmCall opcode,
- wasm backing store allocation.
Those components are all recursively entangled, so I found no way to
split this change up further.
Some includes that were recursively included by wasm headers needed to
be added explicitly now.
backing-store-unittest.cc is renamed to wasm-backing-store-unittest.cc
because it only tests wasm backing stores. This file is excluded from
no-wasm builds then.
R=jkum...@chromium.org, jgr...@chromium.org, mlip...@chromium.org, peterm...@chromium.org
Bug: v8:11238
Change-Id: I7558f2d12d2dd6c65128c4de7b79173668c80b2b
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2742955
Commit-Queue: Clemens Backes <clem...@chromium.org>
Reviewed-by: Peter Marshall <peterm...@chromium.org>
Reviewed-by: Toon Verwaest <verw...@chromium.org>
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Reviewed-by: Jakob Gruber <jgr...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73344}
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/BUILD.gn
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/api/api-inl.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/api/api.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/builtins/accessors.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/builtins/arm/builtins-arm.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/builtins/builtins-array.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/builtins/builtins-callsite.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/builtins/builtins-definitions.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/builtins/builtins-iterator-gen.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/builtins/builtins-typed-array-gen.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/builtins/builtins.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/builtins/ia32/builtins-ia32.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/builtins/x64/builtins-x64.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/codegen/arm/macro-assembler-arm.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/codegen/arm64/macro-assembler-arm64.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/codegen/compiler.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/codegen/external-reference.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/codegen/external-reference.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/codegen/handler-table.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/codegen/handler-table.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/codegen/optimized-compilation-info.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/codegen/optimized-compilation-info.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/codegen/safepoint-table.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/codegen/safepoint-table.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/common/globals.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/backend/arm/code-generator-arm.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/backend/arm64/instruction-selector-arm64.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/backend/code-generator.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/backend/ia32/instruction-selector-ia32.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/backend/instruction-selector.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/backend/instruction-selector.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/backend/x64/code-generator-x64.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/backend/x64/instruction-selector-x64.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/csa-load-elimination.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/frame-states.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/frame-states.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/js-generic-lowering.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/js-inlining-heuristic.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/js-inlining.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/js-operator.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/js-operator.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/linkage.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/linkage.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/opcodes.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/operator-properties.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/pipeline.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/simplified-lowering.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/typer.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/verifier.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/wasm-compiler.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/d8/d8.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/debug/debug-frames.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/debug/debug-frames.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/debug/debug-stack-trace-iterator.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/debug/debug.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/diagnostics/objects-debug.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/diagnostics/objects-printer.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/execution/execution.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/execution/execution.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/execution/frame-constants.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/execution/frames-inl.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/execution/frames.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/execution/frames.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/execution/isolate-inl.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/execution/isolate.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/execution/isolate.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/execution/messages.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/execution/stack-guard.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/heap/concurrent-marking.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/heap/factory.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/heap/factory.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/heap/mark-compact.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/heap/memory-measurement.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/heap/objects-visiting-inl.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/heap/objects-visiting.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/heap/scavenger.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/heap/setup-heap-internal.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/ic/ic.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/backing-store.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/backing-store.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/js-function-inl.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/js-function.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/js-objects.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/map-inl.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/map.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/map.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/object-list-macros.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/objects-body-descriptors-inl.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/objects-definitions.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/objects-inl.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/objects.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/shared-function-info-inl.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/shared-function-info.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/shared-function-info.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/stack-frame-info-inl.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/stack-frame-info.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/stack-frame-info.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/value-serializer.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/value-serializer.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/parsing/parse-info.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/profiler/heap-profiler.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/regexp/regexp.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/roots/roots.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/runtime/runtime-compiler.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/runtime/runtime-debug.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/runtime/runtime-test.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/runtime/runtime.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/runtime/runtime.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/snapshot/code-serializer.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/snapshot/context-deserializer.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/snapshot/object-deserializer.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/snapshot/snapshot.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/wasm/value-type.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/cctest/cctest.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/cctest/compiler/node-observer-tester.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/cctest/compiler/test-code-generator.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/cctest/compiler/test-concurrent-shared-function-info.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/cctest/compiler/test-linkage.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/cctest/compiler/test-run-calls-to-external-references.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/cctest/compiler/test-sloppy-equality.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/cctest/heap/test-write-barrier.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/cctest/test-api-array-buffer.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/cctest/test-api-typed-array.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/cctest/test-api.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/cctest/test-code-stub-assembler.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/cctest/test-debug-helper.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/cctest/test-icache.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/fuzzer/fuzzer-support.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/mjsunit/mjsunit.status
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/unittests/BUILD.gn
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/unittests/api/access-check-unittest.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/unittests/numbers/conversions-unittest.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/unittests/objects/value-serializer-unittest.cc
[rename] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/unittests/objects/wasm-backing-store-unittest.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/wasm-api-tests/wasm-api-tests.status
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/tools/v8heapconst.py
commit 80f5dfda0147d6b078ae6c9d0eb947bd012bf72d
Author: Clemens Backes <clem...@chromium.org>
Date: Thu Mar 11 11:53:24 2021
[no-wasm] Exclude src/wasm from compilation
This is the biggest chunk, including
- all of src/wasm,
- torque file for wasm objects,
- torque file for wasm builtins,
- wasm builtins,
- wasm runtime functions,
- int64 lowering,
- simd scala lowering,
- WasmGraphBuilder (TF graph construction for wasm),
- wasm frame types,
- wasm interrupts,
- the JSWasmCall opcode,
- wasm backing store allocation.
Those components are all recursively entangled, so I found no way to
split this change up further.
Some includes that were recursively included by wasm headers needed to
be added explicitly now.
backing-store-unittest.cc is renamed to wasm-backing-store-unittest.cc
because it only tests wasm backing stores. This file is excluded from
no-wasm builds then.
R=jkum...@chromium.org, jgr...@chromium.org, mlip...@chromium.org, peterm...@chromium.org
Bug: v8:11238
Change-Id: I7558f2d12d2dd6c65128c4de7b79173668c80b2b
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2742955
Commit-Queue: Clemens Backes <clem...@chromium.org>
Reviewed-by: Peter Marshall <peterm...@chromium.org>
Reviewed-by: Toon Verwaest <verw...@chromium.org>
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Reviewed-by: Jakob Gruber <jgr...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73344}
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/BUILD.gn
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/api/api-inl.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/api/api.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/builtins/accessors.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/builtins/arm/builtins-arm.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/builtins/builtins-array.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/builtins/builtins-callsite.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/builtins/builtins-definitions.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/builtins/builtins-iterator-gen.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/builtins/builtins-typed-array-gen.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/builtins/builtins.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/builtins/ia32/builtins-ia32.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/builtins/x64/builtins-x64.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/codegen/arm/macro-assembler-arm.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/codegen/arm64/macro-assembler-arm64.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/codegen/compiler.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/codegen/external-reference.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/codegen/external-reference.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/codegen/handler-table.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/codegen/handler-table.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/codegen/optimized-compilation-info.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/codegen/optimized-compilation-info.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/codegen/safepoint-table.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/codegen/safepoint-table.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/common/globals.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/backend/arm/code-generator-arm.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/backend/arm64/instruction-selector-arm64.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/backend/code-generator.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/backend/ia32/instruction-selector-ia32.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/backend/instruction-selector.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/backend/instruction-selector.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/backend/x64/code-generator-x64.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/backend/x64/instruction-selector-x64.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/csa-load-elimination.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/frame-states.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/frame-states.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/js-generic-lowering.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/js-inlining-heuristic.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/js-inlining.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/js-operator.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/js-operator.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/linkage.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/linkage.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/opcodes.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/operator-properties.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/pipeline.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/simplified-lowering.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/typer.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/verifier.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/compiler/wasm-compiler.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/d8/d8.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/debug/debug-frames.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/debug/debug-frames.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/debug/debug-stack-trace-iterator.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/debug/debug.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/diagnostics/objects-debug.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/diagnostics/objects-printer.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/execution/execution.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/execution/execution.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/execution/frame-constants.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/execution/frames-inl.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/execution/frames.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/execution/frames.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/execution/isolate-inl.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/execution/isolate.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/execution/isolate.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/execution/messages.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/execution/stack-guard.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/heap/concurrent-marking.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/heap/factory.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/heap/factory.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/heap/mark-compact.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/heap/memory-measurement.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/heap/objects-visiting-inl.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/heap/objects-visiting.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/heap/scavenger.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/heap/setup-heap-internal.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/ic/ic.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/backing-store.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/backing-store.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/js-function-inl.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/js-function.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/js-objects.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/map-inl.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/map.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/map.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/object-list-macros.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/objects-body-descriptors-inl.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/objects-definitions.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/objects-inl.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/objects.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/shared-function-info-inl.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/shared-function-info.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/shared-function-info.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/stack-frame-info-inl.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/stack-frame-info.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/stack-frame-info.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/value-serializer.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/objects/value-serializer.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/parsing/parse-info.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/profiler/heap-profiler.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/regexp/regexp.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/roots/roots.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/runtime/runtime-compiler.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/runtime/runtime-debug.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/runtime/runtime-test.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/runtime/runtime.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/runtime/runtime.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/snapshot/code-serializer.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/snapshot/context-deserializer.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/snapshot/object-deserializer.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/snapshot/snapshot.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/src/wasm/value-type.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/cctest/cctest.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/cctest/compiler/node-observer-tester.h
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/cctest/compiler/test-code-generator.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/cctest/compiler/test-concurrent-shared-function-info.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/cctest/compiler/test-linkage.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/cctest/compiler/test-run-calls-to-external-references.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/cctest/compiler/test-sloppy-equality.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/cctest/heap/test-write-barrier.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/cctest/test-api-array-buffer.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/cctest/test-api-typed-array.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/cctest/test-api.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/cctest/test-code-stub-assembler.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/cctest/test-debug-helper.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/cctest/test-icache.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/fuzzer/fuzzer-support.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/mjsunit/mjsunit.status
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/unittests/BUILD.gn
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/unittests/api/access-check-unittest.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/unittests/numbers/conversions-unittest.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/unittests/objects/value-serializer-unittest.cc
[rename] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/unittests/objects/wasm-backing-store-unittest.cc
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/test/wasm-api-tests/wasm-api-tests.status
[modify] https://crrev.com/80f5dfda0147d6b078ae6c9d0eb947bd012bf72d/tools/v8heapconst.py
Git Watcher via monorail
Mar 11, 2021, 8:10:06 AM3/11/21
to v8-re...@googlegroups.com
Comment #28 on issue 11238 by Git Watcher: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c28
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/92bc3d386182446796c5905d78b652330c8522f2
commit 92bc3d386182446796c5905d78b652330c8522f2
Author: Clemens Backes <clem...@chromium.org>
Date: Thu Mar 11 13:08:29 2021
Revert "[no-wasm] Exclude src/wasm from compilation"
This reverts commit 80f5dfda0147d6b078ae6c9d0eb947bd012bf72d.
Reason for revert: Fails CSA verification: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20verify%20csa/21766/overview
Original change's description:
commit 92bc3d386182446796c5905d78b652330c8522f2
Author: Clemens Backes <clem...@chromium.org>
Date: Thu Mar 11 13:08:29 2021
Revert "[no-wasm] Exclude src/wasm from compilation"
This reverts commit 80f5dfda0147d6b078ae6c9d0eb947bd012bf72d.
Reason for revert: Fails CSA verification: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20verify%20csa/21766/overview
Original change's description:
Bug: v8:11238
Change-Id: I93672002c1faa36bb0bb5b4a9cc2032ee2ccd814
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2752866
Auto-Submit: Clemens Backes <clem...@chromium.org>
Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#73346}
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/BUILD.gn
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/api/api-inl.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/api/api.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/builtins/accessors.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/builtins/arm/builtins-arm.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/builtins/builtins-array.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/builtins/builtins-callsite.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/builtins/builtins-definitions.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/builtins/builtins-iterator-gen.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/builtins/builtins-typed-array-gen.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/builtins/builtins.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/builtins/ia32/builtins-ia32.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/builtins/x64/builtins-x64.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/codegen/arm/macro-assembler-arm.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/codegen/arm64/macro-assembler-arm64.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/codegen/compiler.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/codegen/external-reference.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/codegen/external-reference.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/codegen/handler-table.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/codegen/handler-table.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/codegen/optimized-compilation-info.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/codegen/optimized-compilation-info.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/codegen/safepoint-table.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/codegen/safepoint-table.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/common/globals.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/backend/arm/code-generator-arm.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/backend/arm64/instruction-selector-arm64.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/backend/code-generator.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/backend/ia32/instruction-selector-ia32.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/backend/instruction-selector.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/backend/instruction-selector.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/backend/x64/code-generator-x64.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/backend/x64/instruction-selector-x64.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/csa-load-elimination.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/frame-states.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/frame-states.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/js-generic-lowering.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/js-inlining-heuristic.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/js-inlining.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/js-operator.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/js-operator.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/linkage.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/linkage.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/opcodes.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/operator-properties.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/pipeline.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/simplified-lowering.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/typer.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/verifier.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/wasm-compiler.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/d8/d8.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/debug/debug-frames.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/debug/debug-frames.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/debug/debug-stack-trace-iterator.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/debug/debug.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/diagnostics/objects-debug.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/diagnostics/objects-printer.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/execution/execution.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/execution/execution.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/execution/frame-constants.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/execution/frames-inl.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/execution/frames.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/execution/frames.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/execution/isolate-inl.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/execution/isolate.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/execution/isolate.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/execution/messages.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/execution/stack-guard.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/heap/concurrent-marking.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/heap/factory.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/heap/factory.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/heap/mark-compact.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/heap/memory-measurement.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/heap/objects-visiting-inl.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/heap/objects-visiting.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/heap/scavenger.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/heap/setup-heap-internal.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/ic/ic.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/backing-store.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/backing-store.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/js-function-inl.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/js-function.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/js-objects.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/map-inl.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/map.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/map.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/object-list-macros.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/objects-body-descriptors-inl.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/objects-definitions.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/objects-inl.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/objects.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/shared-function-info-inl.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/shared-function-info.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/shared-function-info.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/stack-frame-info-inl.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/stack-frame-info.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/stack-frame-info.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/value-serializer.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/value-serializer.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/parsing/parse-info.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/profiler/heap-profiler.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/regexp/regexp.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/roots/roots.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/runtime/runtime-compiler.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/runtime/runtime-debug.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/runtime/runtime-test.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/runtime/runtime.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/runtime/runtime.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/snapshot/code-serializer.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/snapshot/context-deserializer.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/snapshot/object-deserializer.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/snapshot/snapshot.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/wasm/value-type.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/cctest/cctest.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/cctest/compiler/node-observer-tester.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/cctest/compiler/test-code-generator.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/cctest/compiler/test-concurrent-shared-function-info.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/cctest/compiler/test-linkage.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/cctest/compiler/test-run-calls-to-external-references.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/cctest/compiler/test-sloppy-equality.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/cctest/heap/test-write-barrier.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/cctest/test-api-array-buffer.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/cctest/test-api-typed-array.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/cctest/test-api.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/cctest/test-code-stub-assembler.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/cctest/test-debug-helper.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/cctest/test-icache.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/fuzzer/fuzzer-support.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/mjsunit/mjsunit.status
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/unittests/BUILD.gn
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/unittests/api/access-check-unittest.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/unittests/numbers/conversions-unittest.cc
[rename] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/unittests/objects/backing-store-unittest.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/unittests/objects/value-serializer-unittest.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/wasm-api-tests/wasm-api-tests.status
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/tools/v8heapconst.py
Change-Id: I93672002c1faa36bb0bb5b4a9cc2032ee2ccd814
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2752866
Auto-Submit: Clemens Backes <clem...@chromium.org>
Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#73346}
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/BUILD.gn
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/api/api-inl.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/api/api.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/builtins/accessors.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/builtins/arm/builtins-arm.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/builtins/builtins-array.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/builtins/builtins-callsite.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/builtins/builtins-definitions.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/builtins/builtins-iterator-gen.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/builtins/builtins-typed-array-gen.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/builtins/builtins.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/builtins/ia32/builtins-ia32.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/builtins/x64/builtins-x64.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/codegen/arm/macro-assembler-arm.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/codegen/arm64/macro-assembler-arm64.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/codegen/compiler.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/codegen/external-reference.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/codegen/external-reference.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/codegen/handler-table.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/codegen/handler-table.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/codegen/optimized-compilation-info.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/codegen/optimized-compilation-info.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/codegen/safepoint-table.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/codegen/safepoint-table.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/common/globals.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/backend/arm/code-generator-arm.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/backend/arm64/instruction-selector-arm64.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/backend/code-generator.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/backend/ia32/instruction-selector-ia32.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/backend/instruction-selector.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/backend/instruction-selector.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/backend/x64/code-generator-x64.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/backend/x64/instruction-selector-x64.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/csa-load-elimination.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/frame-states.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/frame-states.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/js-generic-lowering.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/js-inlining-heuristic.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/js-inlining.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/js-operator.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/js-operator.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/linkage.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/linkage.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/opcodes.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/operator-properties.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/pipeline.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/simplified-lowering.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/typer.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/verifier.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/compiler/wasm-compiler.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/d8/d8.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/debug/debug-frames.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/debug/debug-frames.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/debug/debug-stack-trace-iterator.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/debug/debug.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/diagnostics/objects-debug.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/diagnostics/objects-printer.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/execution/execution.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/execution/execution.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/execution/frame-constants.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/execution/frames-inl.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/execution/frames.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/execution/frames.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/execution/isolate-inl.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/execution/isolate.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/execution/isolate.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/execution/messages.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/execution/stack-guard.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/heap/concurrent-marking.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/heap/factory.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/heap/factory.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/heap/mark-compact.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/heap/memory-measurement.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/heap/objects-visiting-inl.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/heap/objects-visiting.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/heap/scavenger.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/heap/setup-heap-internal.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/ic/ic.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/backing-store.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/backing-store.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/js-function-inl.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/js-function.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/js-objects.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/map-inl.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/map.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/map.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/object-list-macros.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/objects-body-descriptors-inl.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/objects-definitions.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/objects-inl.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/objects.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/shared-function-info-inl.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/shared-function-info.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/shared-function-info.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/stack-frame-info-inl.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/stack-frame-info.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/stack-frame-info.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/value-serializer.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/objects/value-serializer.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/parsing/parse-info.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/profiler/heap-profiler.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/regexp/regexp.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/roots/roots.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/runtime/runtime-compiler.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/runtime/runtime-debug.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/runtime/runtime-test.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/runtime/runtime.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/runtime/runtime.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/snapshot/code-serializer.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/snapshot/context-deserializer.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/snapshot/object-deserializer.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/snapshot/snapshot.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/src/wasm/value-type.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/cctest/cctest.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/cctest/compiler/node-observer-tester.h
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/cctest/compiler/test-code-generator.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/cctest/compiler/test-concurrent-shared-function-info.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/cctest/compiler/test-linkage.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/cctest/compiler/test-run-calls-to-external-references.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/cctest/compiler/test-sloppy-equality.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/cctest/heap/test-write-barrier.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/cctest/test-api-array-buffer.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/cctest/test-api-typed-array.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/cctest/test-api.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/cctest/test-code-stub-assembler.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/cctest/test-debug-helper.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/cctest/test-icache.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/fuzzer/fuzzer-support.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/mjsunit/mjsunit.status
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/unittests/BUILD.gn
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/unittests/api/access-check-unittest.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/unittests/numbers/conversions-unittest.cc
[rename] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/unittests/objects/backing-store-unittest.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/unittests/objects/value-serializer-unittest.cc
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/test/wasm-api-tests/wasm-api-tests.status
[modify] https://crrev.com/92bc3d386182446796c5905d78b652330c8522f2/tools/v8heapconst.py
Git Watcher via monorail
Mar 11, 2021, 9:30:12 AM3/11/21
to v8-re...@googlegroups.com
Comment #29 on issue 11238 by Git Watcher: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c29
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/3f9ff062b053155df7897f199e80a8bafe7c34df
commit 3f9ff062b053155df7897f199e80a8bafe7c34df
Author: Clemens Backes <clem...@chromium.org>
Date: Thu Mar 11 13:42:01 2021
Reland "[no-wasm] Exclude src/wasm from compilation"
This is a reland of 80f5dfda0147d6b078ae6c9d0eb947bd012bf72d. A condition
in pipeline.cc was inverted, which lead to a CSA verifier error.
commit 3f9ff062b053155df7897f199e80a8bafe7c34df
Author: Clemens Backes <clem...@chromium.org>
Date: Thu Mar 11 13:42:01 2021
Reland "[no-wasm] Exclude src/wasm from compilation"
This is a reland of 80f5dfda0147d6b078ae6c9d0eb947bd012bf72d. A condition
in pipeline.cc was inverted, which lead to a CSA verifier error.
TBR=jgr...@chromium.org
Bug: v8:11238
Change-Id: I20bd2847a59c68738b5a336cd42582b7b1499585
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Cq-Include-Trybots: luci.v8.try:v8_linux_verify_csa_rel_ng
Cq-Include-Trybots: luci.v8.try:v8_linux64_verify_csa_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2752867
Reviewed-by: Clemens Backes <clem...@chromium.org>
Bug: v8:11238
Change-Id: I20bd2847a59c68738b5a336cd42582b7b1499585
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Cq-Include-Trybots: luci.v8.try:v8_linux_verify_csa_rel_ng
Cq-Include-Trybots: luci.v8.try:v8_linux64_verify_csa_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2752867
Reviewed-by: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73348}
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/BUILD.gn
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/api/api-inl.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/api/api.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/builtins/accessors.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/builtins/arm/builtins-arm.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/builtins/builtins-array.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/builtins/builtins-callsite.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/builtins/builtins-definitions.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/builtins/builtins-iterator-gen.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/builtins/builtins-typed-array-gen.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/builtins/builtins.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/builtins/ia32/builtins-ia32.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/builtins/x64/builtins-x64.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/codegen/arm/macro-assembler-arm.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/codegen/arm64/macro-assembler-arm64.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/codegen/compiler.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/codegen/external-reference.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/codegen/external-reference.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/codegen/handler-table.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/codegen/handler-table.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/codegen/optimized-compilation-info.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/codegen/optimized-compilation-info.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/codegen/safepoint-table.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/codegen/safepoint-table.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/common/globals.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/backend/arm/code-generator-arm.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/backend/arm64/instruction-selector-arm64.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/backend/code-generator.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/backend/ia32/instruction-selector-ia32.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/backend/instruction-selector.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/backend/instruction-selector.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/backend/x64/code-generator-x64.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/backend/x64/instruction-selector-x64.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/csa-load-elimination.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/frame-states.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/frame-states.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/js-generic-lowering.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/js-inlining-heuristic.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/js-inlining.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/js-operator.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/js-operator.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/linkage.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/linkage.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/opcodes.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/operator-properties.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/pipeline.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/simplified-lowering.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/typer.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/verifier.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/wasm-compiler.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/d8/d8.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/debug/debug-frames.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/debug/debug-frames.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/debug/debug-stack-trace-iterator.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/debug/debug.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/diagnostics/objects-debug.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/diagnostics/objects-printer.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/execution/execution.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/execution/execution.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/execution/frame-constants.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/execution/frames-inl.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/execution/frames.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/execution/frames.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/execution/isolate-inl.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/execution/isolate.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/execution/isolate.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/execution/messages.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/execution/stack-guard.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/heap/concurrent-marking.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/heap/factory.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/heap/factory.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/heap/mark-compact.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/heap/memory-measurement.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/heap/objects-visiting-inl.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/heap/objects-visiting.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/heap/scavenger.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/heap/setup-heap-internal.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/ic/ic.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/backing-store.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/backing-store.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/js-function-inl.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/js-function.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/js-objects.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/map-inl.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/map.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/map.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/object-list-macros.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/objects-body-descriptors-inl.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/objects-definitions.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/objects-inl.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/objects.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/shared-function-info-inl.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/shared-function-info.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/shared-function-info.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/stack-frame-info-inl.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/stack-frame-info.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/stack-frame-info.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/value-serializer.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/value-serializer.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/parsing/parse-info.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/profiler/heap-profiler.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/regexp/regexp.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/roots/roots.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/runtime/runtime-compiler.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/runtime/runtime-debug.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/runtime/runtime-test.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/runtime/runtime.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/runtime/runtime.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/snapshot/code-serializer.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/snapshot/context-deserializer.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/snapshot/object-deserializer.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/snapshot/snapshot.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/wasm/value-type.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/cctest/cctest.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/cctest/compiler/node-observer-tester.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/cctest/compiler/test-code-generator.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/cctest/compiler/test-concurrent-shared-function-info.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/cctest/compiler/test-linkage.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/cctest/compiler/test-run-calls-to-external-references.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/cctest/compiler/test-sloppy-equality.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/cctest/heap/test-write-barrier.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/cctest/test-api-array-buffer.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/cctest/test-api-typed-array.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/cctest/test-api.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/cctest/test-code-stub-assembler.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/cctest/test-debug-helper.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/cctest/test-icache.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/fuzzer/fuzzer-support.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/mjsunit/mjsunit.status
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/unittests/BUILD.gn
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/unittests/api/access-check-unittest.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/unittests/numbers/conversions-unittest.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/unittests/objects/value-serializer-unittest.cc
[rename] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/unittests/objects/wasm-backing-store-unittest.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/wasm-api-tests/wasm-api-tests.status
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/tools/v8heapconst.py
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/BUILD.gn
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/api/api-inl.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/api/api.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/builtins/accessors.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/builtins/arm/builtins-arm.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/builtins/builtins-array.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/builtins/builtins-callsite.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/builtins/builtins-definitions.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/builtins/builtins-iterator-gen.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/builtins/builtins-typed-array-gen.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/builtins/builtins.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/builtins/ia32/builtins-ia32.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/builtins/x64/builtins-x64.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/codegen/arm/macro-assembler-arm.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/codegen/arm64/macro-assembler-arm64.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/codegen/compiler.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/codegen/external-reference.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/codegen/external-reference.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/codegen/handler-table.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/codegen/handler-table.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/codegen/optimized-compilation-info.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/codegen/optimized-compilation-info.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/codegen/safepoint-table.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/codegen/safepoint-table.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/common/globals.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/backend/arm/code-generator-arm.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/backend/arm64/instruction-selector-arm64.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/backend/code-generator.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/backend/ia32/instruction-selector-ia32.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/backend/instruction-selector.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/backend/instruction-selector.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/backend/x64/code-generator-x64.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/backend/x64/instruction-selector-x64.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/csa-load-elimination.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/frame-states.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/frame-states.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/js-generic-lowering.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/js-inlining-heuristic.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/js-inlining.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/js-operator.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/js-operator.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/linkage.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/linkage.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/opcodes.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/operator-properties.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/pipeline.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/simplified-lowering.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/typer.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/verifier.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/compiler/wasm-compiler.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/d8/d8.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/debug/debug-frames.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/debug/debug-frames.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/debug/debug-stack-trace-iterator.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/debug/debug.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/diagnostics/objects-debug.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/diagnostics/objects-printer.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/execution/execution.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/execution/execution.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/execution/frame-constants.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/execution/frames-inl.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/execution/frames.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/execution/frames.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/execution/isolate-inl.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/execution/isolate.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/execution/isolate.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/execution/messages.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/execution/stack-guard.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/heap/concurrent-marking.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/heap/factory.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/heap/factory.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/heap/mark-compact.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/heap/memory-measurement.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/heap/objects-visiting-inl.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/heap/objects-visiting.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/heap/scavenger.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/heap/setup-heap-internal.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/ic/ic.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/backing-store.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/backing-store.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/js-function-inl.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/js-function.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/js-objects.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/map-inl.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/map.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/map.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/object-list-macros.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/objects-body-descriptors-inl.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/objects-definitions.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/objects-inl.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/objects.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/shared-function-info-inl.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/shared-function-info.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/shared-function-info.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/stack-frame-info-inl.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/stack-frame-info.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/stack-frame-info.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/value-serializer.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/objects/value-serializer.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/parsing/parse-info.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/profiler/heap-profiler.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/regexp/regexp.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/roots/roots.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/runtime/runtime-compiler.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/runtime/runtime-debug.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/runtime/runtime-test.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/runtime/runtime.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/runtime/runtime.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/snapshot/code-serializer.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/snapshot/context-deserializer.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/snapshot/object-deserializer.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/snapshot/snapshot.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/src/wasm/value-type.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/cctest/cctest.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/cctest/compiler/node-observer-tester.h
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/cctest/compiler/test-code-generator.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/cctest/compiler/test-concurrent-shared-function-info.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/cctest/compiler/test-linkage.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/cctest/compiler/test-run-calls-to-external-references.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/cctest/compiler/test-sloppy-equality.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/cctest/heap/test-write-barrier.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/cctest/test-api-array-buffer.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/cctest/test-api-typed-array.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/cctest/test-api.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/cctest/test-code-stub-assembler.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/cctest/test-debug-helper.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/cctest/test-icache.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/fuzzer/fuzzer-support.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/mjsunit/mjsunit.status
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/unittests/BUILD.gn
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/unittests/api/access-check-unittest.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/unittests/numbers/conversions-unittest.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/unittests/objects/value-serializer-unittest.cc
[rename] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/unittests/objects/wasm-backing-store-unittest.cc
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/test/wasm-api-tests/wasm-api-tests.status
[modify] https://crrev.com/3f9ff062b053155df7897f199e80a8bafe7c34df/tools/v8heapconst.py
Git Watcher via monorail
Mar 11, 2021, 4:16:10 PM3/11/21
to v8-re...@googlegroups.com
Comment #30 on issue 11238 by Git Watcher: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c30
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/8224bdf41cc439cdc2da68602c320f70bf6ffb4b
commit 8224bdf41cc439cdc2da68602c320f70bf6ffb4b
Author: Milad Fa <mfar...@redhat.com>
Date: Thu Mar 11 19:27:12 2021
PPC/s390: Reland "[no-wasm] Exclude src/wasm from compilation"
Port 3f9ff062b053155df7897f199e80a8bafe7c34df
Original Commit Message:
commit 8224bdf41cc439cdc2da68602c320f70bf6ffb4b
Author: Milad Fa <mfar...@redhat.com>
Date: Thu Mar 11 19:27:12 2021
PPC/s390: Reland "[no-wasm] Exclude src/wasm from compilation"
Port 3f9ff062b053155df7897f199e80a8bafe7c34df
Original Commit Message:
R=clem...@chromium.org, jora...@ca.ibm.com, jun...@redhat.com, mida...@redhat.com
BUG=
LOG=N
Change-Id: I006f32407aea051c960f32942f9353f415547116
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2753143
Reviewed-by: Junliang Yan <jun...@redhat.com>
Commit-Queue: Milad Fa <mfar...@redhat.com>
Cr-Commit-Position: refs/heads/master@{#73357}
[modify] https://crrev.com/8224bdf41cc439cdc2da68602c320f70bf6ffb4b/src/builtins/ppc/builtins-ppc.cc
[modify] https://crrev.com/8224bdf41cc439cdc2da68602c320f70bf6ffb4b/src/builtins/s390/builtins-s390.cc
[modify] https://crrev.com/8224bdf41cc439cdc2da68602c320f70bf6ffb4b/src/codegen/ppc/macro-assembler-ppc.cc
[modify] https://crrev.com/8224bdf41cc439cdc2da68602c320f70bf6ffb4b/src/codegen/s390/macro-assembler-s390.cc
[modify] https://crrev.com/8224bdf41cc439cdc2da68602c320f70bf6ffb4b/src/compiler/backend/ppc/code-generator-ppc.cc
[modify] https://crrev.com/8224bdf41cc439cdc2da68602c320f70bf6ffb4b/src/compiler/backend/s390/code-generator-s390.cc
BUG=
LOG=N
Change-Id: I006f32407aea051c960f32942f9353f415547116
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2753143
Reviewed-by: Junliang Yan <jun...@redhat.com>
Commit-Queue: Milad Fa <mfar...@redhat.com>
Cr-Commit-Position: refs/heads/master@{#73357}
[modify] https://crrev.com/8224bdf41cc439cdc2da68602c320f70bf6ffb4b/src/builtins/ppc/builtins-ppc.cc
[modify] https://crrev.com/8224bdf41cc439cdc2da68602c320f70bf6ffb4b/src/builtins/s390/builtins-s390.cc
[modify] https://crrev.com/8224bdf41cc439cdc2da68602c320f70bf6ffb4b/src/codegen/ppc/macro-assembler-ppc.cc
[modify] https://crrev.com/8224bdf41cc439cdc2da68602c320f70bf6ffb4b/src/codegen/s390/macro-assembler-s390.cc
[modify] https://crrev.com/8224bdf41cc439cdc2da68602c320f70bf6ffb4b/src/compiler/backend/ppc/code-generator-ppc.cc
[modify] https://crrev.com/8224bdf41cc439cdc2da68602c320f70bf6ffb4b/src/compiler/backend/s390/code-generator-s390.cc
Git Watcher via monorail
Mar 12, 2021, 2:18:06 PM3/12/21
to v8-re...@googlegroups.com
Comment #31 on issue 11238 by Git Watcher: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c31
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/7e8df34eb572835b445f553861bad9d1b6b7879c
commit 7e8df34eb572835b445f553861bad9d1b6b7879c
Author: Clemens Backes <clem...@chromium.org>
Date: Fri Mar 12 14:34:27 2021
[no-wasm] Group wasm test functions in a separate macro list
A little cleanup after https://crrev.com/c/2752867.
R=jkum...@chromium.org
Bug: v8:11238
Change-Id: I6e8b29c852ce6f8267f4b2fb4afe404659503a64
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756527
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73380}
[modify] https://crrev.com/7e8df34eb572835b445f553861bad9d1b6b7879c/src/runtime/runtime.h
commit 7e8df34eb572835b445f553861bad9d1b6b7879c
Author: Clemens Backes <clem...@chromium.org>
Date: Fri Mar 12 14:34:27 2021
[no-wasm] Group wasm test functions in a separate macro list
A little cleanup after https://crrev.com/c/2752867.
R=jkum...@chromium.org
Bug: v8:11238
Change-Id: I6e8b29c852ce6f8267f4b2fb4afe404659503a64
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756527
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73380}
[modify] https://crrev.com/7e8df34eb572835b445f553861bad9d1b6b7879c/src/runtime/runtime.h
Git Watcher via monorail
Mar 15, 2021, 12:16:07 PM3/15/21
to v8-re...@googlegroups.com
Comment #32 on issue 11238 by Git Watcher: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c32
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/3c702243d2b7a33b953037d9fbed26e2dad0a398
commit 3c702243d2b7a33b953037d9fbed26e2dad0a398
Author: Clemens Backes <clem...@chromium.org>
Date: Fri Mar 12 19:20:08 2021
[no-wasm][parsing] Remove asm detection
asm validation and translation to wasm is disabled in no-wasm builds,
hence remove respective detection and marking of scopes and functions.
R=verw...@chromium.org
Bug: v8:11238
Change-Id: I2ac8a84024fa37a0c5896a0f85ea4beea4d93137
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757689
Reviewed-by: Toon Verwaest <verw...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73410}
[modify] https://crrev.com/3c702243d2b7a33b953037d9fbed26e2dad0a398/src/ast/scopes.cc
[modify] https://crrev.com/3c702243d2b7a33b953037d9fbed26e2dad0a398/src/ast/scopes.h
[modify] https://crrev.com/3c702243d2b7a33b953037d9fbed26e2dad0a398/src/objects/scope-info.cc
[modify] https://crrev.com/3c702243d2b7a33b953037d9fbed26e2dad0a398/src/parsing/parse-info.cc
[modify] https://crrev.com/3c702243d2b7a33b953037d9fbed26e2dad0a398/src/parsing/parse-info.h
[modify] https://crrev.com/3c702243d2b7a33b953037d9fbed26e2dad0a398/src/parsing/parser-base.h
[modify] https://crrev.com/3c702243d2b7a33b953037d9fbed26e2dad0a398/src/parsing/parser.cc
[modify] https://crrev.com/3c702243d2b7a33b953037d9fbed26e2dad0a398/src/parsing/parser.h
[modify] https://crrev.com/3c702243d2b7a33b953037d9fbed26e2dad0a398/test/cctest/test-parsing.cc
commit 3c702243d2b7a33b953037d9fbed26e2dad0a398
Author: Clemens Backes <clem...@chromium.org>
Date: Fri Mar 12 19:20:08 2021
[no-wasm][parsing] Remove asm detection
asm validation and translation to wasm is disabled in no-wasm builds,
hence remove respective detection and marking of scopes and functions.
R=verw...@chromium.org
Bug: v8:11238
Change-Id: I2ac8a84024fa37a0c5896a0f85ea4beea4d93137
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757689
Reviewed-by: Toon Verwaest <verw...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73410}
[modify] https://crrev.com/3c702243d2b7a33b953037d9fbed26e2dad0a398/src/ast/scopes.cc
[modify] https://crrev.com/3c702243d2b7a33b953037d9fbed26e2dad0a398/src/ast/scopes.h
[modify] https://crrev.com/3c702243d2b7a33b953037d9fbed26e2dad0a398/src/objects/scope-info.cc
[modify] https://crrev.com/3c702243d2b7a33b953037d9fbed26e2dad0a398/src/parsing/parse-info.cc
[modify] https://crrev.com/3c702243d2b7a33b953037d9fbed26e2dad0a398/src/parsing/parse-info.h
[modify] https://crrev.com/3c702243d2b7a33b953037d9fbed26e2dad0a398/src/parsing/parser-base.h
[modify] https://crrev.com/3c702243d2b7a33b953037d9fbed26e2dad0a398/src/parsing/parser.cc
[modify] https://crrev.com/3c702243d2b7a33b953037d9fbed26e2dad0a398/src/parsing/parser.h
[modify] https://crrev.com/3c702243d2b7a33b953037d9fbed26e2dad0a398/test/cctest/test-parsing.cc
Git Watcher via monorail
Mar 16, 2021, 3:18:05 AM3/16/21
to v8-re...@googlegroups.com
Comment #33 on issue 11238 by Git Watcher: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c33
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/93288524ee093fe0c79bca6f956c072dfbc9bc6e
commit 93288524ee093fe0c79bca6f956c072dfbc9bc6e
Author: Clemens Backes <clem...@chromium.org>
Date: Mon Mar 15 13:28:34 2021
[no-wasm] Remove wasm information from Script
This removes the TYPE_WASM script type, and all fields on Script that
are only needed for WebAssembly.
R=jgr...@chromium.org
Bug: v8:11238
Change-Id: I233bfd3dec9b389bc74d926670310fd175c0c6d8
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757690
Reviewed-by: Jakob Gruber <jgr...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73418}
[modify] https://crrev.com/93288524ee093fe0c79bca6f956c072dfbc9bc6e/src/api/api.cc
[modify] https://crrev.com/93288524ee093fe0c79bca6f956c072dfbc9bc6e/src/debug/debug-interface.cc
[modify] https://crrev.com/93288524ee093fe0c79bca6f956c072dfbc9bc6e/src/debug/debug-interface.h
[modify] https://crrev.com/93288524ee093fe0c79bca6f956c072dfbc9bc6e/src/debug/debug-scopes.cc
[modify] https://crrev.com/93288524ee093fe0c79bca6f956c072dfbc9bc6e/src/debug/debug.cc
[modify] https://crrev.com/93288524ee093fe0c79bca6f956c072dfbc9bc6e/src/diagnostics/objects-printer.cc
[modify] https://crrev.com/93288524ee093fe0c79bca6f956c072dfbc9bc6e/src/objects/js-objects.cc
[modify] https://crrev.com/93288524ee093fe0c79bca6f956c072dfbc9bc6e/src/objects/objects.cc
[modify] https://crrev.com/93288524ee093fe0c79bca6f956c072dfbc9bc6e/src/objects/script-inl.h
[modify] https://crrev.com/93288524ee093fe0c79bca6f956c072dfbc9bc6e/src/objects/script.h
[modify] https://crrev.com/93288524ee093fe0c79bca6f956c072dfbc9bc6e/src/runtime/runtime-debug.cc
[modify] https://crrev.com/93288524ee093fe0c79bca6f956c072dfbc9bc6e/src/snapshot/code-serializer.cc
[modify] https://crrev.com/93288524ee093fe0c79bca6f956c072dfbc9bc6e/test/cctest/test-debug.cc
commit 93288524ee093fe0c79bca6f956c072dfbc9bc6e
Author: Clemens Backes <clem...@chromium.org>
Date: Mon Mar 15 13:28:34 2021
[no-wasm] Remove wasm information from Script
This removes the TYPE_WASM script type, and all fields on Script that
are only needed for WebAssembly.
R=jgr...@chromium.org
Bug: v8:11238
Change-Id: I233bfd3dec9b389bc74d926670310fd175c0c6d8
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757690
Reviewed-by: Jakob Gruber <jgr...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73418}
[modify] https://crrev.com/93288524ee093fe0c79bca6f956c072dfbc9bc6e/src/api/api.cc
[modify] https://crrev.com/93288524ee093fe0c79bca6f956c072dfbc9bc6e/src/debug/debug-interface.cc
[modify] https://crrev.com/93288524ee093fe0c79bca6f956c072dfbc9bc6e/src/debug/debug-interface.h
[modify] https://crrev.com/93288524ee093fe0c79bca6f956c072dfbc9bc6e/src/debug/debug-scopes.cc
[modify] https://crrev.com/93288524ee093fe0c79bca6f956c072dfbc9bc6e/src/debug/debug.cc
[modify] https://crrev.com/93288524ee093fe0c79bca6f956c072dfbc9bc6e/src/diagnostics/objects-printer.cc
[modify] https://crrev.com/93288524ee093fe0c79bca6f956c072dfbc9bc6e/src/objects/js-objects.cc
[modify] https://crrev.com/93288524ee093fe0c79bca6f956c072dfbc9bc6e/src/objects/objects.cc
[modify] https://crrev.com/93288524ee093fe0c79bca6f956c072dfbc9bc6e/src/objects/script-inl.h
[modify] https://crrev.com/93288524ee093fe0c79bca6f956c072dfbc9bc6e/src/objects/script.h
[modify] https://crrev.com/93288524ee093fe0c79bca6f956c072dfbc9bc6e/src/runtime/runtime-debug.cc
[modify] https://crrev.com/93288524ee093fe0c79bca6f956c072dfbc9bc6e/src/snapshot/code-serializer.cc
[modify] https://crrev.com/93288524ee093fe0c79bca6f956c072dfbc9bc6e/test/cctest/test-debug.cc
Git Watcher via monorail
Mar 16, 2021, 3:32:06 AM3/16/21
to v8-re...@googlegroups.com
Comment #34 on issue 11238 by Git Watcher: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c34
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/05265d882405b8fbf4b7b5189e43c934829a1686
commit 05265d882405b8fbf4b7b5189e43c934829a1686
Author: Clemens Backes <clem...@chromium.org>
Date: Mon Mar 15 13:20:04 2021
[no-wasm][flags] Remove wasm flags
This removes all wasm-related flags in no-wasm builds.
We could have made them read-only, but fully removing them actually
forces us to consider the no-wasm case at every use site, which often
hints at further cleanups.
R=jkum...@chromium.org
Bug: v8:11238
Change-Id: Ic140031a2732975b2a46116a58e26fe49f1f7c8c
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2759518
Commit-Queue: Clemens Backes <clem...@chromium.org>
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Reviewed-by: Andreas Haas <ah...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73420}
[modify] https://crrev.com/05265d882405b8fbf4b7b5189e43c934829a1686/src/api/api.cc
[modify] https://crrev.com/05265d882405b8fbf4b7b5189e43c934829a1686/src/codegen/ia32/assembler-ia32.cc
[modify] https://crrev.com/05265d882405b8fbf4b7b5189e43c934829a1686/src/codegen/x64/assembler-x64.cc
[modify] https://crrev.com/05265d882405b8fbf4b7b5189e43c934829a1686/src/execution/isolate.cc
[modify] https://crrev.com/05265d882405b8fbf4b7b5189e43c934829a1686/src/flags/flag-definitions.h
[modify] https://crrev.com/05265d882405b8fbf4b7b5189e43c934829a1686/src/flags/flags.cc
[modify] https://crrev.com/05265d882405b8fbf4b7b5189e43c934829a1686/src/flags/flags.h
[modify] https://crrev.com/05265d882405b8fbf4b7b5189e43c934829a1686/src/init/v8.cc
[modify] https://crrev.com/05265d882405b8fbf4b7b5189e43c934829a1686/test/cctest/test-flags.cc
commit 05265d882405b8fbf4b7b5189e43c934829a1686
Author: Clemens Backes <clem...@chromium.org>
Date: Mon Mar 15 13:20:04 2021
[no-wasm][flags] Remove wasm flags
This removes all wasm-related flags in no-wasm builds.
We could have made them read-only, but fully removing them actually
forces us to consider the no-wasm case at every use site, which often
hints at further cleanups.
R=jkum...@chromium.org
Bug: v8:11238
Change-Id: Ic140031a2732975b2a46116a58e26fe49f1f7c8c
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2759518
Commit-Queue: Clemens Backes <clem...@chromium.org>
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Reviewed-by: Andreas Haas <ah...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73420}
[modify] https://crrev.com/05265d882405b8fbf4b7b5189e43c934829a1686/src/api/api.cc
[modify] https://crrev.com/05265d882405b8fbf4b7b5189e43c934829a1686/src/codegen/ia32/assembler-ia32.cc
[modify] https://crrev.com/05265d882405b8fbf4b7b5189e43c934829a1686/src/codegen/x64/assembler-x64.cc
[modify] https://crrev.com/05265d882405b8fbf4b7b5189e43c934829a1686/src/execution/isolate.cc
[modify] https://crrev.com/05265d882405b8fbf4b7b5189e43c934829a1686/src/flags/flag-definitions.h
[modify] https://crrev.com/05265d882405b8fbf4b7b5189e43c934829a1686/src/flags/flags.cc
[modify] https://crrev.com/05265d882405b8fbf4b7b5189e43c934829a1686/src/flags/flags.h
[modify] https://crrev.com/05265d882405b8fbf4b7b5189e43c934829a1686/src/init/v8.cc
[modify] https://crrev.com/05265d882405b8fbf4b7b5189e43c934829a1686/test/cctest/test-flags.cc
Git Watcher via monorail
Mar 16, 2021, 4:49:05 AM3/16/21
to v8-re...@googlegroups.com
Comment #35 on issue 11238 by Git Watcher: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c35
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/629db0a6cd70756b81f51d9541433cdbb862acc4
commit 629db0a6cd70756b81f51d9541433cdbb862acc4
Author: Clemens Backes <clem...@chromium.org>
Date: Fri Mar 12 15:28:57 2021
[no-wasm] Forbid including wasm headers in no-wasm builds
This will make accidental includes much easier to see and fix. Without
this, you might get compiler or linker errors instead.
commit 629db0a6cd70756b81f51d9541433cdbb862acc4
Author: Clemens Backes <clem...@chromium.org>
Date: Fri Mar 12 15:28:57 2021
[no-wasm] Forbid including wasm headers in no-wasm builds
This will make accidental includes much easier to see and fix. Without
this, you might get compiler or linker errors instead.
Change-Id: I235d779f9c1ed3af5d736f1554ded427935ddc9b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756531
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756531
Commit-Queue: Clemens Backes <clem...@chromium.org>
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73422}
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/c-api.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/code-space-access.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/compilation-environment.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/decoder.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/function-body-decoder-impl.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/function-body-decoder.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/function-compiler.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/graph-builder-interface.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/jump-table-assembler.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/leb-helper.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/local-decl-encoder.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/memory-tracing.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/module-compiler.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/module-decoder.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/module-instantiate.cc
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/module-instantiate.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/object-access.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/signature-map.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/simd-shuffle.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/streaming-decoder.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/struct-types.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/value-type.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-arguments.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-code-manager.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-constants.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-debug.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-engine.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-external-refs.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-feature-flags.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-features.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-import-wrapper-cache.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-js.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-limits.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-linkage.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-module-builder.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-module-sourcemap.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-module.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-objects-inl.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-objects.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-opcodes-inl.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-opcodes.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-result.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-serialization.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-subtyping.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-tier.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-value.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/c-api.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/code-space-access.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/compilation-environment.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/decoder.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/function-body-decoder-impl.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/function-body-decoder.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/function-compiler.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/graph-builder-interface.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/jump-table-assembler.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/leb-helper.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/local-decl-encoder.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/memory-tracing.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/module-compiler.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/module-decoder.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/module-instantiate.cc
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/module-instantiate.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/object-access.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/signature-map.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/simd-shuffle.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/streaming-decoder.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/struct-types.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/value-type.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-arguments.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-code-manager.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-constants.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-debug.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-engine.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-external-refs.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-feature-flags.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-features.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-import-wrapper-cache.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-js.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-limits.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-linkage.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-module-builder.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-module-sourcemap.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-module.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-objects-inl.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-objects.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-opcodes-inl.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-opcodes.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-result.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-serialization.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-subtyping.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-tier.h
[modify] https://crrev.com/629db0a6cd70756b81f51d9541433cdbb862acc4/src/wasm/wasm-value.h
Git Watcher via monorail
Mar 17, 2021, 6:08:06 AM3/17/21
to v8-re...@googlegroups.com
Comment #36 on issue 11238 by Git Watcher: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c36
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/2c9ea6d1c9cc5da277959a05a719d459bded0914
commit 2c9ea6d1c9cc5da277959a05a719d459bded0914
Author: Liu Yu <li...@loongson.cn>
Date: Wed Mar 17 01:05:16 2021
[mips][no-wasm] Exclude src/wasm from compilation
Port: 3f9ff062b053155df7897f199e80a8bafe7c34df
Bug: v8:11238
Change-Id: I3ac454b7ea1addbbf41407c7acd6a18da7b35d10
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2763965
Auto-Submit: Liu yu <li...@loongson.cn>
Reviewed-by: Zhao Jiazhong <zhaojia...@loongson.cn>
Reviewed-by: Clemens Backes <clem...@chromium.org>
Reviewed-by: Jakob Gruber <jgr...@chromium.org>
Commit-Queue: Jakob Gruber <jgr...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73457}
[modify] https://crrev.com/2c9ea6d1c9cc5da277959a05a719d459bded0914/src/builtins/mips/builtins-mips.cc
[modify] https://crrev.com/2c9ea6d1c9cc5da277959a05a719d459bded0914/src/builtins/mips64/builtins-mips64.cc
[modify] https://crrev.com/2c9ea6d1c9cc5da277959a05a719d459bded0914/src/codegen/mips/macro-assembler-mips.cc
[modify] https://crrev.com/2c9ea6d1c9cc5da277959a05a719d459bded0914/src/codegen/mips64/macro-assembler-mips64.cc
[modify] https://crrev.com/2c9ea6d1c9cc5da277959a05a719d459bded0914/src/compiler/backend/mips/code-generator-mips.cc
[modify] https://crrev.com/2c9ea6d1c9cc5da277959a05a719d459bded0914/src/compiler/backend/mips64/code-generator-mips64.cc
commit 2c9ea6d1c9cc5da277959a05a719d459bded0914
Author: Liu Yu <li...@loongson.cn>
Date: Wed Mar 17 01:05:16 2021
[mips][no-wasm] Exclude src/wasm from compilation
Port: 3f9ff062b053155df7897f199e80a8bafe7c34df
Bug: v8:11238
Change-Id: I3ac454b7ea1addbbf41407c7acd6a18da7b35d10
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2763965
Auto-Submit: Liu yu <li...@loongson.cn>
Reviewed-by: Zhao Jiazhong <zhaojia...@loongson.cn>
Reviewed-by: Clemens Backes <clem...@chromium.org>
Reviewed-by: Jakob Gruber <jgr...@chromium.org>
Commit-Queue: Jakob Gruber <jgr...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73457}
[modify] https://crrev.com/2c9ea6d1c9cc5da277959a05a719d459bded0914/src/builtins/mips/builtins-mips.cc
[modify] https://crrev.com/2c9ea6d1c9cc5da277959a05a719d459bded0914/src/builtins/mips64/builtins-mips64.cc
[modify] https://crrev.com/2c9ea6d1c9cc5da277959a05a719d459bded0914/src/codegen/mips/macro-assembler-mips.cc
[modify] https://crrev.com/2c9ea6d1c9cc5da277959a05a719d459bded0914/src/codegen/mips64/macro-assembler-mips64.cc
[modify] https://crrev.com/2c9ea6d1c9cc5da277959a05a719d459bded0914/src/compiler/backend/mips/code-generator-mips.cc
[modify] https://crrev.com/2c9ea6d1c9cc5da277959a05a719d459bded0914/src/compiler/backend/mips64/code-generator-mips64.cc
Git Watcher via monorail
Mar 17, 2021, 1:59:08 PM3/17/21
to v8-re...@googlegroups.com
Comment #37 on issue 11238 by Git Watcher: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c37
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/5bf07566ce51808baca7e2bd1b30b12a07555cda
commit 5bf07566ce51808baca7e2bd1b30b12a07555cda
Author: Ng Zhi An <zh...@chromium.org>
Date: Wed Mar 17 16:55:35 2021
[wasm] Move asm regress tests into regress/asm
These tests require --validate-asm, which is available only on
WebAssembly enabled builds. This was causing problems
on https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20arm%20-%20sim%20-%20lite/15320/overview.
Moving them into regress/asm, the status file automatically skips these
tests if WebAssembly is not enabled.
Bug: v8:11238
Change-Id: Ib337fb6bd43319f61a33302efd4277c092935a9c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767600
Commit-Queue: Zhi An Ng <zh...@chromium.org>
Reviewed-by: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73489}
[rename] https://crrev.com/5bf07566ce51808baca7e2bd1b30b12a07555cda/test/mjsunit/regress/asm/regress-673297.js
[rename] https://crrev.com/5bf07566ce51808baca7e2bd1b30b12a07555cda/test/mjsunit/regress/asm/regress-743622.js
[delete] https://crrev.com/f531603290c46fd8182b2d7c8ce3d1336380b5de/test/mjsunit/regress/regress-673241.js
commit 5bf07566ce51808baca7e2bd1b30b12a07555cda
Author: Ng Zhi An <zh...@chromium.org>
Date: Wed Mar 17 16:55:35 2021
[wasm] Move asm regress tests into regress/asm
These tests require --validate-asm, which is available only on
WebAssembly enabled builds. This was causing problems
on https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20arm%20-%20sim%20-%20lite/15320/overview.
Moving them into regress/asm, the status file automatically skips these
tests if WebAssembly is not enabled.
Bug: v8:11238
Change-Id: Ib337fb6bd43319f61a33302efd4277c092935a9c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767600
Commit-Queue: Zhi An Ng <zh...@chromium.org>
Reviewed-by: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73489}
[rename] https://crrev.com/5bf07566ce51808baca7e2bd1b30b12a07555cda/test/mjsunit/regress/asm/regress-673297.js
[rename] https://crrev.com/5bf07566ce51808baca7e2bd1b30b12a07555cda/test/mjsunit/regress/asm/regress-743622.js
[delete] https://crrev.com/f531603290c46fd8182b2d7c8ce3d1336380b5de/test/mjsunit/regress/regress-673241.js
Git Watcher via monorail
Mar 18, 2021, 12:15:15 PM3/18/21
to v8-re...@googlegroups.com
Comment #38 on issue 11238 by Git Watcher: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c38
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/fa565b93060bf5fec71d2cc172d6bf110e731f33
commit fa565b93060bf5fec71d2cc172d6bf110e731f33
Author: Clemens Backes <clem...@chromium.org>
Date: Thu Mar 18 13:11:51 2021
[no-wasm] Fix compilation by #if'ing out test code
The test was extended in this CL: https://crrev.com/c/2762420
It now uses wasm::SimdShuffle, which is only available if webassembly is
enabled.
Thus, #if out the test if webassembly is disabled.
Drive-by: Add a missing include.
R=jkum...@chromium.org
CC=zh...@chromium.org
Bug: v8:11238
Change-Id: I1b53d0145467b58616a161944fb88d2ca256fd58
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2772978
Reviewed-by: Zhi An Ng <zh...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73517}
[modify] https://crrev.com/fa565b93060bf5fec71d2cc172d6bf110e731f33/test/unittests/compiler/x64/instruction-selector-x64-unittest.cc
commit fa565b93060bf5fec71d2cc172d6bf110e731f33
Author: Clemens Backes <clem...@chromium.org>
Date: Thu Mar 18 13:11:51 2021
[no-wasm] Fix compilation by #if'ing out test code
The test was extended in this CL: https://crrev.com/c/2762420
It now uses wasm::SimdShuffle, which is only available if webassembly is
enabled.
Thus, #if out the test if webassembly is disabled.
Drive-by: Add a missing include.
R=jkum...@chromium.org
CC=zh...@chromium.org
Bug: v8:11238
Change-Id: I1b53d0145467b58616a161944fb88d2ca256fd58
Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2772978
Reviewed-by: Zhi An Ng <zh...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73517}
[modify] https://crrev.com/fa565b93060bf5fec71d2cc172d6bf110e731f33/test/unittests/compiler/x64/instruction-selector-x64-unittest.cc
cleyt… via monorail
Mar 18, 2021, 12:51:06 PM3/18/21
to v8-re...@googlegroups.com
Comment #39 on issue 11238 by cleyt...@gmail.com: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c39
Bom dia
Em quinta-feira, 18 de março de 2021, Git Watcher via monorail <
monorail+v2.233...@chromium.org> escreveu:
cleme… via monorail
Apr 9, 2021, 12:09:35 PM4/9/21
to v8-re...@googlegroups.com
Updates:
Status: Fixed
Comment #40 on issue 11238 by clem...@chromium.org: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c40
Done for now. We got ~2.6MB binary savings on x64. There are a few hundred more kB to be gained if e.g. unneeded parts of code generation are excluded, but that would be per platform, and much more work. Hence we decided to stop here for now.
Status: Fixed
Comment #40 on issue 11238 by clem...@chromium.org: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c40
Done for now. We got ~2.6MB binary savings on x64. There are a few hundred more kB to be gained if e.g. unneeded parts of code generation are excluded, but that would be per platform, and much more work. Hence we decided to stop here for now.
Git Watcher via monorail
Feb 17, 2022, 8:35:06 AM2/17/22
to v8-re...@googlegroups.com
Comment #41 on issue 11238 by Git Watcher: Introduce gn flag to enable/disable wasm
https://bugs.chromium.org/p/v8/issues/detail?id=11238#c41
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8/+/35fefc597688be7c4922f341e1f0a5e6d716de32
commit 35fefc597688be7c4922f341e1f0a5e6d716de32
Author: Jakob Kummerow <jkum...@chromium.org>
Date: Wed Feb 16 23:10:41 2022
[wasm] Enable and fix GCMole for Wasm
which the "no-wasm" build refactoring had accidentally disabled.
Bug: v8:11238
Change-Id: Ia2a4be89024f0bc22a1548dcef21e065e4bb5268
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468341
Reviewed-by: Thibaud Michaud <thib...@chromium.org>
Commit-Queue: Jakob Kummerow <jkum...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79140}
[modify] https://crrev.com/35fefc597688be7c4922f341e1f0a5e6d716de32/BUILD.gn
[modify] https://crrev.com/35fefc597688be7c4922f341e1f0a5e6d716de32/src/wasm/wasm-js.cc
commit 35fefc597688be7c4922f341e1f0a5e6d716de32
Author: Jakob Kummerow <jkum...@chromium.org>
Date: Wed Feb 16 23:10:41 2022
[wasm] Enable and fix GCMole for Wasm
which the "no-wasm" build refactoring had accidentally disabled.
Bug: v8:11238
Change-Id: Ia2a4be89024f0bc22a1548dcef21e065e4bb5268
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468341
Reviewed-by: Thibaud Michaud <thib...@chromium.org>
Commit-Queue: Jakob Kummerow <jkum...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79140}
[modify] https://crrev.com/35fefc597688be7c4922f341e1f0a5e6d716de32/BUILD.gn
[modify] https://crrev.com/35fefc597688be7c4922f341e1f0a5e6d716de32/src/wasm/wasm-js.cc
Reply all
Reply to author
Forward
0 new messages