[cleanup] Delete some useless code [v8/v8 : main]
Pan, Tao (Gerrit)
Pan, Tao voted and added 1 comment![]( "Open in Gerrit")
Votes added by Pan, Tao
| Commit-Queue | +1 |
1 comment
Related details
- Olivier Flückiger
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olivier Flückiger (Gerrit)
Olivier Flückiger added 1 comment![]( "Open in Gerrit")
if (IsJSFunction(function_)) {afaik this is for wasm deopts.
Related details
- Pan, Tao
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Pan, Tao (Gerrit)
Pan, Tao added 1 comment![]( "Open in Gerrit")
if (IsJSFunction(function_)) {afaik this is for wasm deopts.
I'm sorry, I don't understand. I think IsJSFunction(functions_) always returns true because "Tagged<JSFunction>function_;". Is there any difference in wasm deopts?
Related details
- Olivier Flückiger
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olivier Flückiger (Gerrit)
Olivier Flückiger added 1 comment![]( "Open in Gerrit")
if (IsJSFunction(function_)) {Pan, Taoafaik this is for wasm deopts.
I'm sorry, I don't understand. I think IsJSFunction(functions_) always returns true because "Tagged<JSFunction>function_;". Is there any difference in wasm deopts?
- Pan, Tao
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Pan, Tao (Gerrit)
Pan, Tao added 1 comment![]( "Open in Gerrit")
if (IsJSFunction(function_)) {Pan, Taoafaik this is for wasm deopts.
Olivier FlückigerI'm sorry, I don't understand. I think IsJSFunction(functions_) always returns true because "Tagged<JSFunction>function_;". Is there any difference in wasm deopts?
I think in wasm deopts the function is null
I think IsJSFunction(function_) will crash if function_ is null. If function_ is null in wasm deopts, it will not execute here because it returns early (https://source.chromium.org/chromium/chromium/src/+/main:v8/src/deoptimizer/deoptimizer.cc;drc=8dccd0f3594bed10325f5199065f8f60154df4e9;l=1594). What do you think of replacing ```if (IsJSFunction(function_)``` to ```DCHECK(!function_.is_null())```?
Related details
- Olivier Flückiger
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |