[strings] Remove unused NewStringFromUtf8SubString [v8/v8 : main]
1 view
Skip to first unread message
Maksim Ivanov (Gerrit)
Apr 2, 2026, 9:13:02 PM (3 days ago) Apr 2
to Deepti Gandluri, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Deepti Gandluri
Maksim Ivanov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Maksim Ivanov
| Auto-Submit | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Maksim Ivanov . resolved
gdeepti@: Could you PTAL - asking as Europe folks are on a long weekend? This is CL#2/2 to prevent Clang roll blockers.
Related details
Attention is currently required from:
- Deepti Gandluri
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Deepti Gandluri (Gerrit)
Apr 3, 2026, 1:36:37 PM (3 days ago) Apr 3
to Maksim Ivanov, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Maksim Ivanov
Deepti Gandluri voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Maksim Ivanov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maksim Ivanov (Gerrit)
Apr 3, 2026, 3:05:38 PM (3 days ago) Apr 3
to Deepti Gandluri, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Maksim Ivanov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Maksim Ivanov
| Auto-Submit | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Apr 3, 2026, 3:08:35 PM (3 days ago) Apr 3
to Maksim Ivanov, Deepti Gandluri, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[strings] Remove unused NewStringFromUtf8SubString
Remove Factory::NewStringFromUtf8SubString() - it seems to have been
unused since crrev.com/c/1108208.
This function's code triggers Wlifetime-safety warnings on ToT Clang,
due to potentially GC-unsafe code:
src/heap/factory.cc:983:51: error: object whose reference is captured
does not live long enough [-Werror,-Wlifetime-safety-use-after-scope]
983 | base::Vector<const uint8_t>(str->GetChars(no_gc) + begin, length);
| ^~~~~
src/heap/factory.cc:984:3: note: destroyed here
984 | }
| ^
src/heap/factory.cc:985:23: note: later used here
985 | Utf8Decoder decoder(utf8_data);
| ^~~~~~~~~
Bug: 482994758, 491707176
Change-Id: Iccde9c157c07727f57c7d5a81b1096ab0ebcbc1b
Auto-Submit: Maksim Ivanov <em...@chromium.org>
Reviewed-by: Deepti Gandluri <gde...@chromium.org>
Commit-Queue: Maksim Ivanov <em...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#106263}
Files:
- M src/heap/factory.cc
- M src/heap/factory.h
- M test/unittests/strings/unicode-unittest.cc
Change size: M
Delta: 3 files changed, 0 insertions(+), 124 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Deepti Gandluri
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages