[tracing] Fix double length read in PerfettoV8String [v8/v8 : main]

0 views
Skip to first unread message

Igor Sheludko (Gerrit)

unread,
Dec 19, 2025, 10:41:49 AM12/19/25
to Leszek Swirski, Fadi Meawad, alph+...@chromium.org, cbruni...@chromium.org, devtools-...@chromium.org, lpy+v8...@chromium.org, v8-re...@googlegroups.com
Attention needed from Leszek Swirski

Igor Sheludko voted and added 1 comment

Votes added by Igor Sheludko

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Igor Sheludko . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Leszek Swirski
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I183169c91ab397ad2acfb2ae8c589398dbb89582
Gerrit-Change-Number: 7276998
Gerrit-PatchSet: 1
Gerrit-Owner: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-CC: Fadi Meawad <fme...@chromium.org>
Gerrit-Attention: Leszek Swirski <les...@chromium.org>
Gerrit-Comment-Date: Fri, 19 Dec 2025 15:41:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Samuel Groß (Gerrit)

unread,
Dec 19, 2025, 11:31:27 AM12/19/25
to Igor Sheludko, V8 LUCI CQ, Leszek Swirski, Fadi Meawad, alph+...@chromium.org, cbruni...@chromium.org, devtools-...@chromium.org, lpy+v8...@chromium.org, v8-re...@googlegroups.com
Attention needed from Igor Sheludko and Leszek Swirski

Samuel Groß voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Igor Sheludko
  • Leszek Swirski
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: I183169c91ab397ad2acfb2ae8c589398dbb89582
    Gerrit-Change-Number: 7276998
    Gerrit-PatchSet: 1
    Gerrit-Owner: Igor Sheludko <ish...@chromium.org>
    Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
    Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
    Gerrit-Reviewer: Samuel Groß <sa...@chromium.org>
    Gerrit-CC: Fadi Meawad <fme...@chromium.org>
    Gerrit-Attention: Igor Sheludko <ish...@chromium.org>
    Gerrit-Attention: Leszek Swirski <les...@chromium.org>
    Gerrit-Comment-Date: Fri, 19 Dec 2025 16:31:22 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Leszek Swirski (Gerrit)

    unread,
    10:57 AM (11 hours ago) 10:57 AM
    to Igor Sheludko, Samuel Groß, V8 LUCI CQ, Fadi Meawad, alph+...@chromium.org, cbruni...@chromium.org, devtools-...@chromium.org, lpy+v8...@chromium.org, v8-re...@googlegroups.com
    Attention needed from Igor Sheludko and Samuel Groß

    Leszek Swirski voted

    Code-Review+1
    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Igor Sheludko
    • Samuel Groß
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: I183169c91ab397ad2acfb2ae8c589398dbb89582
    Gerrit-Change-Number: 7276998
    Gerrit-PatchSet: 1
    Gerrit-Owner: Igor Sheludko <ish...@chromium.org>
    Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
    Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
    Gerrit-Reviewer: Samuel Groß <sa...@chromium.org>
    Gerrit-CC: Fadi Meawad <fme...@chromium.org>
    Gerrit-Attention: Igor Sheludko <ish...@chromium.org>
    Gerrit-Attention: Samuel Groß <sa...@chromium.org>
    Gerrit-Comment-Date: Mon, 12 Jan 2026 15:57:00 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    V8 LUCI CQ (Gerrit)

    unread,
    11:57 AM (10 hours ago) 11:57 AM
    to Igor Sheludko, Leszek Swirski, Samuel Groß, Fadi Meawad, alph+...@chromium.org, cbruni...@chromium.org, devtools-...@chromium.org, lpy+v8...@chromium.org, v8-re...@googlegroups.com

    V8 LUCI CQ submitted the change

    Change information

    Commit message:
    [tracing] Fix double length read in PerfettoV8String
    Fixed: 467270655
    Change-Id: I183169c91ab397ad2acfb2ae8c589398dbb89582
    Reviewed-by: Samuel Groß <sa...@chromium.org>
    Reviewed-by: Leszek Swirski <les...@chromium.org>
    Commit-Queue: Leszek Swirski <les...@chromium.org>
    Auto-Submit: Igor Sheludko <ish...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#104647}
    Files:
    • M src/tracing/perfetto-utils.cc
    Change size: S
    Delta: 1 file changed, 6 insertions(+), 6 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Samuel Groß, +1 by Leszek Swirski
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: I183169c91ab397ad2acfb2ae8c589398dbb89582
    Gerrit-Change-Number: 7276998
    Gerrit-PatchSet: 2
    Gerrit-Owner: Igor Sheludko <ish...@chromium.org>
    Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
    Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
    Gerrit-Reviewer: Samuel Groß <sa...@chromium.org>
    Gerrit-CC: Fadi Meawad <fme...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages