Igor Sheludko (Gerrit)

unread,

Dec 19, 2025, 10:41:49 AM12/19/25

to Leszek Swirski, Fadi Meawad, alph+...@chromium.org, cbruni...@chromium.org, devtools-...@chromium.org, lpy+v8...@chromium.org, v8-re...@googlegroups.com

Attention needed from Leszek Swirski

Igor Sheludko voted and added 1 comment

Votes added by Igor Sheludko

Auto-Submit	+1
Commit-Queue	+1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Igor Sheludko . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:

Leszek Swirski

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Samuel Groß (Gerrit)

unread,

Dec 19, 2025, 11:31:27 AM12/19/25

to Igor Sheludko, V8 LUCI CQ, Leszek Swirski, Fadi Meawad, alph+...@chromium.org, cbruni...@chromium.org, devtools-...@chromium.org, lpy+v8...@chromium.org, v8-re...@googlegroups.com

Attention needed from Igor Sheludko and Leszek Swirski

Samuel Groß voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Igor Sheludko
Leszek Swirski

Submit Requirements:

Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Leszek Swirski (Gerrit)

unread,

10:57 AM (11 hours ago) 10:57 AM

to Igor Sheludko, Samuel Groß, V8 LUCI CQ, Fadi Meawad, alph+...@chromium.org, cbruni...@chromium.org, devtools-...@chromium.org, lpy+v8...@chromium.org, v8-re...@googlegroups.com

Attention needed from Igor Sheludko and Samuel Groß

Leszek Swirski voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Igor Sheludko
Samuel Groß

Submit Requirements:

Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

V8 LUCI CQ (Gerrit)

unread,

11:57 AM (10 hours ago) 11:57 AM

to Igor Sheludko, Leszek Swirski, Samuel Groß, Fadi Meawad, alph+...@chromium.org, cbruni...@chromium.org, devtools-...@chromium.org, lpy+v8...@chromium.org, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:

[tracing] Fix double length read in PerfettoV8String

Fixed: 467270655

Change-Id: I183169c91ab397ad2acfb2ae8c589398dbb89582

Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7276998

Reviewed-by: Samuel Groß <sa...@chromium.org>

Reviewed-by: Leszek Swirski <les...@chromium.org>

Commit-Queue: Leszek Swirski <les...@chromium.org>

Auto-Submit: Igor Sheludko <ish...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#104647}

Files:

M src/tracing/perfetto-utils.cc

Change size: S

Delta: 1 file changed, 6 insertions(+), 6 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Samuel Groß, +1 by Leszek Swirski

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[tracing] Fix double length read in PerfettoV8String [v8/v8 : main]

Igor Sheludko (Gerrit)

Igor Sheludko voted and added 1 comment

Votes added by Igor Sheludko

1 comment

Related details

Samuel Groß (Gerrit)

Samuel Groß voted

Related details

Leszek Swirski (Gerrit)

Leszek Swirski voted

Related details

V8 LUCI CQ (Gerrit)

V8 LUCI CQ submitted the change

Change information