[gdb server] Handles invalid query packets [v8/v8 : main]

0 views
Skip to first unread message

Daniel Lehmann (Gerrit)

unread,
10:18 AM (9 hours ago) 10:18 AM
to Paolo Severini, V8 LUCI CQ, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Paolo Severini

Daniel Lehmann added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Daniel Lehmann . resolved

Sorry for the late reply, was OOO until today. Could you CC me on the linked bug? Getting access denied. Generally LGTM, but would need a bit more context to +1; what are invalid query packets, what's the high-level context of that change?

Open in Gerrit

Related details

Attention is currently required from:
  • Paolo Severini
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I81fddadd3dd2196dcb832eb791b4820696604e2a
Gerrit-Change-Number: 7649077
Gerrit-PatchSet: 1
Gerrit-Owner: Paolo Severini <paol...@microsoft.com>
Gerrit-Reviewer: Daniel Lehmann <dleh...@chromium.org>
Gerrit-Reviewer: Paolo Severini <paol...@microsoft.com>
Gerrit-Attention: Paolo Severini <paol...@microsoft.com>
Gerrit-Comment-Date: Mon, 16 Mar 2026 14:18:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Paolo Severini (Gerrit)

unread,
10:58 AM (9 hours ago) 10:58 AM
to V8 LUCI CQ, Daniel Lehmann, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Daniel Lehmann

Paolo Severini added 1 comment

Patchset-level comments
Daniel Lehmann . resolved

Sorry for the late reply, was OOO until today. Could you CC me on the linked bug? Getting access denied. Generally LGTM, but would need a bit more context to +1; what are invalid query packets, what's the high-level context of that change?

Paolo Severini

No problem at all! :)
I added you to the bug, to give more context.

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Lehmann
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I81fddadd3dd2196dcb832eb791b4820696604e2a
Gerrit-Change-Number: 7649077
Gerrit-PatchSet: 1
Gerrit-Owner: Paolo Severini <paol...@microsoft.com>
Gerrit-Reviewer: Daniel Lehmann <dleh...@chromium.org>
Gerrit-Reviewer: Paolo Severini <paol...@microsoft.com>
Gerrit-Attention: Daniel Lehmann <dleh...@chromium.org>
Gerrit-Comment-Date: Mon, 16 Mar 2026 14:58:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Daniel Lehmann <dleh...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Lehmann (Gerrit)

unread,
11:34 AM (8 hours ago) 11:34 AM
to Paolo Severini, V8 LUCI CQ, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Paolo Severini

Daniel Lehmann voted and added 1 comment

Votes added by Daniel Lehmann

Code-Review+1

1 comment

Patchset-level comments
Daniel Lehmann . resolved

Sorry for the late reply, was OOO until today. Could you CC me on the linked bug? Getting access denied. Generally LGTM, but would need a bit more context to +1; what are invalid query packets, what's the high-level context of that change?

Paolo Severini

No problem at all! :)
I added you to the bug, to give more context.

Daniel Lehmann

Perfect, thanks! :)

Open in Gerrit

Related details

Attention is currently required from:
  • Paolo Severini
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I81fddadd3dd2196dcb832eb791b4820696604e2a
Gerrit-Change-Number: 7649077
Gerrit-PatchSet: 1
Gerrit-Owner: Paolo Severini <paol...@microsoft.com>
Gerrit-Reviewer: Daniel Lehmann <dleh...@chromium.org>
Gerrit-Reviewer: Paolo Severini <paol...@microsoft.com>
Gerrit-Attention: Paolo Severini <paol...@microsoft.com>
Gerrit-Comment-Date: Mon, 16 Mar 2026 15:34:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Daniel Lehmann <dleh...@chromium.org>
Comment-In-Reply-To: Paolo Severini <paol...@microsoft.com>
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages