[arm64][wasm] Add 16x4 Deinterleave using UZP [v8/v8 : main]
0 views
Skip to first unread message
Emily Boarer (Gerrit)
Dec 15, 2025, 10:56:18 AM (19 hours ago) Dec 15
to Darius Mercadier, V8 LUCI CQ, Sam Parker-Haynes, dmercadi...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from Darius Mercadier
Emily Boarer added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Emily Boarer . resolved
Hopefully I've found your correct email address, Darius?
Related details
Attention is currently required from:
- Darius Mercadier
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darius Mercadier (Gerrit)
3:16 AM (3 hours ago) 3:16 AM
to Emily Boarer, Daniel Lehmann, V8 LUCI CQ, Sam Parker-Haynes, dmercadi...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from Daniel Lehmann and Emily Boarer
Darius Mercadier voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darius Mercadier
| Code-Review | +1 |
1 comment
Patchset-level comments
Darius Mercadier . resolved
LGTM :)
Daniel, PTAL src/wasm (feel free to just stamp: I've reviewed already)
Related details
Attention is currently required from:
- Daniel Lehmann
- Emily Boarer
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Lehmann (Gerrit)
4:24 AM (2 hours ago) 4:24 AM
to Emily Boarer, Darius Mercadier, V8 LUCI CQ, Sam Parker-Haynes, dmercadi...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from Emily Boarer
Daniel Lehmann voted and added 1 comment![]( "Open in Gerrit")
Votes added by Daniel Lehmann
| Code-Review | +1 |
1 comment
Patchset-level comments
Darius Mercadier . resolved
LGTM :)
Daniel, PTAL src/wasm (feel free to just stamp: I've reviewed already)
Attention is currently required from:
- Emily Boarer
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sam Parker-Haynes (Gerrit)
4:56 AM (1 hour ago) 4:56 AM
to Emily Boarer, Daniel Lehmann, Darius Mercadier, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from Emily Boarer
Sam Parker-Haynes voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Emily Boarer
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
4:58 AM (1 hour ago) 4:58 AM
to Emily Boarer, Daniel Lehmann, Darius Mercadier, Sam Parker-Haynes, dmercadi...@chromium.org, v8-re...@googlegroups.com, was...@google.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[arm64][wasm] Add 16x4 Deinterleave using UZP
Two UZP/UZP2 instructions can be chained to extract every fourth element
in a shuffle, from a different offset for each combination.
Use 8x8 shuffles to implement this, where the combinations have
sequential elements to result in 16x4 shuffles.
Change-Id: Idc900c915fde298154c31ff5230df4f8866b9dee
Commit-Queue: Sam Parker-Haynes <sam.p...@arm.com>
Reviewed-by: Darius Mercadier <dmerc...@chromium.org>
Reviewed-by: Daniel Lehmann <dleh...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104334}
Files:
- M src/compiler/backend/arm64/instruction-selector-arm64.cc
- M src/wasm/simd-shuffle.cc
- M src/wasm/simd-shuffle.h
- M test/mjsunit/wasm/half-shuffles.js
- M test/unittests/compiler/arm64/turboshaft-instruction-selector-arm64-unittest.cc
Change size: M
Delta: 5 files changed, 97 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Daniel Lehmann, +1 by Darius Mercadier
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Hartmann (Gerrit)
5:58 AM (18 minutes ago) 5:58 AM
to V8 LUCI CQ, Emily Boarer, Daniel Lehmann, Darius Mercadier, Sam Parker-Haynes, dmercadi...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Nico Hartmann has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages