[arm64][wasm] Add 16x4 Deinterleave using UZP [v8/v8 : main]

0 views
Skip to first unread message

Emily Boarer (Gerrit)

unread,
Dec 15, 2025, 10:56:18 AM (19 hours ago) Dec 15
to Darius Mercadier, V8 LUCI CQ, Sam Parker-Haynes, dmercadi...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from Darius Mercadier

Emily Boarer added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Emily Boarer . resolved

Hopefully I've found your correct email address, Darius?

Open in Gerrit

Related details

Attention is currently required from:
  • Darius Mercadier
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Idc900c915fde298154c31ff5230df4f8866b9dee
Gerrit-Change-Number: 7261076
Gerrit-PatchSet: 1
Gerrit-Owner: Emily Boarer <emily....@arm.com>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-Attention: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Dec 2025 15:56:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Darius Mercadier (Gerrit)

unread,
3:16 AM (3 hours ago) 3:16 AM
to Emily Boarer, Daniel Lehmann, V8 LUCI CQ, Sam Parker-Haynes, dmercadi...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from Daniel Lehmann and Emily Boarer

Darius Mercadier voted and added 1 comment

Votes added by Darius Mercadier

Code-Review+1

1 comment

Patchset-level comments
Darius Mercadier . resolved

LGTM :)

Daniel, PTAL src/wasm (feel free to just stamp: I've reviewed already)

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Lehmann
  • Emily Boarer
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Idc900c915fde298154c31ff5230df4f8866b9dee
Gerrit-Change-Number: 7261076
Gerrit-PatchSet: 1
Gerrit-Owner: Emily Boarer <emily....@arm.com>
Gerrit-Reviewer: Daniel Lehmann <dleh...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-Attention: Daniel Lehmann <dleh...@chromium.org>
Gerrit-Attention: Emily Boarer <emily....@arm.com>
Gerrit-Comment-Date: Tue, 16 Dec 2025 08:16:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Daniel Lehmann (Gerrit)

unread,
4:24 AM (2 hours ago) 4:24 AM
to Emily Boarer, Darius Mercadier, V8 LUCI CQ, Sam Parker-Haynes, dmercadi...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from Emily Boarer

Daniel Lehmann voted and added 1 comment

Votes added by Daniel Lehmann

Code-Review+1

1 comment

Patchset-level comments
Darius Mercadier . resolved

LGTM :)

Daniel, PTAL src/wasm (feel free to just stamp: I've reviewed already)

Daniel Lehmann

Stamping.

Open in Gerrit

Related details

Attention is currently required from:
  • Emily Boarer
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Idc900c915fde298154c31ff5230df4f8866b9dee
Gerrit-Change-Number: 7261076
Gerrit-PatchSet: 1
Gerrit-Owner: Emily Boarer <emily....@arm.com>
Gerrit-Reviewer: Daniel Lehmann <dleh...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-Attention: Emily Boarer <emily....@arm.com>
Gerrit-Comment-Date: Tue, 16 Dec 2025 09:24:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Darius Mercadier <dmerc...@chromium.org>
satisfied_requirement
open
diffy

Sam Parker-Haynes (Gerrit)

unread,
4:56 AM (1 hour ago) 4:56 AM
to Emily Boarer, Daniel Lehmann, Darius Mercadier, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from Emily Boarer

Sam Parker-Haynes voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Emily Boarer
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Idc900c915fde298154c31ff5230df4f8866b9dee
Gerrit-Change-Number: 7261076
Gerrit-PatchSet: 1
Gerrit-Owner: Emily Boarer <emily....@arm.com>
Gerrit-Reviewer: Daniel Lehmann <dleh...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-Attention: Emily Boarer <emily....@arm.com>
Gerrit-Comment-Date: Tue, 16 Dec 2025 09:56:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
4:58 AM (1 hour ago) 4:58 AM
to Emily Boarer, Daniel Lehmann, Darius Mercadier, Sam Parker-Haynes, dmercadi...@chromium.org, v8-re...@googlegroups.com, was...@google.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[arm64][wasm] Add 16x4 Deinterleave using UZP

Two UZP/UZP2 instructions can be chained to extract every fourth element
in a shuffle, from a different offset for each combination.

Use 8x8 shuffles to implement this, where the combinations have
sequential elements to result in 16x4 shuffles.
Change-Id: Idc900c915fde298154c31ff5230df4f8866b9dee
Commit-Queue: Sam Parker-Haynes <sam.p...@arm.com>
Reviewed-by: Darius Mercadier <dmerc...@chromium.org>
Reviewed-by: Daniel Lehmann <dleh...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104334}
Files:
  • M src/compiler/backend/arm64/instruction-selector-arm64.cc
  • M src/wasm/simd-shuffle.cc
  • M src/wasm/simd-shuffle.h
  • M test/mjsunit/wasm/half-shuffles.js
  • M test/unittests/compiler/arm64/turboshaft-instruction-selector-arm64-unittest.cc
Change size: M
Delta: 5 files changed, 97 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Daniel Lehmann, +1 by Darius Mercadier
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Idc900c915fde298154c31ff5230df4f8866b9dee
Gerrit-Change-Number: 7261076
Gerrit-PatchSet: 2
Gerrit-Owner: Emily Boarer <emily....@arm.com>
Gerrit-Reviewer: Daniel Lehmann <dleh...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Sam Parker-Haynes <sam.p...@arm.com>
open
diffy
satisfied_requirement

Nico Hartmann (Gerrit)

unread,
5:58 AM (18 minutes ago) 5:58 AM
to V8 LUCI CQ, Emily Boarer, Daniel Lehmann, Darius Mercadier, Sam Parker-Haynes, dmercadi...@chromium.org, v8-re...@googlegroups.com, was...@google.com

Nico Hartmann has created a revert of this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: revert
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages