[runtime] Add GetPrivateField/SetPrivateField Specialized Bytecodes. [v8/v8 : main]

[Raphael Herouart (Gerrit)]

Attention needed from Raphael Herouart

Message from Raphael Herouart

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:

• Raphael Herouart

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I392b91e1a0fbbb43a1d0528fd7358d48aa8c3538

Gerrit-Change-Number: 7532295

Gerrit-PatchSet: 29

Gerrit-Owner: Raphael Herouart <rher...@chromium.org>

Gerrit-Reviewer: Raphael Herouart <rher...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Raphael Herouart <rher...@chromium.org>

Gerrit-Comment-Date: Tue, 03 Mar 2026 12:38:42 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Toon Verwaest (Gerrit)]

Attention needed from Igor Sheludko, Leszek Swirski and Raphael Herouart

Toon Verwaest added 4 comments

File src/baseline/arm/baseline-assembler-arm-inl.h

Line 451, Patchset 43 (Latest): if (v8_flags.private_field_bytecodes) {

Toon Verwaest . unresolved

Adding a flag here seems like overkill.

File src/maglev/maglev-graph-builder.cc

Line 7836, Patchset 43 (Latest): if (compilation_unit_->info()->specialize_to_function_context()) {

Toon Verwaest . unresolved

This isn't necessary; if we don't specialize to the function context we won't have the context (unless we do because the function we're handling here is inlined and does have a context.)

Line 7858, Patchset 43 (Latest): switch (processed_feedback.kind()) {

Toon Verwaest . unresolved

Do you need to duplicate this code?

Line 7885, Patchset 43 (Latest):ReduceResult MaglevGraphBuilder::VisitSetPrivateField() {

Toon Verwaest . unresolved

Same as above.

Open in Gerrit

Related details

Attention is currently required from:

• Igor Sheludko
• Leszek Swirski
• Raphael Herouart

Submit Requirements:

• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I392b91e1a0fbbb43a1d0528fd7358d48aa8c3538

Gerrit-Change-Number: 7532295

Gerrit-PatchSet: 43

Gerrit-Owner: Raphael Herouart <rher...@chromium.org>

Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>

Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>

Gerrit-Reviewer: Raphael Herouart <rher...@chromium.org>

Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Igor Sheludko <ish...@chromium.org>

Gerrit-Attention: Raphael Herouart <rher...@chromium.org>

Gerrit-Attention: Leszek Swirski <les...@chromium.org>

Gerrit-Comment-Date: Fri, 06 Mar 2026 13:47:44 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Raphael Herouart (Gerrit)]

Attention needed from Igor Sheludko, Leszek Swirski and Toon Verwaest

Raphael Herouart added 4 comments

File src/baseline/arm/baseline-assembler-arm-inl.h

Line 451, Patchset 43: if (v8_flags.private_field_bytecodes) {

Toon Verwaest . resolved

Adding a flag here seems like overkill.

Raphael Herouart

Done

File src/maglev/maglev-graph-builder.cc

Line 7836, Patchset 43: if (compilation_unit_->info()->specialize_to_function_context()) {

Toon Verwaest . resolved

This isn't necessary; if we don't specialize to the function context we won't have the context (unless we do because the function we're handling here is inlined and does have a context.)

Raphael Herouart

Done

Line 7858, Patchset 43: switch (processed_feedback.kind()) {

Toon Verwaest . unresolved

Do you need to duplicate this code?

Raphael Herouart

I would need create a function with loads of params, also this code may or may not return, so I'd have to store a ReduceResult, that I may or may not return from the caller. And this logic in turn would be duplicated between callers...

Line 7885, Patchset 43:ReduceResult MaglevGraphBuilder::VisitSetPrivateField() {

Toon Verwaest . resolved

Same as above.

Raphael Herouart

Done

Open in Gerrit

Related details

Attention is currently required from:

• Igor Sheludko
• Leszek Swirski
• Toon Verwaest

Submit Requirements:

• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I392b91e1a0fbbb43a1d0528fd7358d48aa8c3538

Gerrit-Change-Number: 7532295

Gerrit-PatchSet: 44

Gerrit-Owner: Raphael Herouart <rher...@chromium.org>

Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>

Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>

Gerrit-Reviewer: Raphael Herouart <rher...@chromium.org>

Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Toon Verwaest <verw...@chromium.org>

Gerrit-Attention: Igor Sheludko <ish...@chromium.org>

Gerrit-Attention: Leszek Swirski <les...@chromium.org>

Gerrit-Comment-Date: Fri, 06 Mar 2026 17:23:33 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Toon Verwaest <verw...@chromium.org>

[Raphael Herouart (Gerrit)]

Attention needed from Igor Sheludko, Leszek Swirski, Raphael Herouart and Toon Verwaest

Message from Raphael Herouart

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:

• Igor Sheludko
• Leszek Swirski
• Raphael Herouart
• Toon Verwaest

Submit Requirements:

• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I392b91e1a0fbbb43a1d0528fd7358d48aa8c3538

Gerrit-Change-Number: 7532295

Gerrit-PatchSet: 50

Gerrit-Owner: Raphael Herouart <rher...@chromium.org>

Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>

Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>

Gerrit-Reviewer: Raphael Herouart <rher...@chromium.org>

Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Toon Verwaest <verw...@chromium.org>

Gerrit-Attention: Igor Sheludko <ish...@chromium.org>

Gerrit-Attention: Raphael Herouart <rher...@chromium.org>

Gerrit-Attention: Leszek Swirski <les...@chromium.org>

Gerrit-Comment-Date: Mon, 09 Mar 2026 08:34:10 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Raphael Herouart (Gerrit)]

Attention needed from Igor Sheludko, Leszek Swirski and Toon Verwaest

Raphael Herouart voted and added 1 comment

Votes added by Raphael Herouart

Commit-Queue

+1

1 comment

File src/maglev/maglev-graph-builder.cc

Line 7858, Patchset 43: switch (processed_feedback.kind()) {

Toon Verwaest . resolved

Do you need to duplicate this code?

Raphael Herouart

I would need create a function with loads of params, also this code may or may not return, so I'd have to store a ReduceResult, that I may or may not return from the caller. And this logic in turn would be duplicated between callers...

Raphael Herouart

Done

Open in Gerrit

Related details

Attention is currently required from:

• Igor Sheludko
• Leszek Swirski
• Toon Verwaest

Submit Requirements:

• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I392b91e1a0fbbb43a1d0528fd7358d48aa8c3538

Gerrit-Change-Number: 7532295

Gerrit-PatchSet: 50

Gerrit-Owner: Raphael Herouart <rher...@chromium.org>

Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>

Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>

Gerrit-Reviewer: Raphael Herouart <rher...@chromium.org>

Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Toon Verwaest <verw...@chromium.org>

Gerrit-Attention: Igor Sheludko <ish...@chromium.org>

Gerrit-Attention: Leszek Swirski <les...@chromium.org>

Gerrit-Comment-Date: Mon, 09 Mar 2026 09:21:53 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Toon Verwaest <verw...@chromium.org>

Comment-In-Reply-To: Raphael Herouart <rher...@chromium.org>

[Toon Verwaest (Gerrit)]

Attention needed from Igor Sheludko, Leszek Swirski and Raphael Herouart

Toon Verwaest voted and added 2 comments

Votes added by Toon Verwaest

Code-Review	+1
Commit-Queue	+1

2 comments

File src/maglev/maglev-graph-builder.cc

Line 7799, Patchset 50 (Latest): LoadAndCacheImmutableContextSlot(context, Context::PREVIOUS_INDEX);

Toon Verwaest . unresolved

I don't think this needs to be changed? LoadAndCacheContextSlot should automatically figure out that it's immutable and do the right thing?

Line 7906, Patchset 50 (Latest): name = LoadAndCacheImmutableContextSlot(context, slot_index);

Toon Verwaest . unresolved

same here and elsewhere

Open in Gerrit

Related details

Attention is currently required from:

• Igor Sheludko
• Leszek Swirski
• Raphael Herouart

Submit Requirements:

• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I392b91e1a0fbbb43a1d0528fd7358d48aa8c3538

Gerrit-Change-Number: 7532295

Gerrit-PatchSet: 50

Gerrit-Owner: Raphael Herouart <rher...@chromium.org>

Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>

Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>

Gerrit-Reviewer: Raphael Herouart <rher...@chromium.org>

Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Igor Sheludko <ish...@chromium.org>

Gerrit-Attention: Raphael Herouart <rher...@chromium.org>

Gerrit-Attention: Leszek Swirski <les...@chromium.org>

Gerrit-Comment-Date: Tue, 10 Mar 2026 15:19:57 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Raphael Herouart (Gerrit)]

Attention needed from Igor Sheludko, Leszek Swirski and Toon Verwaest

Raphael Herouart added 2 comments

File src/maglev/maglev-graph-builder.cc

Line 7799, Patchset 50: LoadAndCacheImmutableContextSlot(context, Context::PREVIOUS_INDEX);

Toon Verwaest . resolved

I don't think this needs to be changed? LoadAndCacheContextSlot should automatically figure out that it's immutable and do the right thing?

Raphael Herouart

Done

Line 7906, Patchset 50: name = LoadAndCacheImmutableContextSlot(context, slot_index);

Toon Verwaest . resolved

same here and elsewhere

Raphael Herouart

Done

Open in Gerrit

Related details

Attention is currently required from:

• Igor Sheludko
• Leszek Swirski
• Toon Verwaest

Submit Requirements:

• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I392b91e1a0fbbb43a1d0528fd7358d48aa8c3538

Gerrit-Change-Number: 7532295

Gerrit-PatchSet: 51

Gerrit-Owner: Raphael Herouart <rher...@chromium.org>

Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>

Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>

Gerrit-Reviewer: Raphael Herouart <rher...@chromium.org>

Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Toon Verwaest <verw...@chromium.org>

Gerrit-Attention: Igor Sheludko <ish...@chromium.org>

Gerrit-Attention: Leszek Swirski <les...@chromium.org>

Gerrit-Comment-Date: Tue, 10 Mar 2026 15:34:47 +0000

[Raphael Herouart (Gerrit)]

Attention needed from Igor Sheludko, Leszek Swirski and Toon Verwaest

Raphael Herouart voted Commit-Queue+2

Commit-Queue

+2

Gerrit-Comment-Date: Tue, 10 Mar 2026 15:35:20 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Toon Verwaest (Gerrit)]

Attention needed from Igor Sheludko, Leszek Swirski and Raphael Herouart

Toon Verwaest voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Igor Sheludko
• Leszek Swirski
• Raphael Herouart

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I392b91e1a0fbbb43a1d0528fd7358d48aa8c3538

Gerrit-Change-Number: 7532295

Gerrit-PatchSet: 52

Gerrit-Owner: Raphael Herouart <rher...@chromium.org>

Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>

Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>

Gerrit-Reviewer: Raphael Herouart <rher...@chromium.org>

Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Igor Sheludko <ish...@chromium.org>

Gerrit-Attention: Raphael Herouart <rher...@chromium.org>

Gerrit-Attention: Leszek Swirski <les...@chromium.org>

Gerrit-Comment-Date: Tue, 10 Mar 2026 16:13:44 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[chromeperf@appspot.gserviceaccount.com (Gerrit)]

Attention needed from Igor Sheludko, Leszek Swirski and Raphael Herouart

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m4-mini-perf/jetstream-main.crossbench complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/13a05c8ff10000

Gerrit-CC: chrom...@appspot.gserviceaccount.com <chrom...@appspot.gserviceaccount.com>

Gerrit-Attention: Igor Sheludko <ish...@chromium.org>

Gerrit-Attention: Raphael Herouart <rher...@chromium.org>

Gerrit-Attention: Leszek Swirski <les...@chromium.org>

Gerrit-Comment-Date: Tue, 10 Mar 2026 16:57:13 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Raphael Herouart (Gerrit)]

Attention needed from Igor Sheludko and Leszek Swirski

Raphael Herouart voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

• Igor Sheludko
• Leszek Swirski

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I392b91e1a0fbbb43a1d0528fd7358d48aa8c3538

Gerrit-Change-Number: 7532295

Gerrit-PatchSet: 52

Gerrit-Owner: Raphael Herouart <rher...@chromium.org>

Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>

Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>

Gerrit-Reviewer: Raphael Herouart <rher...@chromium.org>

Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chrom...@appspot.gserviceaccount.com <chrom...@appspot.gserviceaccount.com>

Gerrit-Attention: Igor Sheludko <ish...@chromium.org>

Gerrit-Attention: Leszek Swirski <les...@chromium.org>

Gerrit-Comment-Date: Wed, 11 Mar 2026 07:48:04 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[V8 LUCI CQ (Gerrit)]

V8 LUCI CQ submitted the change

Change information

Commit message:

[runtime] Add GetPrivateField/SetPrivateField Specialized Bytecodes.

Bug: 474269456

Change-Id: I392b91e1a0fbbb43a1d0528fd7358d48aa8c3538

Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7532295

Reviewed-by: Toon Verwaest <verw...@chromium.org>

Commit-Queue: Raphael Herouart <rher...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#105716}

Files:

• M src/baseline/arm/baseline-assembler-arm-inl.h
• M src/baseline/arm64/baseline-assembler-arm64-inl.h
• M src/baseline/baseline-assembler.h
• M src/baseline/baseline-compiler.cc
• M src/baseline/ia32/baseline-assembler-ia32-inl.h
• M src/baseline/loong64/baseline-assembler-loong64-inl.h
• M src/baseline/mips64/baseline-assembler-mips64-inl.h
• M src/baseline/ppc/baseline-assembler-ppc-inl.h
• M src/baseline/riscv/baseline-assembler-riscv-inl.h
• M src/baseline/s390/baseline-assembler-s390-inl.h
• M src/baseline/x64/baseline-assembler-x64-inl.h
• M src/compiler/bytecode-graph-builder.cc
• M src/flags/flag-definitions.h
• M src/interpreter/bytecode-array-builder.cc
• M src/interpreter/bytecode-array-builder.h
• M src/interpreter/bytecode-generator.cc
• M src/interpreter/bytecode-generator.h
• M src/interpreter/bytecodes.h
• M src/interpreter/interpreter-generator.cc
• M src/maglev/maglev-graph-builder.cc
• M src/maglev/maglev-graph-builder.h
• A test/mjsunit/private_fields/test_private_fields.js
• M test/unittests/interpreter/bytecode-array-builder-unittest.cc
• A test/unittests/interpreter/bytecode_expectations/PrivateFieldSpecializedBytecode.golden

Change size: L

Delta: 24 files changed, 673 insertions(+), 40 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Toon Verwaest

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I392b91e1a0fbbb43a1d0528fd7358d48aa8c3538

Gerrit-Change-Number: 7532295

Gerrit-PatchSet: 53

Gerrit-Owner: Raphael Herouart <rher...@chromium.org>

Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>

Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>

Gerrit-Reviewer: Raphael Herouart <rher...@chromium.org>

Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>

Gerrit-Reviewer: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chrom...@appspot.gserviceaccount.com <chrom...@appspot.gserviceaccount.com>