[maglev] Verify the precondition of the free Float64 to HoleyFloat64 widen [v8/v8 : main]
0 views
Skip to first unread message
Victor Gomes (Gerrit)
Aug 13, 2026, 7:45:40 AM (2 days ago) Aug 13
to Patrick Thier, android-bu...@system.gserviceaccount.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Patrick Thier
Victor Gomes voted and added 1 comment![]( "Open in Gerrit")
Votes added by Victor Gomes
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Patrick Thier
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Thier (Gerrit)
Aug 13, 2026, 10:48:51 AM (2 days ago) Aug 13
to Victor Gomes, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes
Patrick Thier voted and added 2 comments![]( "Open in Gerrit")
Votes added by Patrick Thier
| Code-Review | +1 |
2 comments
Patchset-level comments
Patrick Thier . resolved
LGTM % comment
File src/maglev/maglev-ir.cc
Line 1063, Patchset 4 (Latest):
DCHECK(!input_node(0)->UnwrapIdentities()->MayBeHoleOrUndefinedNan());Patrick Thier . unresolved
Aren't the `VerifyInputs` usually hard `CHECK`s and not just `DCHECK`s?
Related details
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Gomes (Gerrit)
Aug 14, 2026, 5:11:50 AM (yesterday) Aug 14
to Patrick Thier, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Victor Gomes added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File src/maglev/maglev-ir.cc
Line 1063, Patchset 4:
DCHECK(!input_node(0)->UnwrapIdentities()->MayBeHoleOrUndefinedNan());Patrick Thier . resolved
Aren't the `VerifyInputs` usually hard `CHECK`s and not just `DCHECK`s?
Victor Gomes
You're right. Done.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Aug 14, 2026, 6:10:55 AM (yesterday) Aug 14
to Victor Gomes, Patrick Thier, android-bu...@system.gserviceaccount.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: src/maglev/maglev-ir.cc
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[maglev] Verify the precondition of the free Float64 to HoleyFloat64 widen
Bug: 545843233
Change-Id: I2c6bdf588954a82b919b06af64be7788c2e8326a
Reviewed-by: Patrick Thier <pth...@chromium.org>
Commit-Queue: Victor Gomes <victo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#109253}
Files:
- M src/maglev/maglev-ir.cc
- M src/maglev/maglev-ir.h
Change size: XS
Delta: 2 files changed, 6 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Patrick Thier
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages