[wasm-interpreter] Fix build failure in WasmStackEntryWrapperCache::CompileWrapper() [v8/v8 : main]
0 views
Skip to first unread message
Gyuyoung Kim (Gerrit)
Dec 9, 2025, 3:58:09 AM12/9/25
to Thibaud Michaud, Paolo Severini, Raphael Kubo da Costa, Abhijeet Kandalkar, Julie Jeongeun Kim, cobalt-...@google.com, v8-re...@googlegroups.com, was...@google.com
Attention needed from Paolo Severini and Thibaud Michaud
Gyuyoung Kim added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Paolo Severini
- Thibaud Michaud
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thibaud Michaud (Gerrit)
Dec 9, 2025, 4:04:48 AM12/9/25
to Gyuyoung Kim, Paolo Severini, Raphael Kubo da Costa, Abhijeet Kandalkar, Julie Jeongeun Kim, cobalt-...@google.com, v8-re...@googlegroups.com, was...@google.com
Attention needed from Gyuyoung Kim and Paolo Severini
Thibaud Michaud voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Gyuyoung Kim
- Paolo Severini
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gyuyoung Kim (Gerrit)
Dec 9, 2025, 4:19:55 AM12/9/25
to Thibaud Michaud, Paolo Severini, Raphael Kubo da Costa, Abhijeet Kandalkar, Julie Jeongeun Kim, cobalt-...@google.com, v8-re...@googlegroups.com, was...@google.com
Attention needed from Paolo Severini
Gyuyoung Kim voted and added 1 comment![]( "Open in Gerrit")
Votes added by Gyuyoung Kim
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Paolo Severini
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paolo Severini (Gerrit)
Dec 9, 2025, 6:24:01 AM12/9/25
to Gyuyoung Kim, Thibaud Michaud, Raphael Kubo da Costa, Abhijeet Kandalkar, Julie Jeongeun Kim, cobalt-...@google.com, v8-re...@googlegroups.com, was...@google.com
Attention needed from Gyuyoung Kim
Paolo Severini voted and added 1 comment![]( "Open in Gerrit")
Votes added by Paolo Severini
| Code-Review | +1 |
1 comment
File src/wasm/wasm-stack-wrapper-cache.cc
Line 7, Patchset 2 (Latest):
#include "src/base/logging.h"Paolo Severini . unresolved
Do we need this additional #include ?
Related details
Attention is currently required from:
- Gyuyoung Kim
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gyuyoung Kim (Gerrit)
Dec 9, 2025, 8:46:56 AM12/9/25
to Paolo Severini, Thibaud Michaud, Raphael Kubo da Costa, Abhijeet Kandalkar, Julie Jeongeun Kim, cobalt-...@google.com, v8-re...@googlegroups.com, was...@google.com
Gyuyoung Kim added 1 comment![]( "Open in Gerrit")
File src/wasm/wasm-stack-wrapper-cache.cc
Line 7, Patchset 2 (Latest):
#include "src/base/logging.h"Paolo Severini . resolved
Do we need this additional #include ?
Gyuyoung Kim
yes, the header file was included for UNREACHABLE() macro used in line #20.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gyuyoung Kim (Gerrit)
Dec 9, 2025, 8:47:27 AM12/9/25
to Paolo Severini, Thibaud Michaud, Raphael Kubo da Costa, Abhijeet Kandalkar, Julie Jeongeun Kim, cobalt-...@google.com, v8-re...@googlegroups.com, was...@google.com
Gyuyoung Kim removed a vote from this change![]( "Open in Gerrit")
Removed Auto-Submit+1 by Gyuyoung Kim <gyuy...@igalia.com>
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gyuyoung Kim (Gerrit)
Dec 9, 2025, 8:57:04 AM12/9/25
to V8 LUCI CQ, Paolo Severini, Thibaud Michaud, Raphael Kubo da Costa, Abhijeet Kandalkar, Julie Jeongeun Kim, cobalt-...@google.com, v8-re...@googlegroups.com, was...@google.com
Gyuyoung Kim voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Dec 9, 2025, 9:23:00 AM12/9/25
to Gyuyoung Kim, Paolo Severini, Thibaud Michaud, Raphael Kubo da Costa, Abhijeet Kandalkar, Julie Jeongeun Kim, cobalt-...@google.com, v8-re...@googlegroups.com, was...@google.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[wasm-interpreter] Fix build failure in WasmStackEntryWrapperCache::CompileWrapper()
https://crrev.com/c/7210774 introduced the stack wrapper cache and
implemented CompileWrapper() using
compiler::CompileWasmStackEntryWrapper(). However,
CompileWasmStackEntryWrapper() is only built when Turbofan is enabled,
which results in a linking error when building in wasm interpreter mode.
This CL resolves the issue by wrapping the function body with the
V8_ENABLE_TURBOFAN guard.
Bug: 388533754
Change-Id: I518140bc7099e256eb5a19927c078eb2f7b4dbfe
Reviewed-by: Paolo Severini <paol...@microsoft.com>
Commit-Queue: Gyuyoung Kim <gyuy...@igalia.com>
Reviewed-by: Thibaud Michaud <thib...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104201}
Files:
- M src/wasm/wasm-stack-wrapper-cache.cc
Change size: XS
Delta: 1 file changed, 5 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Thibaud Michaud, +1 by Paolo Severini
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages