[agents] Add extensions install script [v8/v8 : main]
Camillo Bruni (Gerrit)
Camillo Bruni added 1 comment![]( "Open in Gerrit")
PTAL (this should make it a bit more convenient to do more fine-grained installation of v8-specific mcps in the future)
Related details
- Marco Vitale
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Camillo Bruni (Gerrit)
Camillo Bruni added 1 comment![]( "Open in Gerrit")
@jgr...@chromium.org PTAL for the claude part ... since I don't have that on the corp machine to test.
Related details
- Jakob Linke
- Marco Vitale
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Camillo Bruni (Gerrit)
Camillo Bruni added 1 comment![]( "Open in Gerrit")
... alternatively we can rely on the `jetski plugin add` approach. not sure if ther is a similar thing for claude?
Related details
- Jakob Linke
- Marco Vitale
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marco Vitale (Gerrit)
Marco Vitale added 2 comments![]( "Open in Gerrit")
... alternatively we can rely on the `jetski plugin add` approach. not sure if ther is a similar thing for claude?
You mean having a "v8 plugin"?
- Camillo Bruni
- Jakob Linke
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Camillo Bruni (Gerrit)
Camillo Bruni added 2 comments![]( "Open in Gerrit")
Marco Vitale... alternatively we can rely on the `jetski plugin add` approach. not sure if ther is a similar thing for claude?
You mean having a "v8 plugin"?
separate ones. Like in chromium where we have different "extensions" or "plugins" that you can manually enable depending on how you work.
`agents/plugins/install.py`
The current approach is aligned with chrome:
https://source.chromium.org/chromium/chromium/src/+/main:agents/?q=agents%2F
There is currently no "plugins" but onyl "extensions" (and I agree, I'd prefer plugins here).
Related details
- Jakob Linke
- Marco Vitale
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marco Vitale (Gerrit)
Marco Vitale voted and added 3 comments![]( "Open in Gerrit")
Votes added by Marco Vitale
| Code-Review | +1 |
3 comments
Marco Vitale... alternatively we can rely on the `jetski plugin add` approach. not sure if ther is a similar thing for claude?
Camillo BruniYou mean having a "v8 plugin"?
separate ones. Like in chromium where we have different "extensions" or "plugins" that you can manually enable depending on how you work.
Imo the more modular the better.
lgtm
Camillo Bruni`agents/plugins/install.py`
The current approach is aligned with chrome:
https://source.chromium.org/chromium/chromium/src/+/main:agents/?q=agents%2FThere is currently no "plugins" but onyl "extensions" (and I agree, I'd prefer plugins here).
I think because the dir was thought for gemini cli, that calls plugins "extensions". But is fine for me!
Related details
- Camillo Bruni
- Jakob Linke
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Linke (Gerrit)
Jakob Linke added 2 comments![]( "Open in Gerrit")
"""Installs and manages configurations for extensions for Jetski UI.
This script registers Gemini extensions (MCP servers) directly into Jetski's
mcp_config.json configuration file.
"""```suggestion
"""Installs/removes V8 agent extensions (MCP servers) into supported agent platforms.
"""
```
.. or similar, now that it's not jetski-specific.
self.config_path = Path.home() / ".claude.json"Suggestion: instead of writing `~/.claude.json` directly, use
`claude mcp add-json <name> <json> --scope project`
and `claude mcp remove <name> --scope project` for removal.
Note: `add-json` doesn't overwrite, that needs a remove-add cycle.
Related details
- Camillo Bruni
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Linke (Gerrit)
Jakob Linke added 1 comment![]( "Open in Gerrit")
@jgr...@chromium.org PTAL for the claude part ... since I don't have that on the corp machine to test.
Sorry for the late review, somehow missed this cl.
Related details
- Camillo Bruni
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Camillo Bruni (Gerrit)
Camillo Bruni added 1 comment![]( "Open in Gerrit")
going to do another iteration of this with the latest chrome announcments which hopefully makes this a bit more in sync with non-jetski/gemini.
Related details
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marco Vitale (Gerrit)
Marco Vitale voted Code-Review+1![]( "Open in Gerrit")
- Camillo Bruni
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |