[profiler] Handle null dispatch handle in JSFunction [v8/v8 : main]
0 views
Skip to first unread message
Dominik Inführ (Gerrit)
Jun 9, 2026, 7:53:59 AM (yesterday) Jun 9
to Michael Lippautz, v8-s...@luci-project-accounts.iam.gserviceaccount.com, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Dominik Inführ added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Jun 9, 2026, 7:55:34 AM (yesterday) Jun 9
to Dominik Inführ, v8-s...@luci-project-accounts.iam.gserviceaccount.com, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ
Michael Lippautz voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
Jun 9, 2026, 7:55:52 AM (yesterday) Jun 9
to Michael Lippautz, v8-s...@luci-project-accounts.iam.gserviceaccount.com, devtools-...@chromium.org, v8-re...@googlegroups.com
Dominik Inführ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jun 9, 2026, 8:29:16 AM (yesterday) Jun 9
to Dominik Inführ, Michael Lippautz, devtools-...@chromium.org, v8-re...@googlegroups.com
v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[profiler] Handle null dispatch handle in JSFunction
With --heap-snapshot-on-gc=0 it is possible to trigger a GC while
a JSFunction isn't fully set up yet - when the dispatch handle is
still the null handle. This CL fixes this and handles this case
in the heap snapshot generator.
TAG=agy
CONV=16626ebf-8dda-4481-a5d4-d1c25d52b1b6
Bug: 521448931
Change-Id: I605263cc4c65ad2d0a4b79b060cddb5e173ec183
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Dominik Inführ <dinf...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#107852}
Files:
- M src/profiler/heap-snapshot-generator.cc
- A test/mjsunit/regress/regress-null-dispatch-table-in-heap-snapshot.js
Change size: S
Delta: 2 files changed, 16 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Hartmann (Gerrit)
Jun 9, 2026, 10:29:23 AM (23 hours ago) Jun 9
to v8-s...@luci-project-accounts.iam.gserviceaccount.com, Dominik Inführ, Michael Lippautz, devtools-...@chromium.org, v8-re...@googlegroups.com
Nico Hartmann has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages