[compiler] Skip coverage tracing for gap-move verification [v8/v8 : main]

0 views
Skip to first unread message

Clemens Backes (Gerrit)

unread,
Jan 20, 2026, 11:33:08 AMJan 20
to V8 LUCI CQ, Matthias Liedtke, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Matthias Liedtke

Clemens Backes added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Clemens Backes . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Matthias Liedtke
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Id27e7d530620a270adf84c2ce90e33d97480db1b
Gerrit-Change-Number: 7497553
Gerrit-PatchSet: 1
Gerrit-Owner: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
Gerrit-Attention: Matthias Liedtke <mlie...@chromium.org>
Gerrit-Comment-Date: Tue, 20 Jan 2026 16:33:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Matthias Liedtke (Gerrit)

unread,
Jan 23, 2026, 4:44:52 AMJan 23
to Clemens Backes, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Clemens Backes

Matthias Liedtke voted and added 1 comment

Votes added by Matthias Liedtke

Code-Review+1

1 comment

Patchset-level comments
Matthias Liedtke . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Clemens Backes
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Id27e7d530620a270adf84c2ce90e33d97480db1b
Gerrit-Change-Number: 7497553
Gerrit-PatchSet: 1
Gerrit-Owner: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
Gerrit-Attention: Clemens Backes <clem...@chromium.org>
Gerrit-Comment-Date: Fri, 23 Jan 2026 09:44:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Clemens Backes (Gerrit)

unread,
Jan 23, 2026, 8:58:53 AMJan 23
to Matthias Liedtke, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com

Clemens Backes voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Id27e7d530620a270adf84c2ce90e33d97480db1b
Gerrit-Change-Number: 7497553
Gerrit-PatchSet: 1
Gerrit-Owner: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
Gerrit-Comment-Date: Fri, 23 Jan 2026 13:58:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Jan 23, 2026, 9:38:09 AMJan 23
to Clemens Backes, Matthias Liedtke, dmercadi...@chromium.org, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[compiler] Skip coverage tracing for gap-move verification

The algorithm to verify gap moves can be very expensive. In the linked
issue it takes >90% of the overall execution time.
This change, together with https://crrev.com/c/7485635, will bring it
down to ~40%, i.e. a >2x speedup.

The hypothesis is that coverage information about this verification
algorithm is not interesting for the fuzzer to make progress in covering
the actually interesting parts.

This hopefully speeds up multiple fuzzers to allow for more executions
per second, making fuzzers more efficient and hence more effective
overall.

R=mlie...@chromium.org
Bug: 472782987
Change-Id: Id27e7d530620a270adf84c2ce90e33d97480db1b
Reviewed-by: Matthias Liedtke <mlie...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104880}
Files:
  • M src/compiler/backend/register-allocator-verifier.cc
Change size: S
Delta: 1 file changed, 8 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Matthias Liedtke
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Id27e7d530620a270adf84c2ce90e33d97480db1b
Gerrit-Change-Number: 7497553
Gerrit-PatchSet: 2
Gerrit-Owner: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages