Update EmbeddedFeedback with unaligned load/store [v8/v8 : main]
0 views
Skip to first unread message
Wei, Yuheng (Gerrit)
Dec 7, 2025, 9:43:45 PM12/7/25
to Liu Yu, AyeAye, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Liu Yu
Wei, Yuheng added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Liu Yu
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Toon Verwaest (Gerrit)
Dec 9, 2025, 9:49:15 AM12/9/25
to Liu Yu, Wei, Yuheng, AyeAye, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Liu Yu
Toon Verwaest voted and added 1 comment![]( "Open in Gerrit")
Votes added by Toon Verwaest
| Code-Review | +1 |
1 comment
File src/compiler/code-assembler.cc
Line 1060, Patchset 1 (Latest):
if (!UnalignedStoreSupported(rep)) {Toon Verwaest . unresolved
please flip the condition to avoid the negation
Related details
Attention is currently required from:
- Liu Yu
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liu Yu (Gerrit)
Dec 9, 2025, 10:07:43 PM12/9/25
to Toon Verwaest, Wei, Yuheng, AyeAye, dmercadi...@chromium.org, v8-re...@googlegroups.com
Liu Yu added 1 comment![]( "Open in Gerrit")
File src/compiler/code-assembler.cc
please flip the condition to avoid the negation
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liu Yu (Gerrit)
Dec 10, 2025, 2:15:28 AM12/10/25
to Toon Verwaest, Wei, Yuheng, AyeAye, dmercadi...@chromium.org, v8-re...@googlegroups.com
Liu Yu voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Dec 10, 2025, 2:49:43 AM12/10/25
to Liu Yu, Toon Verwaest, Wei, Yuheng, AyeAye, dmercadi...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: src/compiler/code-assembler.cc
Insertions: 4, Deletions: 4.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/compiler/code-assembler.h
Insertions: 3, Deletions: 2.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
Update EmbeddedFeedback with unaligned load/store
Change-Id: Id2647a2710fa9aafa6a2c97063b24756e4e41530
Commit-Queue: Liu Yu <li...@loongson.cn>
Reviewed-by: Toon Verwaest <verw...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104219}
Files:
- M src/codegen/code-stub-assembler.cc
- M src/compiler/code-assembler.cc
- M src/compiler/code-assembler.h
Change size: S
Delta: 3 files changed, 33 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Toon Verwaest
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages