[maglev] Improve constant handling for BuildCheckSmi and the Array ctor [v8/v8 : main]
0 views
Skip to first unread message
Jakob Linke (Gerrit)
Sep 26, 2025, 6:49:29 AM (23 hours ago) Sep 26
to AyeAye, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Jakob Linke added 1 comment![]( "Open in Gerrit")
File src/maglev/maglev-graph-builder.cc
Line 12304, Patchset 4 (Latest):
return TryGetFloat64Constant(v, TaggedToFloat64ConversionType::kOnlyNumber)Jakob Linke . unresolved
Maybe we also want to convert oddballs / holes here? Right now we are conservative and select PACKED_ELEMENTS for oddballs.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Gomes (Gerrit)
Sep 26, 2025, 7:41:12 AM (23 hours ago) Sep 26
to Jakob Linke, AyeAye, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Jakob Linke
Victor Gomes voted and added 2 comments![]( "Open in Gerrit")
Votes added by Victor Gomes
| Code-Review | +1 |
2 comments
Patchset-level comments
File src/maglev/maglev-graph-builder.cc
Line 12304, Patchset 4 (Latest):
return TryGetFloat64Constant(v, TaggedToFloat64ConversionType::kOnlyNumber)Jakob Linke . resolved
Maybe we also want to convert oddballs / holes here? Right now we are conservative and select PACKED_ELEMENTS for oddballs.
Victor Gomes
Acknowledged
Related details
Attention is currently required from:
- Jakob Linke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages