[wasm] Include more details on canonical types OOM [v8/v8 : main]

0 views
Skip to first unread message

Clemens Backes (Gerrit)

unread,
Dec 15, 2025, 12:31:30 PM (18 hours ago) Dec 15
to V8 LUCI CQ, Emanuel Ziegler, Jakob Kummerow, v8-re...@googlegroups.com, was...@google.com
Attention needed from Emanuel Ziegler

Clemens Backes added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Clemens Backes . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Emanuel Ziegler
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ied6b1431677a1f5e5d08938e55810e48792b7372
Gerrit-Change-Number: 7260279
Gerrit-PatchSet: 1
Gerrit-Owner: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Emanuel Ziegler <ecmzi...@chromium.org>
Gerrit-CC: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Attention: Emanuel Ziegler <ecmzi...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Dec 2025 17:31:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Jakob Kummerow (Gerrit)

unread,
Dec 15, 2025, 1:36:30 PM (17 hours ago) Dec 15
to Clemens Backes, Jakob Kummerow, V8 LUCI CQ, Emanuel Ziegler, v8-re...@googlegroups.com, was...@google.com
Attention needed from Clemens Backes and Emanuel Ziegler

Jakob Kummerow voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Clemens Backes
  • Emanuel Ziegler
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ied6b1431677a1f5e5d08938e55810e48792b7372
Gerrit-Change-Number: 7260279
Gerrit-PatchSet: 1
Gerrit-Owner: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Emanuel Ziegler <ecmzi...@chromium.org>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Attention: Emanuel Ziegler <ecmzi...@chromium.org>
Gerrit-Attention: Clemens Backes <clem...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Dec 2025 18:36:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Clemens Backes (Gerrit)

unread,
4:29 AM (2 hours ago) 4:29 AM
to Jakob Kummerow, V8 LUCI CQ, Emanuel Ziegler, v8-re...@googlegroups.com, was...@google.com
Attention needed from Emanuel Ziegler

Clemens Backes voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Emanuel Ziegler
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ied6b1431677a1f5e5d08938e55810e48792b7372
Gerrit-Change-Number: 7260279
Gerrit-PatchSet: 1
Gerrit-Owner: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Emanuel Ziegler <ecmzi...@chromium.org>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Attention: Emanuel Ziegler <ecmzi...@chromium.org>
Gerrit-Comment-Date: Tue, 16 Dec 2025 09:29:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
4:30 AM (2 hours ago) 4:30 AM
to Clemens Backes, Jakob Kummerow, Emanuel Ziegler, v8-re...@googlegroups.com, was...@google.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[wasm] Include more details on canonical types OOM

Split this out of https://crrev.com/c/7047048; it's good information to
have in OOM reports in any case.

R=ecmzi...@chromium.org
CC=jkum...@chromium.org
Bug: 42203975
Change-Id: Ied6b1431677a1f5e5d08938e55810e48792b7372
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104333}
Files:
  • M src/wasm/canonical-types.cc
Change size: S
Delta: 1 file changed, 16 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Jakob Kummerow
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ied6b1431677a1f5e5d08938e55810e48792b7372
Gerrit-Change-Number: 7260279
Gerrit-PatchSet: 2
Gerrit-Owner: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Emanuel Ziegler <ecmzi...@chromium.org>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages