[wasm][fuzzer] Generate less code after using all input bytes [v8/v8 : main]

0 views
Skip to first unread message

Clemens Backes (Gerrit)

unread,
9:58 AM (12 hours ago) 9:58 AM
to V8 LUCI CQ, Matthias Liedtke, v8-re...@googlegroups.com, was...@google.com
Attention needed from Matthias Liedtke

Clemens Backes added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Clemens Backes . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Matthias Liedtke
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I47caeadfc5f561e59f9a94f4b94d62fea927d5dd
Gerrit-Change-Number: 7452242
Gerrit-PatchSet: 1
Gerrit-Owner: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
Gerrit-Attention: Matthias Liedtke <mlie...@chromium.org>
Gerrit-Comment-Date: Mon, 12 Jan 2026 14:58:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Matthias Liedtke (Gerrit)

unread,
10:26 AM (12 hours ago) 10:26 AM
to Clemens Backes, V8 LUCI CQ, v8-re...@googlegroups.com, was...@google.com
Attention needed from Clemens Backes

Matthias Liedtke voted and added 1 comment

Votes added by Matthias Liedtke

Code-Review+1

1 comment

Patchset-level comments
Matthias Liedtke . resolved

LGTM, also good that we first try the likely-non-trapping ones before things like `ref_cast` etc.

Open in Gerrit

Related details

Attention is currently required from:
  • Clemens Backes
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I47caeadfc5f561e59f9a94f4b94d62fea927d5dd
Gerrit-Change-Number: 7452242
Gerrit-PatchSet: 1
Gerrit-Owner: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
Gerrit-Attention: Clemens Backes <clem...@chromium.org>
Gerrit-Comment-Date: Mon, 12 Jan 2026 15:26:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Clemens Backes (Gerrit)

unread,
10:38 AM (11 hours ago) 10:38 AM
to Matthias Liedtke, V8 LUCI CQ, v8-re...@googlegroups.com, was...@google.com

Clemens Backes voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I47caeadfc5f561e59f9a94f4b94d62fea927d5dd
Gerrit-Change-Number: 7452242
Gerrit-PatchSet: 1
Gerrit-Owner: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
Gerrit-Comment-Date: Mon, 12 Jan 2026 15:38:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
10:40 AM (11 hours ago) 10:40 AM
to Clemens Backes, Matthias Liedtke, v8-re...@googlegroups.com, was...@google.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[wasm][fuzzer] Generate less code after using all input bytes

`new_object` can (recursively) generate a lot of code, so it should not
be the default choice (at index 0) when running out of input bytes.

R=mlie...@chromium.org
Fixed: 472729752
Change-Id: I47caeadfc5f561e59f9a94f4b94d62fea927d5dd
Reviewed-by: Matthias Liedtke <mlie...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104644}
Files:
  • M src/wasm/fuzzing/random-module-generation.cc
Change size: XS
Delta: 1 file changed, 6 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Matthias Liedtke
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I47caeadfc5f561e59f9a94f4b94d62fea927d5dd
Gerrit-Change-Number: 7452242
Gerrit-PatchSet: 2
Gerrit-Owner: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages