[wasm] Preserve old undefined pattern for wasm wrappers [v8/v8 : main]
0 views
Skip to first unread message
Nico Hartmann (Gerrit)
Jan 8, 2026, 6:41:08 AM (24 hours ago) Jan 8
to Matthias Liedtke, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Matthias Liedtke
Nico Hartmann voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nico Hartmann
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Matthias Liedtke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matthias Liedtke (Gerrit)
Jan 8, 2026, 6:46:25 AM (24 hours ago) Jan 8
to Nico Hartmann, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Nico Hartmann
Matthias Liedtke voted and added 1 comment![]( "Open in Gerrit")
Votes added by Matthias Liedtke
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Attention is currently required from:
- Nico Hartmann
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Jan 8, 2026, 7:13:45 AM (23 hours ago) Jan 8
to Nico Hartmann, Matthias Liedtke, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[wasm] Preserve old undefined pattern for wasm wrappers
In order to avoid differential fuzzers reporting false positives
resulting form the the different bit patterns observed for undefined
nans when passed to wasm under the v8_enable_undefined_double flag, we
preserve temporarily preserve the old pattern when passing undefined to
wasm. This was missing for inlined wrappers, which this CL fixes.
Bug: 465215785
Change-Id: I98acf846e46c626c1ca840f4e6a5e19b719eddd1
Reviewed-by: Matthias Liedtke <mlie...@chromium.org>
Commit-Queue: Nico Hartmann <nicoha...@chromium.org>
Auto-Submit: Nico Hartmann <nicoha...@chromium.org>
Commit-Queue: Matthias Liedtke <mlie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104556}
Files:
- M src/builtins/wasm.tq
Change size: S
Delta: 1 file changed, 26 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Matthias Liedtke
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages