[regexp] Gate --trace-regexp-bytecodes behind disassembler [v8/v8 : main]
0 views
Skip to first unread message
Jakob Linke (Gerrit)
Jan 9, 2026, 4:28:22 AM (yesterday) Jan 9
to Patrick Thier, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Patrick Thier
Jakob Linke voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Patrick Thier
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Thier (Gerrit)
Jan 9, 2026, 4:32:50 AM (yesterday) Jan 9
to Jakob Linke, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Jakob Linke
Patrick Thier voted and added 2 comments![]( "Open in Gerrit")
Votes added by Patrick Thier
| Code-Review | +1 |
2 comments
Patchset-level comments
File src/regexp/regexp.cc
Line 1020, Patchset 1 (Latest):
if (V8_UNLIKELY(v8_flags.trace_regexp_bytecodes)) {
PrintF(
"Warning: --trace-regexp-bytecodes is enabled but does nothing without "
"`v8_enable_disassembler = true`\n");
}Patrick Thier . unresolved
Could we define the flag read-only in that case instead to avoid the runtime check? That's also how we already handle this case for tracing/graph-printing in other parts of the code (maglev, turboshaft, etc).
Related details
Attention is currently required from:
- Jakob Linke
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Linke (Gerrit)
Jan 9, 2026, 5:30:49 AM (yesterday) Jan 9
to AyeAye, Patrick Thier, V8 LUCI CQ, v8-flag...@chromium.org, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Patrick Thier
Jakob Linke voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jakob Linke
| Auto-Submit | +1 |
| Commit-Queue | +2 |
1 comment
File src/regexp/regexp.cc
Line 1020, Patchset 1:
if (V8_UNLIKELY(v8_flags.trace_regexp_bytecodes)) {
PrintF(
"Warning: --trace-regexp-bytecodes is enabled but does nothing without "
"`v8_enable_disassembler = true`\n");
}Patrick Thier . resolved
Could we define the flag read-only in that case instead to avoid the runtime check? That's also how we already handle this case for tracing/graph-printing in other parts of the code (maglev, turboshaft, etc).
Attention is currently required from:
- Patrick Thier
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Linke (Gerrit)
Jan 9, 2026, 5:30:57 AM (yesterday) Jan 9
to AyeAye, Patrick Thier, V8 LUCI CQ, v8-flag...@chromium.org, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Patrick Thier
Jakob Linke voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Patrick Thier
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Thier (Gerrit)
Jan 9, 2026, 5:32:09 AM (yesterday) Jan 9
to Jakob Linke, AyeAye, V8 LUCI CQ, v8-flag...@chromium.org, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Jakob Linke
Patrick Thier voted and added 1 comment![]( "Open in Gerrit")
Votes added by Patrick Thier
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Jakob Linke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Linke (Gerrit)
Jan 9, 2026, 8:42:24 AM (yesterday) Jan 9
to Patrick Thier, AyeAye, V8 LUCI CQ, v8-flag...@chromium.org, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Patrick Thier
Jakob Linke voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Patrick Thier
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Jan 9, 2026, 8:44:13 AM (yesterday) Jan 9
to Jakob Linke, Patrick Thier, AyeAye, v8-flag...@chromium.org, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: src/regexp/regexp.cc
Insertions: 3, Deletions: 1.
@@ -1015,8 +1015,10 @@
PrintF("\n\nRegexp match: /%s/\n\n",
regexp_data->source()->ToCString().get());
static constexpr uint32_t kMaxSubjectStringLength = 64;
+ uint32_t printed_string_length =
+ std::min(subject->length(), kMaxSubjectStringLength);
PrintF("\n\nSubject string: '%s'\n\n",
- subject->ToCString(0, kMaxSubjectStringLength).get());
+ subject->ToCString(0, printed_string_length).get());
}
#endif
```
Change information
Commit message:
[regexp] Gate --trace-regexp-bytecodes behind disassembler
.. instead of debug, since tracing is useful in release builds.
tracing.
Drive-by: Limit the length of the subject string we print as part of
Change-Id: I9be628989d4547a251117a64a81954ebe17b1378
Reviewed-by: Patrick Thier <pth...@chromium.org>
Commit-Queue: Jakob Linke <jgr...@chromium.org>
Auto-Submit: Jakob Linke <jgr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104599}
Files:
- M src/flags/flag-definitions.h
- M src/regexp/regexp-interpreter.cc
- M src/regexp/regexp.cc
Change size: S
Delta: 3 files changed, 17 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Patrick Thier
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages