[arm] Avoid nondeterministic NaNs via VLMA [v8/v8 : main]

0 views
Skip to first unread message

Clemens Backes (Gerrit)

unread,
Feb 3, 2026, 10:49:42 AM (18 hours ago) Feb 3
to V8 LUCI CQ, Nico Hartmann, dmercadi...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org
Attention needed from Nico Hartmann

Clemens Backes added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Clemens Backes . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Nico Hartmann
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I0de5bf65e021b4faa944d9a37d03110ef4a89fc7
Gerrit-Change-Number: 7539859
Gerrit-PatchSet: 1
Gerrit-Owner: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Attention: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Comment-Date: Tue, 03 Feb 2026 15:49:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Nico Hartmann (Gerrit)

unread,
Feb 3, 2026, 10:57:37 AM (17 hours ago) Feb 3
to Clemens Backes, V8 LUCI CQ, dmercadi...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org
Attention needed from Clemens Backes

Nico Hartmann voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Clemens Backes
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I0de5bf65e021b4faa944d9a37d03110ef4a89fc7
Gerrit-Change-Number: 7539859
Gerrit-PatchSet: 1
Gerrit-Owner: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Attention: Clemens Backes <clem...@chromium.org>
Gerrit-Comment-Date: Tue, 03 Feb 2026 15:57:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Clemens Backes (Gerrit)

unread,
Feb 3, 2026, 11:41:46 AM (17 hours ago) Feb 3
to Nico Hartmann, V8 LUCI CQ, dmercadi...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org

Clemens Backes voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I0de5bf65e021b4faa944d9a37d03110ef4a89fc7
Gerrit-Change-Number: 7539859
Gerrit-PatchSet: 1
Gerrit-Owner: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Comment-Date: Tue, 03 Feb 2026 16:41:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Feb 3, 2026, 11:46:42 AM (17 hours ago) Feb 3
to Clemens Backes, Nico Hartmann, dmercadi...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org

V8 LUCI CQ submitted the change

Change information

Commit message:
[arm] Avoid nondeterministic NaNs via VLMA

VLMA always has the multiplication on the right-hand side, so NaN
patterns from the left-hand side get propagated first. This is different
to the standard vmul + vadd instructions.
So disable this instruction selection pattern if deterministic NaNs are
required.

Note that we still use VLMA if the multiplication is on the right-hand
side.

R=nicoha...@chromium.org
Bug: 478553475
Change-Id: I0de5bf65e021b4faa944d9a37d03110ef4a89fc7
Reviewed-by: Nico Hartmann <nicoha...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105068}
Files:
  • M src/compiler/backend/arm/instruction-selector-arm.cc
  • A test/fuzzer/wasm/module/regress-478553475.wasm
Change size: XS
Delta: 2 files changed, 4 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Nico Hartmann
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I0de5bf65e021b4faa944d9a37d03110ef4a89fc7
Gerrit-Change-Number: 7539859
Gerrit-PatchSet: 2
Gerrit-Owner: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Nico Hartmann <nicoha...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages