[heap] Mask LoadFixedTypedArrayElement on Android [v8/v8 : main]

0 views
Skip to first unread message

Marco Vitale (Gerrit)

unread,
10:13 AM (11 hours ago) 10:13 AM
to Michael Lippautz, chrom...@appspot.gserviceaccount.com, Arash Kazemi, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com
Attention needed from Michael Lippautz

Marco Vitale voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Michael Lippautz
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I5dc1a24c9bc4298de4f2a32eb51170870d2c57e1
Gerrit-Change-Number: 7859411
Gerrit-PatchSet: 2
Gerrit-Owner: Marco Vitale <mrc...@chromium.org>
Gerrit-Reviewer: Arash Kazemi <ara...@chromium.org>
Gerrit-Reviewer: Marco Vitale <mrc...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>
Gerrit-Comment-Date: Tue, 19 May 2026 14:13:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Arash Kazemi (Gerrit)

unread,
10:18 AM (11 hours ago) 10:18 AM
to Marco Vitale, Michael Lippautz, chrom...@appspot.gserviceaccount.com, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com
Attention needed from Marco Vitale and Michael Lippautz

Arash Kazemi voted and added 1 comment

Votes added by Arash Kazemi

Code-Review+1

1 comment

Commit Message
Line 9, Patchset 2 (Latest):Following store operations, load operations on FixedArrays are now also
Arash Kazemi . unresolved

s/FixedArray/TypedArray/

I don't think this covers all load operations on TypedArrays, there are uses like Atomics or in the C++ runtime that are still not masked.

Open in Gerrit

Related details

Attention is currently required from:
  • Marco Vitale
  • Michael Lippautz
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: I5dc1a24c9bc4298de4f2a32eb51170870d2c57e1
    Gerrit-Change-Number: 7859411
    Gerrit-PatchSet: 2
    Gerrit-Owner: Marco Vitale <mrc...@chromium.org>
    Gerrit-Reviewer: Arash Kazemi <ara...@chromium.org>
    Gerrit-Reviewer: Marco Vitale <mrc...@chromium.org>
    Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
    Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>
    Gerrit-Attention: Marco Vitale <mrc...@chromium.org>
    Gerrit-Comment-Date: Tue, 19 May 2026 14:18:20 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Marco Vitale (Gerrit)

    unread,
    10:27 AM (11 hours ago) 10:27 AM
    to Michael Lippautz, chrom...@appspot.gserviceaccount.com, Arash Kazemi, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com
    Attention needed from Michael Lippautz

    Marco Vitale voted and added 1 comment

    Votes added by Marco Vitale

    Auto-Submit+1

    1 comment

    Commit Message
    Line 9, Patchset 2:Following store operations, load operations on FixedArrays are now also
    Arash Kazemi . resolved

    s/FixedArray/TypedArray/

    I don't think this covers all load operations on TypedArrays, there are uses like Atomics or in the C++ runtime that are still not masked.

    Marco Vitale

    Marked as resolved.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Michael Lippautz
    Submit Requirements:
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: v8/v8
      Gerrit-Branch: main
      Gerrit-Change-Id: I5dc1a24c9bc4298de4f2a32eb51170870d2c57e1
      Gerrit-Change-Number: 7859411
      Gerrit-PatchSet: 3
      Gerrit-Owner: Marco Vitale <mrc...@chromium.org>
      Gerrit-Reviewer: Arash Kazemi <ara...@chromium.org>
      Gerrit-Reviewer: Marco Vitale <mrc...@chromium.org>
      Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
      Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>
      Gerrit-Comment-Date: Tue, 19 May 2026 14:27:44 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Arash Kazemi <ara...@chromium.org>
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages