[acqrel] pass SeqCst in turboshaft for non-memory instructions [v8/v8 : main]
0 views
Skip to first unread message
Rezvan Mahdavi Hezaveh (Gerrit)
2:42 PM (5 hours ago) 2:42 PM
to Jakob Kummerow, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Jakob Kummerow
Rezvan Mahdavi Hezaveh added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Rezvan Mahdavi Hezaveh . resolved
We do not support AcqRel for non-memory instructions yet, but Acqrel memory ordering is a valid value to be used. So instead of having a DHCECK which may fail, let's pass SeqCst ordering specifically for now.
I checked the other non-memory instructions and looks like they ignore the memory ordering for now and `Set` is the only one required attention (because it calls `Store` with the memory_order)
This CL is ready for review, PTAL, thanks! (I cc'd you on the bug so you have context for reviewing this CL)
Related details
Attention is currently required from:
- Jakob Kummerow
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Kummerow (Gerrit)
3:44 PM (4 hours ago) 3:44 PM
to Rezvan Mahdavi Hezaveh, Jakob Kummerow, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Rezvan Mahdavi Hezaveh
Jakob Kummerow voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Rezvan Mahdavi Hezaveh
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rezvan Mahdavi Hezaveh (Gerrit)
4:17 PM (3 hours ago) 4:17 PM
to Jakob Kummerow, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com
Rezvan Mahdavi Hezaveh voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
4:19 PM (3 hours ago) 4:19 PM
to Rezvan Mahdavi Hezaveh, Jakob Kummerow, dmercadi...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[acqrel] pass SeqCst in turboshaft for non-memory instructions
We do not support AcqRel for non-memory operations, so the
memory order should be SeqCst.
Bug: 493171989
Change-Id: I59ca96a5fc78ca524e7c4916d06222425ef74d2b
Commit-Queue: Rezvan Mahdavi Hezaveh <rez...@chromium.org>
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105836}
Files:
- M src/compiler/turboshaft/wasm-lowering-reducer.h
- A test/mjsunit/regress/wasm/regress-493171989.js
Change size: S
Delta: 2 files changed, 40 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jakob Kummerow
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages