[json] Parser: Don't check all properties in descriptor array [v8/v8 : main]
0 views
Skip to first unread message
Patrick Thier (Gerrit)
Jan 9, 2026, 4:16:08 AM (yesterday) Jan 9
to Toon Verwaest, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Toon Verwaest
Patrick Thier added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Toon Verwaest
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Toon Verwaest (Gerrit)
Jan 9, 2026, 8:01:48 AM (yesterday) Jan 9
to Patrick Thier, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Patrick Thier
Toon Verwaest voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Patrick Thier
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Thier (Gerrit)
Jan 9, 2026, 8:53:26 AM (yesterday) Jan 9
to Toon Verwaest, V8 LUCI CQ, v8-re...@googlegroups.com
Patrick Thier voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Jan 9, 2026, 8:54:59 AM (yesterday) Jan 9
to Patrick Thier, Toon Verwaest, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[json] Parser: Don't check all properties in descriptor array
In the fast path for ParseJsonObjectProperties we previously tried to
scan as many properties as possible that are present in the feedbacks
descriptor array.
Instead we should only try to scan properties up to the maps number of
descriptors.
Change-Id: Id8271a323ea51f58172932ae62dbf138e212a164
Reviewed-by: Toon Verwaest <verw...@chromium.org>
Commit-Queue: Patrick Thier <pth...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104600}
Files:
- M src/json/json-parser.cc
- M src/json/json-parser.h
Change size: S
Delta: 2 files changed, 19 insertions(+), 19 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Toon Verwaest
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages