[DEPS] Clean up obsolete Android resources [v8/v8 : main]

0 views
Skip to first unread message

Michael Achenbach (Gerrit)

unread,
6:56 AM (4 hours ago) 6:56 AM
to Matthias Liedtke, Andrew Grieve, Sam Maier, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Matthias Liedtke

Michael Achenbach added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Michael Achenbach . resolved

PTAL. These things appear in our DEPS file, but not in Chromium's. There's a chance though that I break our internal Android perf testing. Hard to test this beforehand. Will keep my eyes peeled and revert in this case.

Open in Gerrit

Related details

Attention is currently required from:
  • Matthias Liedtke
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I44adc2bcb22755f52e5356ac749ac80ecfce74f8
Gerrit-Change-Number: 7457294
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Achenbach <mache...@chromium.org>
Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
Gerrit-Reviewer: Michael Achenbach <mache...@chromium.org>
Gerrit-CC: Andrew Grieve <agr...@chromium.org>
Gerrit-CC: Sam Maier <sma...@chromium.org>
Gerrit-Attention: Matthias Liedtke <mlie...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 11:56:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Achenbach (Gerrit)

unread,
6:56 AM (4 hours ago) 6:56 AM
to Matthias Liedtke, Andrew Grieve, Sam Maier, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Matthias Liedtke

Michael Achenbach voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Matthias Liedtke
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I44adc2bcb22755f52e5356ac749ac80ecfce74f8
Gerrit-Change-Number: 7457294
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Achenbach <mache...@chromium.org>
Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
Gerrit-Reviewer: Michael Achenbach <mache...@chromium.org>
Gerrit-CC: Andrew Grieve <agr...@chromium.org>
Gerrit-CC: Sam Maier <sma...@chromium.org>
Gerrit-Attention: Matthias Liedtke <mlie...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 11:56:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Matthias Liedtke (Gerrit)

unread,
7:37 AM (4 hours ago) 7:37 AM
to Michael Achenbach, Andrew Grieve, Sam Maier, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Michael Achenbach

Matthias Liedtke voted and added 1 comment

Votes added by Matthias Liedtke

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
Michael Achenbach . resolved

PTAL. These things appear in our DEPS file, but not in Chromium's. There's a chance though that I break our internal Android perf testing. Hard to test this beforehand. Will keep my eyes peeled and revert in this case.

Matthias Liedtke

We'll see. 😊

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Achenbach
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I44adc2bcb22755f52e5356ac749ac80ecfce74f8
Gerrit-Change-Number: 7457294
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Achenbach <mache...@chromium.org>
Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
Gerrit-Reviewer: Michael Achenbach <mache...@chromium.org>
Gerrit-CC: Andrew Grieve <agr...@chromium.org>
Gerrit-CC: Sam Maier <sma...@chromium.org>
Gerrit-Attention: Michael Achenbach <mache...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 12:37:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Michael Achenbach <mache...@chromium.org>
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
7:39 AM (4 hours ago) 7:39 AM
to Michael Achenbach, Matthias Liedtke, Andrew Grieve, Sam Maier, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[DEPS] Clean up obsolete Android resources
Bug: 475405270
Change-Id: I44adc2bcb22755f52e5356ac749ac80ecfce74f8
Cq-Include-Trybots: luci.v8.try:v8_android_arm64_p7_rel
Reviewed-by: Matthias Liedtke <mlie...@chromium.org>
Commit-Queue: Matthias Liedtke <mlie...@chromium.org>
Auto-Submit: Michael Achenbach <mache...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104668}
Files:
  • M DEPS
Change size: S
Delta: 1 file changed, 0 insertions(+), 24 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Matthias Liedtke
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I44adc2bcb22755f52e5356ac749ac80ecfce74f8
Gerrit-Change-Number: 7457294
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Achenbach <mache...@chromium.org>
Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
Gerrit-Reviewer: Michael Achenbach <mache...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages