[DEPS] Clean up obsolete Android resources [v8/v8 : main]
0 views
Skip to first unread message
Michael Achenbach (Gerrit)
6:56 AM (4 hours ago) 6:56 AM
to Matthias Liedtke, Andrew Grieve, Sam Maier, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Matthias Liedtke
Michael Achenbach added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Michael Achenbach . resolved
PTAL. These things appear in our DEPS file, but not in Chromium's. There's a chance though that I break our internal Android perf testing. Hard to test this beforehand. Will keep my eyes peeled and revert in this case.
Related details
Attention is currently required from:
- Matthias Liedtke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Achenbach (Gerrit)
6:56 AM (4 hours ago) 6:56 AM
to Matthias Liedtke, Andrew Grieve, Sam Maier, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Matthias Liedtke
Michael Achenbach voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Matthias Liedtke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matthias Liedtke (Gerrit)
7:37 AM (4 hours ago) 7:37 AM
to Michael Achenbach, Andrew Grieve, Sam Maier, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Michael Achenbach
Matthias Liedtke voted and added 1 comment![]( "Open in Gerrit")
Votes added by Matthias Liedtke
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Michael Achenbach . resolved
PTAL. These things appear in our DEPS file, but not in Chromium's. There's a chance though that I break our internal Android perf testing. Hard to test this beforehand. Will keep my eyes peeled and revert in this case.
Attention is currently required from:
- Michael Achenbach
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
7:39 AM (4 hours ago) 7:39 AM
to Michael Achenbach, Matthias Liedtke, Andrew Grieve, Sam Maier, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[DEPS] Clean up obsolete Android resources
Bug: 475405270
Change-Id: I44adc2bcb22755f52e5356ac749ac80ecfce74f8
Cq-Include-Trybots: luci.v8.try:v8_android_arm64_p7_rel
Reviewed-by: Matthias Liedtke <mlie...@chromium.org>
Commit-Queue: Matthias Liedtke <mlie...@chromium.org>
Auto-Submit: Michael Achenbach <mache...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104668}
Files:
- M DEPS
Change size: S
Delta: 1 file changed, 0 insertions(+), 24 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Matthias Liedtke
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages