[maglev non-eager inlining] Set a type for the "this" value [v8/v8 : main]

0 views
Skip to first unread message

Marja Hölttä (Gerrit)

unread,
7:35 AM (15 hours ago) 7:35 AM
to Victor Gomes, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes

Marja Hölttä added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Marja Hölttä . resolved

ptal

Open in Gerrit

Related details

Attention is currently required from:
  • Victor Gomes
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: If2d8011af17c10a8725dcc603aa846640d8dd354
Gerrit-Change-Number: 7451940
Gerrit-PatchSet: 1
Gerrit-Owner: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-Attention: Victor Gomes <victo...@chromium.org>
Gerrit-Comment-Date: Mon, 12 Jan 2026 12:35:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Victor Gomes (Gerrit)

unread,
7:38 AM (15 hours ago) 7:38 AM
to Marja Hölttä, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Marja Hölttä

Victor Gomes voted and added 1 comment

Votes added by Victor Gomes

Code-Review+1

1 comment

Patchset-level comments
Victor Gomes . resolved

LGTM!

Open in Gerrit

Related details

Attention is currently required from:
  • Marja Hölttä
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: If2d8011af17c10a8725dcc603aa846640d8dd354
Gerrit-Change-Number: 7451940
Gerrit-PatchSet: 1
Gerrit-Owner: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-Attention: Marja Hölttä <ma...@chromium.org>
Gerrit-Comment-Date: Mon, 12 Jan 2026 12:38:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Marja Hölttä (Gerrit)

unread,
7:38 AM (15 hours ago) 7:38 AM
to Victor Gomes, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org

Marja Hölttä voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: If2d8011af17c10a8725dcc603aa846640d8dd354
Gerrit-Change-Number: 7451940
Gerrit-PatchSet: 1
Gerrit-Owner: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-Comment-Date: Mon, 12 Jan 2026 12:38:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
7:47 AM (14 hours ago) 7:47 AM
to Marja Hölttä, Victor Gomes, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org

V8 LUCI CQ submitted the change

Change information

Commit message:
[maglev non-eager inlining] Set a type for the "this" value
Bug: 431933185
Change-Id: If2d8011af17c10a8725dcc603aa846640d8dd354
Reviewed-by: Victor Gomes <victo...@chromium.org>
Commit-Queue: Marja Hölttä <ma...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104633}
Files:
  • M src/maglev/maglev-graph-optimizer.cc
Change size: S
Delta: 1 file changed, 10 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Victor Gomes
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: If2d8011af17c10a8725dcc603aa846640d8dd354
Gerrit-Change-Number: 7451940
Gerrit-PatchSet: 2
Gerrit-Owner: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
open
diffy
satisfied_requirement

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
8:45 AM (13 hours ago) 8:45 AM
to Marja Hölttä, V8 LUCI CQ, Victor Gomes, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/jetstream-main.crossbench complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/10e40936b10000

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: If2d8011af17c10a8725dcc603aa846640d8dd354
Gerrit-Change-Number: 7451940
Gerrit-PatchSet: 2
Gerrit-Owner: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-Comment-Date: Mon, 12 Jan 2026 13:45:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
10:05 AM (12 hours ago) 10:05 AM
to Marja Hölttä, V8 LUCI CQ, Victor Gomes, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org

Message from chrom...@appspot.gserviceaccount.com

😿 Job mac-m1_mini_2020-perf/jetstream-main.crossbench failed.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/13fc9a87b10000

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: If2d8011af17c10a8725dcc603aa846640d8dd354
Gerrit-Change-Number: 7451940
Gerrit-PatchSet: 2
Gerrit-Owner: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-Comment-Date: Mon, 12 Jan 2026 15:05:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages