[test] Refix flaky StreamingWithIsolateScriptCacheClearingRootSFI [v8/v8 : main]
0 views
Skip to first unread message
Nikolaos Papaspyrou (Gerrit)
Jun 9, 2026, 12:44:17 PM (17 hours ago) Jun 9
to Omer Katz, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com
Attention needed from Omer Katz
Nikolaos Papaspyrou voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nikolaos Papaspyrou
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Nikolaos Papaspyrou . resolved
I was just curious to see why https://crrev.com/c/7895590 did not work.
Related details
Attention is currently required from:
- Omer Katz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Omer Katz (Gerrit)
Jun 9, 2026, 2:20:42 PM (15 hours ago) Jun 9
to Nikolaos Papaspyrou, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com
Attention needed from Nikolaos Papaspyrou
Omer Katz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Omer Katz
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Nikolaos Papaspyrou
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nikolaos Papaspyrou (Gerrit)
4:23 AM (1 hour ago) 4:23 AM
to Omer Katz, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com
Nikolaos Papaspyrou voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
4:26 AM (1 hour ago) 4:26 AM
to Nikolaos Papaspyrou, Omer Katz, v8-re...@googlegroups.com
v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[test] Refix flaky StreamingWithIsolateScriptCacheClearingRootSFI
This CL:
1. Brings back the changes from Omer's https://crrev.com/c/7895590
that were reverted by https://crrev.com/c/7903661.
2. Invokes a GC directly from C++, instead of using the gc(), thus
respecting the scope that disables CSS.
3. Re-enables the test for all configurations.
Bug: 518833307
Change-Id: I82f16b66fc83ad7271d4b94906dbb9b087555dad
Commit-Queue: Nikolaos Papaspyrou <niko...@chromium.org>
Reviewed-by: Omer Katz <omer...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#107875}
Files:
- M test/cctest/test-api.cc
Change size: S
Delta: 1 file changed, 19 insertions(+), 20 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Omer Katz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages