[runtime] Make sure lookup keys in SetPrototypeProperties are names or numbers [v8/v8 : main]

0 views

Skip to first unread message

Toon Verwaest (Gerrit)

unread,

Nov 18, 2025, 10:59:32 AM (22 hours ago) Nov 18

to Raphael Herouart, Leszek Swirski, V8 LUCI CQ, v8-re...@googlegroups.com

Attention needed from Leszek Swirski and Raphael Herouart

Toon Verwaest added 1 comment

File src/runtime/runtime-literals.cc

Line 769, Patchset 1 (Latest): if (!IsName(*key) && !IsNumber(*key)) {

Toon Verwaest . unresolved

I don't think this should happen given how this is used. What about making this a `CHECK`.

Open in Gerrit

Related details

Attention is currently required from:

Leszek Swirski
Raphael Herouart

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Raphael Herouart (Gerrit)

unread,

Nov 18, 2025, 11:12:49 AM (21 hours ago) Nov 18

to Toon Verwaest, Leszek Swirski, V8 LUCI CQ, v8-re...@googlegroups.com

Attention needed from Leszek Swirski and Toon Verwaest

Raphael Herouart added 1 comment

File src/runtime/runtime-literals.cc

Line 769, Patchset 1: if (!IsName(*key) && !IsNumber(*key)) {

Toon Verwaest . resolved

I don't think this should happen given how this is used. What about making this a `CHECK`.

Raphael Herouart

Done

Open in Gerrit

Related details

Attention is currently required from:

Leszek Swirski
Toon Verwaest

Submit Requirements:

Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Toon Verwaest (Gerrit)

unread,

5:32 AM (3 hours ago) 5:32 AM

to Raphael Herouart, Leszek Swirski, V8 LUCI CQ, v8-re...@googlegroups.com

Attention needed from Leszek Swirski and Raphael Herouart

Toon Verwaest added 1 comment

File src/runtime/runtime-literals.cc

Line 769, Patchset 3 (Latest): CHECK(IsName(*key) || IsNumber(*key));

Toon Verwaest . unresolved

I don't even think you're supposed to support Numbers? Don't you only support InternalizedStrings that aren't indices?

Open in Gerrit

Related details

Attention is currently required from:

Leszek Swirski
Raphael Herouart

Submit Requirements:

Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages