[tiering] Fix DeoptExitIsInsideOsrLoop for Maglev [v8/v8 : main]

0 views
Skip to first unread message

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
May 21, 2025, 4:03:43 AM5/21/25
to Olivier Flückiger, V8 LUCI CQ, Toon Verwaest, v8-re...@googlegroups.com

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/jetstream2 complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/11536de2110000

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Iaa79a4ae00c41a9779a1d9fa1df5543f3832820a
Gerrit-Change-Number: 6565354
Gerrit-PatchSet: 3
Gerrit-Owner: Olivier Flückiger <ol...@chromium.org>
Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>
Gerrit-Comment-Date: Wed, 21 May 2025 08:03:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Olivier Flückiger (Gerrit)

unread,
May 22, 2025, 5:26:53 AM5/22/25
to Toon Verwaest, V8 LUCI CQ, chrom...@appspot.gserviceaccount.com, v8-re...@googlegroups.com
Attention needed from Olivier Flückiger and Toon Verwaest

Message from Olivier Flückiger

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • Olivier Flückiger
  • Toon Verwaest
Submit Requirements:
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Iaa79a4ae00c41a9779a1d9fa1df5543f3832820a
Gerrit-Change-Number: 6565354
Gerrit-PatchSet: 3
Gerrit-Owner: Olivier Flückiger <ol...@chromium.org>
Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>
Gerrit-Attention: Olivier Flückiger <ol...@chromium.org>
Gerrit-Attention: Toon Verwaest <verw...@chromium.org>
Gerrit-Comment-Date: Thu, 22 May 2025 09:26:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Toon Verwaest (Gerrit)

unread,
May 22, 2025, 5:29:55 AM5/22/25
to Olivier Flückiger, V8 LUCI CQ, chrom...@appspot.gserviceaccount.com, v8-re...@googlegroups.com
Attention needed from Olivier Flückiger

Toon Verwaest voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Olivier Flückiger
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Iaa79a4ae00c41a9779a1d9fa1df5543f3832820a
Gerrit-Change-Number: 6565354
Gerrit-PatchSet: 3
Gerrit-Owner: Olivier Flückiger <ol...@chromium.org>
Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>
Gerrit-Attention: Olivier Flückiger <ol...@chromium.org>
Gerrit-Comment-Date: Thu, 22 May 2025 09:29:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
May 22, 2025, 6:02:38 AM5/22/25
to Olivier Flückiger, Toon Verwaest, chrom...@appspot.gserviceaccount.com, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[tiering] Fix DeoptExitIsInsideOsrLoop for Maglev

Maglev OSR never jumps above the OSR'd loop.
Bug: 328115456
Change-Id: Iaa79a4ae00c41a9779a1d9fa1df5543f3832820a
Commit-Queue: Toon Verwaest <verw...@chromium.org>
Auto-Submit: Olivier Flückiger <ol...@chromium.org>
Reviewed-by: Toon Verwaest <verw...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#100418}
Files:
  • M src/deoptimizer/deoptimizer.cc
  • M src/deoptimizer/deoptimizer.h
  • M src/runtime/runtime-compiler.cc
Change size: S
Delta: 3 files changed, 15 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Toon Verwaest
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Iaa79a4ae00c41a9779a1d9fa1df5543f3832820a
Gerrit-Change-Number: 6565354
Gerrit-PatchSet: 4
Gerrit-Owner: Olivier Flückiger <ol...@chromium.org>
Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages