[csa] Add inline fast paths for CAST checks [v8/v8 : main]
0 views
Skip to first unread message
Leszek Swirski (Gerrit)
Dec 9, 2025, 9:31:36 AM12/9/25
to Nico Hartmann, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Nico Hartmann
Leszek Swirski voted and added 1 comment![]( "Open in Gerrit")
Votes added by Leszek Swirski
| Auto-Submit | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Leszek Swirski . resolved
PTAL, something to think about in TSA too
Related details
Attention is currently required from:
- Nico Hartmann
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Hartmann (Gerrit)
Dec 9, 2025, 9:50:27 AM12/9/25
to Leszek Swirski, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Leszek Swirski
Nico Hartmann voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nico Hartmann
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Attention is currently required from:
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Dec 9, 2025, 9:52:09 AM12/9/25
to Leszek Swirski, Nico Hartmann, dmercadi...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[csa] Add inline fast paths for CAST checks
Speed up CAST type checks for common types by using inlined CSA type
checks rather than unconditionally entering C++ for CheckObjectType.
Failed checks still fall through into C++, so any failure error messages
should stay unchanged.
This does require moving CAST and CheckedNode into CSA from
CodeAssembler, since the type check predicates are CodeStubAssembler
code. The few CASTs that were in CodeAssembler have to become either raw
Node*s, or UncheckedCasts, with CSA wrappers that do the proper CASTing.
Change-Id: I91436292ea78e7bec6ead267e4237b8e28705025
Reviewed-by: Nico Hartmann <nicoha...@chromium.org>
Auto-Submit: Leszek Swirski <les...@chromium.org>
Commit-Queue: Nico Hartmann <nicoha...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104203}
Files:
- M src/builtins/builtins-utils-gen.h
- M src/codegen/code-stub-assembler.cc
- M src/codegen/code-stub-assembler.h
- M src/compiler/code-assembler.cc
- M src/compiler/code-assembler.h
- M src/torque/csa-generator.cc
- M test/cctest/compiler/test-code-assembler.cc
Change size: L
Delta: 7 files changed, 322 insertions(+), 143 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nico Hartmann
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
Dec 9, 2025, 10:08:20 AM12/9/25
to V8 LUCI CQ, Nico Hartmann, dmercadi...@chromium.org, v8-re...@googlegroups.com
Leszek Swirski has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages