Remove a few unneeded V8_CC_MSVC checks [v8/v8 : main]
0 views
Skip to first unread message
Nico Weber (Gerrit)
Jan 11, 2026, 7:41:43 PM (yesterday) Jan 11
to Nico Weber, Jakob Kummerow, V8 LUCI CQ, hongcha...@chromium.org, rtoy+...@chromium.org, v8-re...@googlegroups.com
Attention needed from Jakob Kummerow
Nico Weber voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nico Weber
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Jakob Kummerow
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Weber (Gerrit)
Jan 11, 2026, 7:42:14 PM (yesterday) Jan 11
to Nico Weber, Nico Hartmann, Jakob Kummerow, V8 LUCI CQ, hongcha...@chromium.org, rtoy+...@chromium.org, v8-re...@googlegroups.com
Attention needed from Jakob Kummerow and Nico Hartmann
Nico Weber voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nico Weber
| Auto-Submit | +0 |
1 comment
Patchset-level comments
Attention is currently required from:
- Jakob Kummerow
- Nico Hartmann
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Hartmann (Gerrit)
3:26 AM (19 hours ago) 3:26 AM
to Nico Weber, Jakob Kummerow, V8 LUCI CQ, hongcha...@chromium.org, rtoy+...@chromium.org, v8-re...@googlegroups.com
Attention needed from Jakob Kummerow and Nico Weber
Nico Hartmann voted and added 2 comments![]( "Open in Gerrit")
Votes added by Nico Hartmann
| Code-Review | +1 |
2 comments
Patchset-level comments
Nico Hartmann . resolved
LGTM % comment
File src/objects/tagged-field.h
Line 99, Patchset 1 (Parent):
// FLEXIBLE_ARRAY_MEMBER(T, name) represents a marker for a variable-sized
// suffix of members for a type.
//
// It behaves as if it were the last member of a class, and creates an accessor
// for `T* name()`.
//
// This macro is used instead of the C99 flexible array member syntax, because
//
// a) That syntax is only in C++ as an extension,
// b) On all our major compilers, it doesn't allow the class to have
// subclasses (which means it doesn't work for e.g. TaggedArrayBase or
// BigIntBase),
// c) The similar zero-length array extension _also_ doesn't allow subclasses
// on some compilers (specifically, MSVC).
//
// On compilers that do support zero length arrays (i.e. not MSVC), we use one
// of these instead of `this` pointer fiddling. This gives LLVM better
// information for optimization, and gives us the warnings we'd want to have
// (e.g. only allowing one FAM in a class, ensuring that OFFSET_OF_DATA_START is
// only used on classes with a FAM) on clang -- the MSVC version then doesn't
// check the same constraints, and relies on the code being equivalent enough.Nico Hartmann . unresolved
We should keep most of this comment
Related details
Attention is currently required from:
- Jakob Kummerow
- Nico Weber
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Kummerow (Gerrit)
4:38 AM (17 hours ago) 4:38 AM
to Nico Weber, Jakob Kummerow, Nico Hartmann, V8 LUCI CQ, hongcha...@chromium.org, rtoy+...@chromium.org, v8-re...@googlegroups.com
Attention needed from Nico Weber
Jakob Kummerow voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jakob Kummerow
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Nico Weber
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Weber (Gerrit)
1:33 PM (9 hours ago) 1:33 PM
to Nico Weber, Jakob Kummerow, Nico Hartmann, V8 LUCI CQ, hongcha...@chromium.org, rtoy+...@chromium.org, v8-re...@googlegroups.com
Nico Weber voted and added 2 comments![]( "Open in Gerrit")
Votes added by Nico Weber
| Auto-Submit | +1 |
2 comments
Patchset-level comments
File src/objects/tagged-field.h
Line 99, Patchset 1 (Parent):
// FLEXIBLE_ARRAY_MEMBER(T, name) represents a marker for a variable-sized
// suffix of members for a type.
//
// It behaves as if it were the last member of a class, and creates an accessor
// for `T* name()`.
//
// This macro is used instead of the C99 flexible array member syntax, because
//
// a) That syntax is only in C++ as an extension,
// b) On all our major compilers, it doesn't allow the class to have
// subclasses (which means it doesn't work for e.g. TaggedArrayBase or
// BigIntBase),
// c) The similar zero-length array extension _also_ doesn't allow subclasses
// on some compilers (specifically, MSVC).
//
// On compilers that do support zero length arrays (i.e. not MSVC), we use one
// of these instead of `this` pointer fiddling. This gives LLVM better
// information for optimization, and gives us the warnings we'd want to have
// (e.g. only allowing one FAM in a class, ensuring that OFFSET_OF_DATA_START is
// only used on classes with a FAM) on clang -- the MSVC version then doesn't
// check the same constraints, and relies on the code being equivalent enough.Nico Hartmann . resolved
We should keep most of this comment
Nico Weber
I put it back with some minor rewording.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Weber (Gerrit)
3:22 PM (7 hours ago) 3:22 PM
to Nico Weber, Jakob Kummerow, Nico Hartmann, V8 LUCI CQ, hongcha...@chromium.org, rtoy+...@chromium.org, v8-re...@googlegroups.com
Nico Weber voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
0 new messages