[maglev][cleanup] Refactor GetStaticNodeType [v8/v8 : main]

0 views
Skip to first unread message

Victor Gomes (Gerrit)

unread,
Oct 22, 2025, 9:48:06 AM (yesterday) Oct 22
to Marja Hölttä, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Marja Hölttä

Victor Gomes voted and added 1 comment

Votes added by Victor Gomes

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Victor Gomes . resolved

PTAL!

Open in Gerrit

Related details

Attention is currently required from:
  • Marja Hölttä
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Id3429330295498de3f883c77a5b2c921008f4198
Gerrit-Change-Number: 7073371
Gerrit-PatchSet: 3
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-Attention: Marja Hölttä <ma...@chromium.org>
Gerrit-Comment-Date: Wed, 22 Oct 2025 13:48:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Marja Hölttä (Gerrit)

unread,
2:28 AM (9 hours ago) 2:28 AM
to Victor Gomes, V8 LUCI CQ, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes

Marja Hölttä voted and added 1 comment

Votes added by Marja Hölttä

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
Marja Hölttä . resolved

yess, this is great! lgtm! did you check whether this actually improves performance, since we now have types for things that were in the default-whatever-branch of the switch?

Open in Gerrit

Related details

Attention is currently required from:
  • Victor Gomes
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Id3429330295498de3f883c77a5b2c921008f4198
Gerrit-Change-Number: 7073371
Gerrit-PatchSet: 3
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-Attention: Victor Gomes <victo...@chromium.org>
Gerrit-Comment-Date: Thu, 23 Oct 2025 06:27:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
2:30 AM (9 hours ago) 2:30 AM
to Victor Gomes, Marja Hölttä, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org

V8 LUCI CQ submitted the change

Change information

Commit message:
[maglev][cleanup] Refactor GetStaticNodeType

This makes static type a method in the node class.
Change-Id: Id3429330295498de3f883c77a5b2c921008f4198
Auto-Submit: Victor Gomes <victo...@chromium.org>
Reviewed-by: Marja Hölttä <ma...@chromium.org>
Commit-Queue: Marja Hölttä <ma...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103302}
Files:
  • M src/compiler/turboshaft/turbolev-graph-builder.cc
  • M src/maglev/maglev-code-generator.cc
  • M src/maglev/maglev-graph-builder.cc
  • M src/maglev/maglev-ir.cc
  • M src/maglev/maglev-ir.h
Change size: L
Delta: 5 files changed, 156 insertions(+), 319 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Marja Hölttä
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Id3429330295498de3f883c77a5b2c921008f4198
Gerrit-Change-Number: 7073371
Gerrit-PatchSet: 4
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
open
diffy
satisfied_requirement

Victor Gomes (Gerrit)

unread,
2:49 AM (9 hours ago) 2:49 AM
to V8 LUCI CQ, Marja Hölttä, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org

Victor Gomes added 1 comment

Patchset-level comments
Marja Hölttä . resolved

yess, this is great! lgtm! did you check whether this actually improves performance, since we now have types for things that were in the default-whatever-branch of the switch?

Victor Gomes

No, I followed the switch, this should be perf neutral.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Id3429330295498de3f883c77a5b2c921008f4198
Gerrit-Change-Number: 7073371
Gerrit-PatchSet: 4
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-Comment-Date: Thu, 23 Oct 2025 06:48:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marja Hölttä <ma...@chromium.org>
satisfied_requirement
open
diffy

Darius Mercadier (Gerrit)

unread,
3:08 AM (8 hours ago) 3:08 AM
to V8 LUCI CQ, Victor Gomes, Marja Hölttä, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org

Darius Mercadier added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Darius Mercadier . unresolved

Since the vast majority of `types()` function are static, it would make sense to make them actually `static constexpr` and make GetStaticTypeFor use the static type from the NodeT type rather than calling the `type()` method on the nodes.
(Clang might already optimize this, but making things explicitly constexpr can't hurt :) )

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Id3429330295498de3f883c77a5b2c921008f4198
Gerrit-Change-Number: 7073371
Gerrit-PatchSet: 4
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-CC: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Comment-Date: Thu, 23 Oct 2025 07:08:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Victor Gomes (Gerrit)

unread,
3:19 AM (8 hours ago) 3:19 AM
to V8 LUCI CQ, Darius Mercadier, Marja Hölttä, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org

Victor Gomes added 1 comment

Patchset-level comments
Darius Mercadier . resolved

Since the vast majority of `types()` function are static, it would make sense to make them actually `static constexpr` and make GetStaticTypeFor use the static type from the NodeT type rather than calling the `type()` method on the nodes.
(Clang might already optimize this, but making things explicitly constexpr can't hurt :) )

Victor Gomes

Yeah, I thought about that, but I was pretty sure clang would optimize all anyways. Will do in a follow up.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Id3429330295498de3f883c77a5b2c921008f4198
Gerrit-Change-Number: 7073371
Gerrit-PatchSet: 4
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-CC: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Comment-Date: Thu, 23 Oct 2025 07:19:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Darius Mercadier <dmerc...@chromium.org>
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages