Auto-Submit | +1 |
Commit-Queue | +1 |
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Code-Review | +1 |
Commit-Queue | +2 |
yess, this is great! lgtm! did you check whether this actually improves performance, since we now have types for things that were in the default-whatever-branch of the switch?
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
[maglev][cleanup] Refactor GetStaticNodeType
This makes static type a method in the node class.
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
yess, this is great! lgtm! did you check whether this actually improves performance, since we now have types for things that were in the default-whatever-branch of the switch?
No, I followed the switch, this should be perf neutral.
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Since the vast majority of `types()` function are static, it would make sense to make them actually `static constexpr` and make GetStaticTypeFor use the static type from the NodeT type rather than calling the `type()` method on the nodes.
(Clang might already optimize this, but making things explicitly constexpr can't hurt :) )
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Since the vast majority of `types()` function are static, it would make sense to make them actually `static constexpr` and make GetStaticTypeFor use the static type from the NodeT type rather than calling the `type()` method on the nodes.
(Clang might already optimize this, but making things explicitly constexpr can't hurt :) )
Yeah, I thought about that, but I was pretty sure clang would optimize all anyways. Will do in a follow up.
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |