Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
📍 Job mac-m1_mini_2020-perf/jetstream2 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/10b13548510000
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
📍 Job mac-m1_mini_2020-perf/speedometer3 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/10b3ceb0d10000
return AllocatorLimitOnMaxOldGenerationSize(physical_memory);
This lacks scaling for 0-8G devices completely? Am I missing something?
Wasn't the suggestion on the bug to have scaled heap from 0-8G with a ceil of 4G (~cage size) for 8G+?
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
return AllocatorLimitOnMaxOldGenerationSize(physical_memory);
This lacks scaling for 0-8G devices completely? Am I missing something?
Wasn't the suggestion on the bug to have scaled heap from 0-8G with a ceil of 4G (~cage size) for 8G+?
MaxOldGenerationSizeFromPhysicalMemory() is the upper bound used for max heap size.
The actual computation happens here:
https://source.chromium.org/chromium/chromium/src/+/main:v8/src/heap/heap.cc;l=349?q=MaxOldGenerationSizeFromPhysicalMemory&ss=chromium
Which on 64bit is effectively clamp(physical_memory / 2, lower_bound, 4Gb)
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Will defer to Dominik here as I won't have time to go through the calling code today.
return AllocatorLimitOnMaxOldGenerationSize(physical_memory);
Etienne Pierre-DorayThis lacks scaling for 0-8G devices completely? Am I missing something?
Wasn't the suggestion on the bug to have scaled heap from 0-8G with a ceil of 4G (~cage size) for 8G+?
MaxOldGenerationSizeFromPhysicalMemory() is the upper bound used for max heap size.
The actual computation happens here:
https://source.chromium.org/chromium/chromium/src/+/main:v8/src/heap/heap.cc;l=349?q=MaxOldGenerationSizeFromPhysicalMemory&ss=chromiumWhich on 64bit is effectively clamp(physical_memory / 2, lower_bound, 4Gb)
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
return AllocatorLimitOnMaxOldGenerationSize(physical_memory);
Etienne Pierre-DorayThis lacks scaling for 0-8G devices completely? Am I missing something?
Wasn't the suggestion on the bug to have scaled heap from 0-8G with a ceil of 4G (~cage size) for 8G+?
Michael LippautzMaxOldGenerationSizeFromPhysicalMemory() is the upper bound used for max heap size.
The actual computation happens here:
https://source.chromium.org/chromium/chromium/src/+/main:v8/src/heap/heap.cc;l=349?q=MaxOldGenerationSizeFromPhysicalMemory&ss=chromiumWhich on 64bit is effectively clamp(physical_memory / 2, lower_bound, 4Gb)
Thanks for clarifying.
It feels the heap limits computation is already quite convoluted and we now add an additional branch/flag. Can we shortcut this and move this logic to ResourceConstraints::ConfigureDefaults directly for your case without going through all the other methods anymore?
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |