[regexp] Extract peepholes sequences into a global structure [v8/v8 : main]
0 views
Skip to first unread message
Jakob Linke (Gerrit)
Jan 8, 2026, 7:03:04 AM (23 hours ago) Jan 8
to Patrick Thier, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Patrick Thier
Jakob Linke voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jakob Linke
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Patrick Thier
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Thier (Gerrit)
Jan 8, 2026, 7:17:54 AM (23 hours ago) Jan 8
to Jakob Linke, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Jakob Linke
Patrick Thier voted and added 2 comments![]( "Open in Gerrit")
Votes added by Patrick Thier
| Code-Review | +1 |
2 comments
Patchset-level comments
Patrick Thier . resolved
Very nice! LGTM
Commit Message
Line 11, Patchset 4 (Latest):
Note we use DEFINE_LAZY_LEAKY_OBJECT_GETTER, so the underlying dataPatrick Thier . resolved
TIL
Related details
Attention is currently required from:
- Jakob Linke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Linke (Gerrit)
Jan 8, 2026, 7:43:25 AM (23 hours ago) Jan 8
to Patrick Thier, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Jakob Linke voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Jan 8, 2026, 7:45:44 AM (23 hours ago) Jan 8
to Jakob Linke, Patrick Thier, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[regexp] Extract peepholes sequences into a global structure
.. to avoid creating them once per compilation / once per pass.
Note we use DEFINE_LAZY_LEAKY_OBJECT_GETTER, so the underlying data
structures are leaked (and cleaned up by the OS when the process exits).
Bug: 433891213
Change-Id: I990360bc926891801ac866620527539553828e16
Reviewed-by: Patrick Thier <pth...@chromium.org>
Commit-Queue: Jakob Linke <jgr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104558}
Files:
- M src/regexp/regexp-bytecode-peephole.cc
Change size: M
Delta: 1 file changed, 63 insertions(+), 60 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Patrick Thier
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages