[regexp] Extract peepholes sequences into a global structure [v8/v8 : main]

0 views
Skip to first unread message

Jakob Linke (Gerrit)

unread,
Jan 8, 2026, 7:03:04 AM (23 hours ago) Jan 8
to Patrick Thier, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Patrick Thier

Jakob Linke voted and added 1 comment

Votes added by Jakob Linke

Commit-Queue+1

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Patrick Thier
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I990360bc926891801ac866620527539553828e16
Gerrit-Change-Number: 7414579
Gerrit-PatchSet: 4
Gerrit-Owner: Jakob Linke <jgr...@chromium.org>
Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
Gerrit-Reviewer: Patrick Thier <pth...@chromium.org>
Gerrit-Attention: Patrick Thier <pth...@chromium.org>
Gerrit-Comment-Date: Thu, 08 Jan 2026 12:03:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Patrick Thier (Gerrit)

unread,
Jan 8, 2026, 7:17:54 AM (23 hours ago) Jan 8
to Jakob Linke, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Jakob Linke

Patrick Thier voted and added 2 comments

Votes added by Patrick Thier

Code-Review+1

2 comments

Patchset-level comments
Patrick Thier . resolved

Very nice! LGTM

Commit Message
Line 11, Patchset 4 (Latest):Note we use DEFINE_LAZY_LEAKY_OBJECT_GETTER, so the underlying data
Patrick Thier . resolved

TIL

Open in Gerrit

Related details

Attention is currently required from:
  • Jakob Linke
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I990360bc926891801ac866620527539553828e16
Gerrit-Change-Number: 7414579
Gerrit-PatchSet: 4
Gerrit-Owner: Jakob Linke <jgr...@chromium.org>
Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
Gerrit-Reviewer: Patrick Thier <pth...@chromium.org>
Gerrit-Attention: Jakob Linke <jgr...@chromium.org>
Gerrit-Comment-Date: Thu, 08 Jan 2026 12:17:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Jakob Linke (Gerrit)

unread,
Jan 8, 2026, 7:43:25 AM (23 hours ago) Jan 8
to Patrick Thier, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com

Jakob Linke voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I990360bc926891801ac866620527539553828e16
Gerrit-Change-Number: 7414579
Gerrit-PatchSet: 4
Gerrit-Owner: Jakob Linke <jgr...@chromium.org>
Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
Gerrit-Reviewer: Patrick Thier <pth...@chromium.org>
Gerrit-Comment-Date: Thu, 08 Jan 2026 12:43:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Jan 8, 2026, 7:45:44 AM (23 hours ago) Jan 8
to Jakob Linke, Patrick Thier, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[regexp] Extract peepholes sequences into a global structure

.. to avoid creating them once per compilation / once per pass.


Note we use DEFINE_LAZY_LEAKY_OBJECT_GETTER, so the underlying data
structures are leaked (and cleaned up by the OS when the process exits).
Bug: 433891213
Change-Id: I990360bc926891801ac866620527539553828e16
Reviewed-by: Patrick Thier <pth...@chromium.org>
Commit-Queue: Jakob Linke <jgr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104558}
Files:
  • M src/regexp/regexp-bytecode-peephole.cc
Change size: M
Delta: 1 file changed, 63 insertions(+), 60 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Patrick Thier
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I990360bc926891801ac866620527539553828e16
Gerrit-Change-Number: 7414579
Gerrit-PatchSet: 5
Gerrit-Owner: Jakob Linke <jgr...@chromium.org>
Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
Gerrit-Reviewer: Patrick Thier <pth...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages